* [Bug 11602] cdrom drive cannot open the tray, but reported this badly in /proc/sys/dev/cdrom/info
2008-09-20 17:58 [Bug 11602] New: cdrom drive cannot open the tray, but reported this badly in /proc/sys/dev/cdrom/info bugme-daemon
@ 2008-09-20 17:59 ` bugme-daemon
2008-09-20 18:01 ` bugme-daemon
` (5 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: bugme-daemon @ 2008-09-20 17:59 UTC (permalink / raw)
To: linux-ide
http://bugzilla.kernel.org/show_bug.cgi?id=11602
------- Comment #1 from nm127@freemail.hu 2008-09-20 10:59 -------
Created an attachment (id=17912)
--> (http://bugzilla.kernel.org/attachment.cgi?id=17912&action=view)
cdrom tray close debug patch
--
Configure bugmail: http://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
^ permalink raw reply [flat|nested] 8+ messages in thread* [Bug 11602] cdrom drive cannot open the tray, but reported this badly in /proc/sys/dev/cdrom/info
2008-09-20 17:58 [Bug 11602] New: cdrom drive cannot open the tray, but reported this badly in /proc/sys/dev/cdrom/info bugme-daemon
2008-09-20 17:59 ` [Bug 11602] " bugme-daemon
@ 2008-09-20 18:01 ` bugme-daemon
2008-09-21 5:34 ` bugme-daemon
` (4 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: bugme-daemon @ 2008-09-20 18:01 UTC (permalink / raw)
To: linux-ide
http://bugzilla.kernel.org/show_bug.cgi?id=11602
------- Comment #2 from nm127@freemail.hu 2008-09-20 11:01 -------
Created an attachment (id=17913)
--> (http://bugzilla.kernel.org/attachment.cgi?id=17913&action=view)
dmesg 2.6.27-rc6 + debug patch from comment #1
--
Configure bugmail: http://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
^ permalink raw reply [flat|nested] 8+ messages in thread* [Bug 11602] cdrom drive cannot open the tray, but reported this badly in /proc/sys/dev/cdrom/info
2008-09-20 17:58 [Bug 11602] New: cdrom drive cannot open the tray, but reported this badly in /proc/sys/dev/cdrom/info bugme-daemon
2008-09-20 17:59 ` [Bug 11602] " bugme-daemon
2008-09-20 18:01 ` bugme-daemon
@ 2008-09-21 5:34 ` bugme-daemon
2008-09-21 20:13 ` bugme-daemon
` (3 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: bugme-daemon @ 2008-09-21 5:34 UTC (permalink / raw)
To: linux-ide
http://bugzilla.kernel.org/show_bug.cgi?id=11602
bbpetkov@yahoo.de changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |bbpetkov@yahoo.de
------- Comment #3 from bbpetkov@yahoo.de 2008-09-20 22:34 -------
On a first look, your check is wrong:
cdinfo(CD_REG_UNREG, "drive \"/dev/%s\" registered\n", cdi->name);
+ printk(KERN_DEBUG "%s:%u: cdi->mask=0x%X, (cdi->mask &
CDC_CLOSE_TRAY)=%s\n",
+ __FILE__, __LINE__, cdi->mask, (cdi->mask & CDC_CLOSE_TRAY) ?
"TRUE" : "FALSE");
you're checking against cdi->mask but if you see how CDROM_CAN is defined:
#define CDROM_CAN(type) (cdi->ops->capability & ~cdi->mask & (type))
you see that the mask is negated and also cdi->ops->capability comes into play.
However, the problem is that the CDC_CLOSE_TRAY is turned on (i.e. is going to
be off in the final check and yes, it _IS_ confusing :)) in the cdi->mask only
for devices with caddy and popup loading mechanisms. I don't think we can
reliably detect whether the drive can close its tray now on a drive-by-drive
basis - from what i see in your dmesg output, your drive is mechtype_tray and
such drives normally can close the tray. Alternatively, we could make another
list :( of drive model names which cannot close its mechanism but this is kinda
overkill imho. Jens, Bart?
--
Configure bugmail: http://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
^ permalink raw reply [flat|nested] 8+ messages in thread* [Bug 11602] cdrom drive cannot open the tray, but reported this badly in /proc/sys/dev/cdrom/info
2008-09-20 17:58 [Bug 11602] New: cdrom drive cannot open the tray, but reported this badly in /proc/sys/dev/cdrom/info bugme-daemon
` (2 preceding siblings ...)
2008-09-21 5:34 ` bugme-daemon
@ 2008-09-21 20:13 ` bugme-daemon
2008-09-22 4:42 ` bugme-daemon
` (2 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: bugme-daemon @ 2008-09-21 20:13 UTC (permalink / raw)
To: linux-ide
http://bugzilla.kernel.org/show_bug.cgi?id=11602
------- Comment #4 from nm127@freemail.hu 2008-09-21 13:13 -------
I agree that my analysis in comment #0 was wrong. I understand that the cdrom
drive itself reports the mechtype wrongly, so this seems to be a firmware
problem of the "Optiarc DVD RW AD-7543A".
Currently I cannot find any firmware updates for this device.
http://sonynec-optiarc.eu/en/support-service/downloads/fw_dvd-writer-ad-series.html
Should I ask the Optirac to provide one? If yes, what is the name of the
standard which they should to fulfill?
--
Configure bugmail: http://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
^ permalink raw reply [flat|nested] 8+ messages in thread* [Bug 11602] cdrom drive cannot open the tray, but reported this badly in /proc/sys/dev/cdrom/info
2008-09-20 17:58 [Bug 11602] New: cdrom drive cannot open the tray, but reported this badly in /proc/sys/dev/cdrom/info bugme-daemon
` (3 preceding siblings ...)
2008-09-21 20:13 ` bugme-daemon
@ 2008-09-22 4:42 ` bugme-daemon
2008-09-22 6:54 ` bugme-daemon
2008-09-23 13:56 ` bugme-daemon
6 siblings, 0 replies; 8+ messages in thread
From: bugme-daemon @ 2008-09-22 4:42 UTC (permalink / raw)
To: linux-ide
http://bugzilla.kernel.org/show_bug.cgi?id=11602
------- Comment #5 from bbpetkov@yahoo.de 2008-09-21 21:42 -------
I don't think that the drive is reporting a wrong mechtype - it still _is_
equipped with a tray loading mechanism, it simply cannot close its tray by
itself and needs user help :). Also, there's AFAIK no bit in the cdrom
capabilities page returned by the drive which will tell you whether the drive
can close itself - there's only a bit saying that the drive can eject the media
via an ATAPI command.
The only solution, AFAICT, would be an artificial one: either a list of drive
model names which cannot close their tray (ugly :( and generally frowned upon)
or trying to lock the door and read sense data (hm, unreliable, overkill?). The
wrongly reported "Can close tray" is based on the assumption that if the drive
isn't caddy or popup loader then it can close its tray automatically as is the
case with the gazillion drives out there with a tray loading mechanism.
--
Configure bugmail: http://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
^ permalink raw reply [flat|nested] 8+ messages in thread* [Bug 11602] cdrom drive cannot open the tray, but reported this badly in /proc/sys/dev/cdrom/info
2008-09-20 17:58 [Bug 11602] New: cdrom drive cannot open the tray, but reported this badly in /proc/sys/dev/cdrom/info bugme-daemon
` (4 preceding siblings ...)
2008-09-22 4:42 ` bugme-daemon
@ 2008-09-22 6:54 ` bugme-daemon
2008-09-23 13:56 ` bugme-daemon
6 siblings, 0 replies; 8+ messages in thread
From: bugme-daemon @ 2008-09-22 6:54 UTC (permalink / raw)
To: linux-ide
http://bugzilla.kernel.org/show_bug.cgi?id=11602
------- Comment #6 from nm127@freemail.hu 2008-09-21 23:54 -------
In case of a list of devices which reports "tray" and cannot close the door I
could imagine a list which is marked with __initdata and only in the memory
when the module is loading. (This is not the case for the current
ide_cd_quirks_list[] in drivers/ide/ide-cd.c .)
I don't know if similar structure to Desktop Management Interface (DMI,
http://www.dmtf.org/standards/dmi/ ) already exists for IDE. The interface (
linux/dmi.h ) is used several points of the kernel when the task is to identify
a motherboard or BIOS version.
In case you close the door and try to lock and read sense data there could be a
problem when there is no media in the drive. In this case I'm not sure that you
can lock the door at all.
--
Configure bugmail: http://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
^ permalink raw reply [flat|nested] 8+ messages in thread* [Bug 11602] cdrom drive cannot open the tray, but reported this badly in /proc/sys/dev/cdrom/info
2008-09-20 17:58 [Bug 11602] New: cdrom drive cannot open the tray, but reported this badly in /proc/sys/dev/cdrom/info bugme-daemon
` (5 preceding siblings ...)
2008-09-22 6:54 ` bugme-daemon
@ 2008-09-23 13:56 ` bugme-daemon
6 siblings, 0 replies; 8+ messages in thread
From: bugme-daemon @ 2008-09-23 13:56 UTC (permalink / raw)
To: linux-ide
http://bugzilla.kernel.org/show_bug.cgi?id=11602
bbpetkov@yahoo.de changed:
What |Removed |Added
----------------------------------------------------------------------------
AssignedTo|io_ide@kernel-bugs.osdl.org |bbpetkov@yahoo.de
Status|NEW |ASSIGNED
------- Comment #7 from bbpetkov@yahoo.de 2008-09-23 06:56 -------
Hi,
can you please try the following quick'n'dirty fix to see whether it fixes the
problem for you?
Thanks.
--
Configure bugmail: http://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
You are the assignee for the bug, or are watching the assignee.
^ permalink raw reply [flat|nested] 8+ messages in thread