From: Damien Le Moal <dlemoal@kernel.org>
To: Niklas Cassel <cassel@kernel.org>
Cc: Mika Westerberg <mika.westerberg@linux.intel.com>,
Dan Williams <dan.j.williams@intel.com>,
linux-ide@vger.kernel.org
Subject: Re: [PATCH v2 3/4] ahci: drop unused board_ahci_noncq
Date: Fri, 16 Feb 2024 07:35:38 +0900 [thread overview]
Message-ID: <c11dc521-ecc6-4dd3-a799-e577f4b3e16c@kernel.org> (raw)
In-Reply-To: <20240214130015.952685-4-cassel@kernel.org>
On 2/14/24 22:00, Niklas Cassel wrote:
> Since commit 66a7cbc303f4 ("ahci: disable MSI instead of NCQ on Samsung
> pci-e SSDs on macbooks") there is not a single entry in ahci_pci_tbl
> which uses board_ahci_noncq.
>
> Since this is dead code, let's remove it.
> We cannot remove AHCI_HFLAG_NO_NCQ, as this flag is still used by other
> boards.
>
> Signed-off-by: Niklas Cassel <cassel@kernel.org>
Looks good.
Reviewed-by: Damien Le Moal <dlemoal@kernel.org>
--
Damien Le Moal
Western Digital Research
next prev parent reply other threads:[~2024-02-15 22:35 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-14 13:00 [PATCH v2 0/4] ahci minor quirk cleanups Niklas Cassel
2024-02-14 13:00 ` [PATCH v2 1/4] ahci: rename board_ahci_nosntf Niklas Cassel
2024-02-15 22:32 ` Damien Le Moal
2024-02-14 13:00 ` [PATCH v2 2/4] ahci: clean up ahci_broken_devslp quirk Niklas Cassel
2024-02-15 22:34 ` Damien Le Moal
2024-02-14 13:00 ` [PATCH v2 3/4] ahci: drop unused board_ahci_noncq Niklas Cassel
2024-02-15 22:35 ` Damien Le Moal [this message]
2024-02-14 13:00 ` [PATCH v2 4/4] ahci: rename board_ahci_nomsi Niklas Cassel
2024-02-15 22:36 ` Damien Le Moal
2024-02-16 11:19 ` [PATCH v2 0/4] ahci minor quirk cleanups Mika Westerberg
2024-02-19 9:12 ` Niklas Cassel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c11dc521-ecc6-4dd3-a799-e577f4b3e16c@kernel.org \
--to=dlemoal@kernel.org \
--cc=cassel@kernel.org \
--cc=dan.j.williams@intel.com \
--cc=linux-ide@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).