From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bart Van Assche Subject: Re: [PATCH v3] scsi/ata: Use unsigned int for cmd's type in ioctls in scsi_host_template Date: Sun, 13 Jan 2019 20:54:35 -0800 Message-ID: References: <20181020050143.589-1-natechancellor@gmail.com> <20190114044206.6351-1-natechancellor@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20190114044206.6351-1-natechancellor@gmail.com> Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org To: Nathan Chancellor , Jens Axboe , "James E.J. Bottomley" , "Martin K. Petersen" Cc: Adaptec OEM Raid Solutions , "Manoj N. Kumar" , "Matthew R. Ochs" , Uma Krishnan , Bradley Grove , Don Brace , Brian King , linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, esc.storagedev@microsemi.com, Nick Desaulniers , Joel Stanley List-Id: linux-ide@vger.kernel.org On 1/13/19 8:42 PM, Nathan Chancellor wrote: > @@ -1292,7 +1292,7 @@ int esas2r_ioctl_handler(void *hostdata, int cmd, void __user *arg) > ioctl = memdup_user(arg, sizeof(struct atto_express_ioctl)); > if (IS_ERR(ioctl)) { > esas2r_log(ESAS2R_LOG_WARN, > - "ioctl_handler access_ok failed for cmd %d, " > + "ioctl_handler access_ok failed for cmd %u, " > "address %p", cmd, > arg); > return PTR_ERR(ioctl); If you have to repost this patch, please use that opportunity to join the above split strings. Additionally, since this patch touches much more SCSI code than ATA code I think it should have been sent to Martin instead of to Jens. Anyway: Reviewed-by: Bart Van Assche