From: Damien Le Moal <dlemoal@kernel.org>
To: Gaosheng Cui <cuigaosheng1@huawei.com>, cassel@kernel.org
Cc: linux-ide@vger.kernel.org
Subject: Re: [PATCH -next] ata: libata-scsi: Remove obsoleted declaration for ata_schedule_scsi_eh
Date: Mon, 26 Aug 2024 13:08:57 +0900 [thread overview]
Message-ID: <c91cc480-c9b2-426c-8595-0cdcf104f841@kernel.org> (raw)
In-Reply-To: <20240824121147.2521772-1-cuigaosheng1@huawei.com>
On 8/24/24 9:11 PM, Gaosheng Cui wrote:
> The ata_schedule_scsi_eh() have been removed since
> commit f8bbfc247efb ("[PATCH] SCSI: make scsi_implement_eh() generic
> API for SCSI transports"), and now it is useless, so remove it.
The path title and commit message could be better written. But see my comment
on your next patch.
>
> Signed-off-by: Gaosheng Cui <cuigaosheng1@huawei.com>
> ---
> drivers/ata/libata.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/ata/libata.h b/drivers/ata/libata.h
> index 6abf265f626e..22e667394368 100644
> --- a/drivers/ata/libata.h
> +++ b/drivers/ata/libata.h
> @@ -124,7 +124,6 @@ extern void ata_scsi_set_sense_information(struct ata_device *dev,
> const struct ata_taskfile *tf);
> extern void ata_scsi_media_change_notify(struct ata_device *dev);
> extern void ata_scsi_hotplug(struct work_struct *work);
> -extern void ata_schedule_scsi_eh(struct Scsi_Host *shost);
> extern void ata_scsi_dev_rescan(struct work_struct *work);
> extern int ata_scsi_user_scan(struct Scsi_Host *shost, unsigned int channel,
> unsigned int id, u64 lun);
--
Damien Le Moal
Western Digital Research
prev parent reply other threads:[~2024-08-26 4:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-24 12:11 [PATCH -next] ata: libata-scsi: Remove obsoleted declaration for ata_schedule_scsi_eh Gaosheng Cui
2024-08-26 4:08 ` Damien Le Moal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c91cc480-c9b2-426c-8595-0cdcf104f841@kernel.org \
--to=dlemoal@kernel.org \
--cc=cassel@kernel.org \
--cc=cuigaosheng1@huawei.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).