* [PATCH -next] ata: libata-scsi: Remove obsoleted declaration for ata_schedule_scsi_eh
@ 2024-08-24 12:11 Gaosheng Cui
2024-08-26 4:08 ` Damien Le Moal
0 siblings, 1 reply; 2+ messages in thread
From: Gaosheng Cui @ 2024-08-24 12:11 UTC (permalink / raw)
To: dlemoal, cassel, cuigaosheng1; +Cc: linux-ide
The ata_schedule_scsi_eh() have been removed since
commit f8bbfc247efb ("[PATCH] SCSI: make scsi_implement_eh() generic
API for SCSI transports"), and now it is useless, so remove it.
Signed-off-by: Gaosheng Cui <cuigaosheng1@huawei.com>
---
drivers/ata/libata.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/ata/libata.h b/drivers/ata/libata.h
index 6abf265f626e..22e667394368 100644
--- a/drivers/ata/libata.h
+++ b/drivers/ata/libata.h
@@ -124,7 +124,6 @@ extern void ata_scsi_set_sense_information(struct ata_device *dev,
const struct ata_taskfile *tf);
extern void ata_scsi_media_change_notify(struct ata_device *dev);
extern void ata_scsi_hotplug(struct work_struct *work);
-extern void ata_schedule_scsi_eh(struct Scsi_Host *shost);
extern void ata_scsi_dev_rescan(struct work_struct *work);
extern int ata_scsi_user_scan(struct Scsi_Host *shost, unsigned int channel,
unsigned int id, u64 lun);
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH -next] ata: libata-scsi: Remove obsoleted declaration for ata_schedule_scsi_eh
2024-08-24 12:11 [PATCH -next] ata: libata-scsi: Remove obsoleted declaration for ata_schedule_scsi_eh Gaosheng Cui
@ 2024-08-26 4:08 ` Damien Le Moal
0 siblings, 0 replies; 2+ messages in thread
From: Damien Le Moal @ 2024-08-26 4:08 UTC (permalink / raw)
To: Gaosheng Cui, cassel; +Cc: linux-ide
On 8/24/24 9:11 PM, Gaosheng Cui wrote:
> The ata_schedule_scsi_eh() have been removed since
> commit f8bbfc247efb ("[PATCH] SCSI: make scsi_implement_eh() generic
> API for SCSI transports"), and now it is useless, so remove it.
The path title and commit message could be better written. But see my comment
on your next patch.
>
> Signed-off-by: Gaosheng Cui <cuigaosheng1@huawei.com>
> ---
> drivers/ata/libata.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/ata/libata.h b/drivers/ata/libata.h
> index 6abf265f626e..22e667394368 100644
> --- a/drivers/ata/libata.h
> +++ b/drivers/ata/libata.h
> @@ -124,7 +124,6 @@ extern void ata_scsi_set_sense_information(struct ata_device *dev,
> const struct ata_taskfile *tf);
> extern void ata_scsi_media_change_notify(struct ata_device *dev);
> extern void ata_scsi_hotplug(struct work_struct *work);
> -extern void ata_schedule_scsi_eh(struct Scsi_Host *shost);
> extern void ata_scsi_dev_rescan(struct work_struct *work);
> extern int ata_scsi_user_scan(struct Scsi_Host *shost, unsigned int channel,
> unsigned int id, u64 lun);
--
Damien Le Moal
Western Digital Research
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-08-26 4:08 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-08-24 12:11 [PATCH -next] ata: libata-scsi: Remove obsoleted declaration for ata_schedule_scsi_eh Gaosheng Cui
2024-08-26 4:08 ` Damien Le Moal
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).