From: Damien Le Moal <dlemoal@kernel.org>
To: kensanya@163.com, cassel@kernel.org
Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org,
TanZheng <tanzheng@kylinos.cn>
Subject: Re: [PATCH] ahci: use hweight_long() to count port_map bits
Date: Thu, 28 May 2026 14:27:15 +0900 [thread overview]
Message-ID: <ca92885c-0a61-4574-9136-bed6596dd72a@kernel.org> (raw)
In-Reply-To: <cd21e56b-04de-4b29-bc4a-d936ac8d29bb@kernel.org>
On 5/28/26 03:18, Damien Le Moal wrote:
> On 2026/05/27 18:17, kensanya@163.com wrote:
>> From: TanZheng <tanzheng@kylinos.cn>
>>
>> Replace the open loop used to calculate the number of set bits
>> in the port mapping with the `hweight_long()` function, which
>> simplifies the code without altering its functionality.
>>
>> Signed-off-by: TanZheng <tanzheng@kylinos.cn>
>
> This looks good to me. But as Niklas commented, if this needs a Suggested-by
> tag, please add it.
>
> Reviewed-by: Damien Le Moal <dlemoal@kernel.org>
Note: the patch title should be:
ata: libahci: use hweight_long() to count port_map bits
Maybe Niklas can fix this when applying.
--
Damien Le Moal
Western Digital Research
next prev parent reply other threads:[~2026-05-28 5:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-27 9:17 [PATCH] ahci: use hweight_long() to count port_map bits kensanya
2026-05-27 13:10 ` Niklas Cassel
2026-05-27 18:18 ` Damien Le Moal
2026-05-28 5:27 ` Damien Le Moal [this message]
2026-05-28 5:57 ` kensanya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ca92885c-0a61-4574-9136-bed6596dd72a@kernel.org \
--to=dlemoal@kernel.org \
--cc=cassel@kernel.org \
--cc=kensanya@163.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tanzheng@kylinos.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox