From: Sergey Shtylyov <s.shtylyov@omp.ru>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
Damien Le Moal <dlemoal@kernel.org>,
Niklas Cassel <cassel@kernel.org>
Cc: <linux-kernel@vger.kernel.org>, <kernel-janitors@vger.kernel.org>,
<linux-ide@vger.kernel.org>
Subject: Re: [PATCH] ata: Constify struct pci_device_id
Date: Sun, 17 Nov 2024 16:04:15 +0300 [thread overview]
Message-ID: <caafe4bf-7854-4ca9-b782-f317599ed1c8@omp.ru> (raw)
In-Reply-To: <8bddfee7f6f0f90eeb6da7156e30ab3bd553deb1.1731704917.git.christophe.jaillet@wanadoo.fr>
On 11/16/24 12:08 AM, Christophe JAILLET wrote:
> 'struct pci_device_id' is not modified in these drivers.
>
> Constifying this structure moves some data to a read-only section, so
> increase overall security.
>
> On a x86_64, with allmodconfig, as an example:
> Before:
> ======
> text data bss dec hex filename
> 4245 1454 4 5703 1647 drivers/ata/ata_generic.o
>
> After:
> =====
> text data bss dec hex filename
> 4725 974 4 5703 1647 drivers/ata/ata_generic.o
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
[...]
No longer an "official" PATA reviewer, but FWIW:
Reviewed-by: Sergey Shtylyov <s.shtylyov@omp.ru>
MBR, Sergey
next prev parent reply other threads:[~2024-11-17 13:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-15 21:08 [PATCH] ata: Constify struct pci_device_id Christophe JAILLET
2024-11-17 13:04 ` Sergey Shtylyov [this message]
2024-11-18 11:42 ` Niklas Cassel
2024-12-03 4:16 ` Niklas Cassel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=caafe4bf-7854-4ca9-b782-f317599ed1c8@omp.ru \
--to=s.shtylyov@omp.ru \
--cc=cassel@kernel.org \
--cc=christophe.jaillet@wanadoo.fr \
--cc=dlemoal@kernel.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox