From: Damien Le Moal <dlemoal@kernel.org>
To: Arnd Bergmann <arnd@kernel.org>
Cc: Arnd Bergmann <arnd@arndb.de>,
Sergey Shtylyov <s.shtylyov@omp.ru>,
Jon Hunter <jonathanh@nvidia.com>,
Bart Van Assche <bvanassche@acm.org>,
linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] [v2] ata: pata_ns87415: mark ns87560_tf_read static
Date: Thu, 27 Jul 2023 08:45:19 +0900 [thread overview]
Message-ID: <ce6e2fbe-1c74-44e1-7499-5542747426bd@kernel.org> (raw)
In-Reply-To: <20230726203354.946631-1-arnd@kernel.org>
On 7/27/23 05:33, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> The global function triggers a warning because of the missing prototype
>
> drivers/ata/pata_ns87415.c:263:6: warning: no previous prototype for 'ns87560_tf_read' [-Wmissing-prototypes]
> 263 | void ns87560_tf_read(struct ata_port *ap, struct ata_taskfile *tf)
>
> There are no other references to this, so just make it static.
>
> Fixes: c4b5b7b6c4423 ("pata_ns87415: Initial cut at 87415/87560 IDE support")
> Reviewed-by: Sergey Shtylyov <s.shtylyov@omp.ru>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Applied to for-6.5-fixes. Thanks !
--
Damien Le Moal
Western Digital Research
prev parent reply other threads:[~2023-07-26 23:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-26 20:33 [PATCH] [v2] ata: pata_ns87415: mark ns87560_tf_read static Arnd Bergmann
2023-07-26 23:45 ` Damien Le Moal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ce6e2fbe-1c74-44e1-7499-5542747426bd@kernel.org \
--to=dlemoal@kernel.org \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=bvanassche@acm.org \
--cc=jonathanh@nvidia.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=s.shtylyov@omp.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox