From: Damien Le Moal <dlemoal@kernel.org>
To: Myeonghun Pak <mhun512@gmail.com>,
Linus Walleij <linusw@kernel.org>,
Niklas Cassel <cassel@kernel.org>
Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org,
Ijae Kim <ae878000@gmail.com>
Subject: Re: [PATCH] ata: sata_gemini: unwind clocks on IDE pinctrl errors
Date: Sat, 27 Jun 2026 06:43:34 +0900 [thread overview]
Message-ID: <d06d7d2e-d7c1-423d-b35a-c56530a89b63@kernel.org> (raw)
In-Reply-To: <20260626085848.40199-1-mhun512@gmail.com>
On 6/26/26 17:58, Myeonghun Pak wrote:
> gemini_sata_bridge_init() prepares and enables both SATA PCLKs, then
> disables them again while keeping the clocks prepared for later bridge
> start and stop operations. If gemini_setup_ide_pins() fails after that,
> gemini_sata_probe() returns directly and skips the existing
> out_unprep_clk unwind path.
>
> Route the IDE pinctrl failure through out_unprep_clk so the clocks
> prepared by gemini_sata_bridge_init() are unprepared before probe
> fails.
>
> Fixes: d872ced29d5f ("ata: sata_gemini: Introduce explicit IDE pin control")
> Co-developed-by: Ijae Kim <ae878000@gmail.com>
> Signed-off-by: Ijae Kim <ae878000@gmail.com>
> Signed-off-by: Myeonghun Pak <mhun512@gmail.com>
Applied to for-7.2-fixes. Thanks!
--
Damien Le Moal
Western Digital Research
prev parent reply other threads:[~2026-06-26 21:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-26 8:58 [PATCH] ata: sata_gemini: unwind clocks on IDE pinctrl errors Myeonghun Pak
2026-06-26 9:10 ` sashiko-bot
2026-06-26 11:15 ` Niklas Cassel
2026-06-26 11:32 ` Damien Le Moal
2026-06-26 11:35 ` Niklas Cassel
2026-06-26 11:38 ` Damien Le Moal
2026-06-26 12:55 ` Linus Walleij
2026-06-26 21:43 ` Damien Le Moal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d06d7d2e-d7c1-423d-b35a-c56530a89b63@kernel.org \
--to=dlemoal@kernel.org \
--cc=ae878000@gmail.com \
--cc=cassel@kernel.org \
--cc=linusw@kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mhun512@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox