From: Damien Le Moal <dlemoal@kernel.org>
To: Josua Mayer <josua@solid-run.com>,
Niklas Cassel <cassel@kernel.org>,
Hans de Goede <hdegoede@redhat.com>
Cc: Jon Nettleton <jon@solid-run.com>,
Mikhail Anikin <mikhail.anikin@solid-run.com>,
Yazan Shhady <yazan.shhady@solid-run.com>,
Rabeeh Khoury <rabeeh@solid-run.com>,
linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] ata: libahci_platform: support non-consecutive port numbers
Date: Mon, 6 Jan 2025 14:27:47 +0900 [thread overview]
Message-ID: <d17e611d-8590-4085-b995-0cf3ca071746@kernel.org> (raw)
In-Reply-To: <20250101-ahci-nonconsecutive-ports-v2-1-38a48f357321@solid-run.com>
On 1/1/25 9:13 PM, Josua Mayer wrote:
> So far ahci_platform relied on number of child nodes in firmware to
> allocate arrays and expected port numbers to start from 0 without holes.
> This number of ports is then set in private structure for use when
> configuring phys and regulators.
>
> Some platforms may not use every port of an ahci controller.
> E.g. SolidRUN CN9130 Clearfog uses only port 1 but not port 0, leading
> to the following errors during boot:
> [ 1.719476] ahci f2540000.sata: invalid port number 1
> [ 1.724562] ahci f2540000.sata: No port enabled
>
> Update all accessesors of ahci_host_priv phys and target_pwrs arrays to
> support holes. Access is gated by hpriv->mask_port_map which has a bit
> set for each enabled port.
>
> Update ahci_platform_get_resources to ignore holes in the port numbers
> and enable ports defined in firmware by their reg property only.
>
> When firmware does not define children it is assumed that there is
> exactly one port, using index 0.
>
> Signed-off-by: Josua Mayer <josua@solid-run.com>
Applied to for-6.14. Thanks !
--
Damien Le Moal
Western Digital Research
next prev parent reply other threads:[~2025-01-06 5:28 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-01 12:13 [PATCH v2] ata: libahci_platform: support non-consecutive port numbers Josua Mayer
2025-01-01 13:17 ` Hans de Goede
2025-01-06 5:27 ` Damien Le Moal [this message]
2025-02-05 18:03 ` Klaus Kudielka
2025-02-06 1:34 ` Damien Le Moal
2025-02-06 18:42 ` Klaus Kudielka
2025-02-07 11:22 ` Josua Mayer
2025-02-07 19:45 ` Klaus Kudielka
2025-02-08 13:39 ` Josua Mayer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d17e611d-8590-4085-b995-0cf3ca071746@kernel.org \
--to=dlemoal@kernel.org \
--cc=cassel@kernel.org \
--cc=hdegoede@redhat.com \
--cc=jon@solid-run.com \
--cc=josua@solid-run.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mikhail.anikin@solid-run.com \
--cc=rabeeh@solid-run.com \
--cc=yazan.shhady@solid-run.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox