From: Damien Le Moal <dlemoal@kernel.org>
To: Heiner Kallweit <hkallweit1@gmail.com>,
Niklas Cassel <cassel@kernel.org>
Cc: linux-ide@vger.kernel.org
Subject: Re: [PATCH 2/5] ata: libata-transport: inline ata_attach|release_transport
Date: Tue, 31 Mar 2026 10:29:23 +0900 [thread overview]
Message-ID: <d1916d58-6bba-44fa-943e-a8f879619586@kernel.org> (raw)
In-Reply-To: <f9d372b0-cd10-46b2-821f-80c4c29c8992@gmail.com>
On 3/31/26 12:18 AM, Heiner Kallweit wrote:
> Both functions can be merged into libata_transport_init() and
> libata_transport_exit() respectively, thus simplifying the code.
That is not really simplifying anything but rather removing somewhat
unnecessary helper functions that are being called once only. So let's just say
that here.
Other than this, looks OK.
Reviewed-by: Damien Le Moal <dlemoal@kernel.org>
--
Damien Le Moal
Western Digital Research
next prev parent reply other threads:[~2026-03-31 1:35 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-30 15:17 [PATCH 0/5] ata: libata-transport: series with further refactorings Heiner Kallweit
2026-03-30 15:18 ` [PATCH 1/5] ata: libata-transport: instantiate struct ata_internal statically Heiner Kallweit
2026-03-31 1:26 ` Damien Le Moal
2026-04-07 10:29 ` Hannes Reinecke
2026-03-30 15:18 ` [PATCH 2/5] ata: libata-transport: inline ata_attach|release_transport Heiner Kallweit
2026-03-31 1:29 ` Damien Le Moal [this message]
2026-04-07 10:30 ` Hannes Reinecke
2026-03-30 15:19 ` [PATCH 3/5] ata: libata-transport: use static struct ata_transport_internal to simplify match functions Heiner Kallweit
2026-03-31 1:37 ` Damien Le Moal
2026-04-07 10:32 ` Hannes Reinecke
2026-03-30 15:20 ` [PATCH 4/5] ata: libata-transport: split struct ata_internal Heiner Kallweit
2026-03-31 1:41 ` Damien Le Moal
2026-04-07 10:33 ` Hannes Reinecke
2026-03-30 15:21 ` [PATCH 5/5] ata: libata-transport: remove static variable ata_scsi_transport_template Heiner Kallweit
2026-03-31 1:42 ` Damien Le Moal
2026-03-31 11:41 ` Sergey Shtylyov
2026-03-31 20:09 ` Damien Le Moal
2026-04-07 10:39 ` Hannes Reinecke
2026-04-07 12:44 ` Heiner Kallweit
2026-04-02 8:34 ` [PATCH 0/5] ata: libata-transport: series with further refactorings Niklas Cassel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d1916d58-6bba-44fa-943e-a8f879619586@kernel.org \
--to=dlemoal@kernel.org \
--cc=cassel@kernel.org \
--cc=hkallweit1@gmail.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox