* [PATCH] ata: Use str_up_down() helper in vt6420_prereset()
@ 2025-02-19 20:35 Salah Triki
2025-02-20 4:13 ` Damien Le Moal
0 siblings, 1 reply; 2+ messages in thread
From: Salah Triki @ 2025-02-19 20:35 UTC (permalink / raw)
To: dlemoal, cassel, linux-ide, linux-kernel; +Cc: Salah Triki
Remove hard-coded strings by using the str_up_down() helper function.
Signed-off-by: Salah Triki <salah.triki@gmail.com>
---
drivers/ata/sata_via.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/ata/sata_via.c b/drivers/ata/sata_via.c
index 57cbf2cef618..4ecd8f33b082 100644
--- a/drivers/ata/sata_via.c
+++ b/drivers/ata/sata_via.c
@@ -25,6 +25,7 @@
#include <scsi/scsi_cmnd.h>
#include <scsi/scsi_host.h>
#include <linux/libata.h>
+#include <linux/string_choices.h>
#define DRV_NAME "sata_via"
#define DRV_VERSION "2.6"
@@ -359,7 +360,7 @@ static int vt6420_prereset(struct ata_link *link, unsigned long deadline)
ata_port_info(ap,
"SATA link %s 1.5 Gbps (SStatus %X SControl %X)\n",
- online ? "up" : "down", sstatus, scontrol);
+ str_up_down(online), sstatus, scontrol);
/* SStatus is read one more time */
svia_scr_read(link, SCR_STATUS, &sstatus);
--
2.34.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ata: Use str_up_down() helper in vt6420_prereset()
2025-02-19 20:35 [PATCH] ata: Use str_up_down() helper in vt6420_prereset() Salah Triki
@ 2025-02-20 4:13 ` Damien Le Moal
0 siblings, 0 replies; 2+ messages in thread
From: Damien Le Moal @ 2025-02-20 4:13 UTC (permalink / raw)
To: Salah Triki, cassel, linux-ide, linux-kernel
On 2/20/25 5:35 AM, Salah Triki wrote:
> Remove hard-coded strings by using the str_up_down() helper function.
>
> Signed-off-by: Salah Triki <salah.triki@gmail.com>
This looks OK but the patch title should be:
ata: sata_via: Use str_up_down() helper in vt6420_prereset()
With that fixed,
Reviewed-by: Damien Le Moal <dlemoal@kernel.org>
--
Damien Le Moal
Western Digital Research
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-02-20 4:13 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-02-19 20:35 [PATCH] ata: Use str_up_down() helper in vt6420_prereset() Salah Triki
2025-02-20 4:13 ` Damien Le Moal
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).