Re: [PATCH 5/5] ata: libata-transport: remove static variable ata_scsi_transport_template

[Heiner Kallweit <hkallweit1@gmail.com>]

On 07.04.2026 12:39, Hannes Reinecke wrote:
> On 3/30/26 17:21, Heiner Kallweit wrote:
>> Simplify the code by making struct ata_scsi_transportt public, instead
>> of using separate variable ata_scsi_transport_template.
>>
>> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
>> ---
>>   drivers/ata/libata-scsi.c      | 2 +-
>>   drivers/ata/libata-transport.c | 9 ++-------
>>   drivers/ata/libata-transport.h | 2 +-
>>   3 files changed, 4 insertions(+), 9 deletions(-)
>>
> Huh. Not a big fan of this.
> 
> The idea of using a pointer is that it'll be initialized to 'NULL'
> if the module / file isn't present.
> Exposing a static pointer is tricky in that regard.
> 
Provider (libata-transport) and consumer (libata-scsi) of this static
struct are always built together:

libata-y	:= libata-core.o libata-scsi.o libata-eh.o \
	libata-transport.o libata-trace.o

> Not sure if that is the direction we want to go, but I'll leave it
> to the maintainers to decide.
> 
> Cheers,
> 
> Hannes