From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B675426FA50; Thu, 28 Aug 2025 18:20:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=205.220.165.32 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756405208; cv=fail; b=GLcMmUI9cLsHOK1ObeuS0TiRamjvvV5C8e0CMB5NBNsFNKPGrFPm5CIkb9XTFB7V8ycIbwvUWDIPAdsK9UIr9r0X1GT6ZCEhDUeMpNfIRDU7jpgWDzMAOeUk5JffC6hNaL6ijaOfgeKUeA33dOCb16sG08aUlcq5ks2422AkXvk= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756405208; c=relaxed/simple; bh=XunjdBxO9fItgV4vXSxOlKc9WoXJMdeS6XRfZjl74pU=; h=Date:From:To:Cc:Subject:Message-ID:References:Content-Type: Content-Disposition:In-Reply-To:MIME-Version; b=TO6lQnyw0iyIOl3WQIgyl8N+rju83OB0fukeGwwbg2TXxPoTmQ6mx/NqyVpAA0HH3lmYSU6bv+znL470f2UnCIeoMIi/YuK1Rs9M6wGjbWkKd8bEDDfv7Z0GCtF93kWR0i0Fej9GzOOjTxpptD7m17dUDU1XUzeTYWJ7h+MtUW8= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oracle.com; spf=pass smtp.mailfrom=oracle.com; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b=oBhMt8j3; dkim=pass (1024-bit key) header.d=oracle.onmicrosoft.com header.i=@oracle.onmicrosoft.com header.b=H2j7Bp2F; arc=fail smtp.client-ip=205.220.165.32 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oracle.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oracle.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="oBhMt8j3"; dkim=pass (1024-bit key) header.d=oracle.onmicrosoft.com header.i=@oracle.onmicrosoft.com header.b="H2j7Bp2F" Received: from pps.filterd (m0333521.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 57SHNXNv019192; Thu, 28 Aug 2025 18:19:29 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=cc :content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=corp-2025-04-25; bh=N+mZkfZTLMtwBxeI/7 +WrcodtVCJZHK5OJOkLv53PHU=; b=oBhMt8j3ixyC7wzE4CgMJmF+fCs6d63l2+ WY9/7MJH8oX3iJOI8snREFgE537Zt9ituTbTZOiRNwdAS/lTQ9rqOdysOdPTMFrz kCK2YAs9/sWCZwxIVVQFRQ1TUNAefG7bgahHRSp6/WhhNgyWpuDPjukFpYTEFbb0 wV9p2lC/v+OhYe6LvjJQdG52kBPQDxd3KB+GB2aPik2w47vV2/QKnWGtIRht2Jod dut+GoY+ZWkS6vwipfeUnwkUnIyWoS6WusSNiHX5QexVJuZEfbGtaw2rlOQB/W0+ D4VdGm2PyHgck1nmrXg1ZV0Y2P/zHRFGUDNzz50CWhqJXx3r48XA== Received: from phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta02.appoci.oracle.com [147.154.114.232]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 48q4jas59x-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 28 Aug 2025 18:19:29 +0000 (GMT) Received: from pps.filterd (phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (8.18.1.2/8.18.1.2) with ESMTP id 57SH4aBN027290; Thu, 28 Aug 2025 18:19:28 GMT Received: from byapr05cu005.outbound.protection.outlook.com (mail-westusazon11010028.outbound.protection.outlook.com [52.101.85.28]) by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 48q43c3vbk-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 28 Aug 2025 18:19:28 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=QllXEEEQnj0YNUg1ijz5q99TjA1+Muw1ztnRFrsbGvGMMpXMEy5gz/9gqyOKatgOcXmWoPaKpWui0tpx2Wk+lfaqP9e7EBeCHr/K2iEVaFLvj79IZSE7CZlKQgTOYkQeJfX0/esNmSGW7yTh5w2cAOvE284J53BhvNOtBzDLJFPeZFWwuRRXR+0E3srOlthS8482stfyRIuXRLAjFvHRvKtOFQe+6ul8ULDvfwDfFrBiElJpdEBEJY5mt06SaYVs7AKQDTz/NI/QqFR9Vn/HsmiIL2hN+y1LZ8srC/mxn1WjM4+oVuhzzx5eNbfHm5YSOtBYRI/7dfKD+SGIU1/X1A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=N+mZkfZTLMtwBxeI/7+WrcodtVCJZHK5OJOkLv53PHU=; b=A2+72MGtlNSRKujo4v+jke3qiCjz+3fZ6up2N2aILzmuQ5jlPbvpfZ62mSguVTYj3LJNoaLHqATRfkzJAYuACB+EkZxNQHkxJmTPlvrDpziurc4o4qPpi+vX9VcM3WgDAyn9F0qXkZaMAe/suuscVbaH/D0hb3ZWi3pAlkMEvFfwdIw3xia08QBbXMeR+XrN61ZOGQOWc8fgCOtvauItto6zIC3javo2pmDHNJiz/53/j6uzcB5PYetVkMoCTxuWxz4dt3+7/hanAJnNqgCUM769uYUH7b1gz74C6b8jiLorweDoPTyhT6Z/1Lwz2NpIUg8aww1s+zg7urFflYSSow== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=N+mZkfZTLMtwBxeI/7+WrcodtVCJZHK5OJOkLv53PHU=; b=H2j7Bp2FNtAuWSrInqby14ZDQWuE24ygdaUoq8c2Y2FMUpWVjW8NmwI3JbNk0q/eR7qkH27k42Y8gmU95OE8Spjgn5OZja6PJwAkObEc6G9wOyL4OMUE7lVfT3lr+Hb9d9gG7C1+eZYXS8x1BVrCrz7i3RjmUpbm3UMSMIVvmnY= Received: from DM4PR10MB8218.namprd10.prod.outlook.com (2603:10b6:8:1cc::16) by CY8PR10MB6873.namprd10.prod.outlook.com (2603:10b6:930:84::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9073.17; Thu, 28 Aug 2025 18:19:20 +0000 Received: from DM4PR10MB8218.namprd10.prod.outlook.com ([fe80::2650:55cf:2816:5f2]) by DM4PR10MB8218.namprd10.prod.outlook.com ([fe80::2650:55cf:2816:5f2%5]) with mapi id 15.20.9052.019; Thu, 28 Aug 2025 18:19:20 +0000 Date: Thu, 28 Aug 2025 19:19:12 +0100 From: Lorenzo Stoakes To: David Hildenbrand Cc: linux-kernel@vger.kernel.org, Alexander Potapenko , Marco Elver , Dmitry Vyukov , Andrew Morton , Brendan Jackman , Christoph Lameter , Dennis Zhou , dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, iommu@lists.linux.dev, io-uring@vger.kernel.org, Jason Gunthorpe , Jens Axboe , Johannes Weiner , John Hubbard , kasan-dev@googlegroups.com, kvm@vger.kernel.org, "Liam R. Howlett" , Linus Torvalds , linux-arm-kernel@axis.com, linux-arm-kernel@lists.infradead.org, linux-crypto@vger.kernel.org, linux-ide@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-mips@vger.kernel.org, linux-mmc@vger.kernel.org, linux-mm@kvack.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-scsi@vger.kernel.org, Marek Szyprowski , Michal Hocko , Mike Rapoport , Muchun Song , netdev@vger.kernel.org, Oscar Salvador , Peter Xu , Robin Murphy , Suren Baghdasaryan , Tejun Heo , virtualization@lists.linux.dev, Vlastimil Babka , wireguard@lists.zx2c4.com, x86@kernel.org, Zi Yan Subject: Re: [PATCH v1 34/36] kfence: drop nth_page() usage Message-ID: References: <20250827220141.262669-1-david@redhat.com> <20250827220141.262669-35-david@redhat.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250827220141.262669-35-david@redhat.com> X-ClientProxiedBy: LO4P123CA0512.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:272::18) To DM4PR10MB8218.namprd10.prod.outlook.com (2603:10b6:8:1cc::16) Precedence: bulk X-Mailing-List: linux-ide@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM4PR10MB8218:EE_|CY8PR10MB6873:EE_ X-MS-Office365-Filtering-Correlation-Id: 2466e27b-02b8-4582-f3a0-08dde65f6825 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|376014|366016|7416014|7053199007; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?EeKxciEqmIgFvQJTbPI9Kg5rZOhmnU6YHD6uvUK0ez+DPTDiAiOEX2Xuhc+f?= =?us-ascii?Q?C45H5CqbSFTj19CAerC9MI4JKDLGiZvggJNRdwjXQcooBhTUb+lY45UPOq/u?= =?us-ascii?Q?M7zJhrwpG9UwIgjCh4ee+OJa24Z+XJL9RH8t+v81pXG3VnOpUxWKuUHpUtH+?= =?us-ascii?Q?5vdltJZI8AHfI9BtBqH0mTDMzahfXrO+oUKf8qx0J64o7kVJLd/+JsC0qiFg?= =?us-ascii?Q?7BDqmO5U+174iIq4Fri79s3IlBh2FFerOm9TjLEGAP8r5kp6BjY6W4cnUIJM?= =?us-ascii?Q?w4pbU8X5Wi2hyg+79QOI2Vv2W6ZAtSDys2A5qj9xATPtABEAmVULbDY4uNUU?= =?us-ascii?Q?qLcS/kT0ElmIi63skR7tq+oWzRV7VrShFvPA1PLJrIS47r3JSdCz3rUIccGb?= =?us-ascii?Q?fcQHof+n4nd7wj/P61O3QIOiHzgu4FlyaysMQ79/0a5XevI/hbL/vTxq+yrJ?= =?us-ascii?Q?D5d15LNF3eMikJZE7EVIAAdGqqAnZDLXCYw43lXxyp3GDPX2awT9iH+7yMYV?= =?us-ascii?Q?gaBYl7NJqC7Q+VrHnTVbd1v1m/XfT2CIsl/KRf9dZTZwQZe+HiXD5NMtYnFL?= =?us-ascii?Q?3KAWTzCEneJ5OMKTFeiAM3s0yhnQgQ6ZhxB6ZDvGJUF0hiCxLIOA+PkUGDbx?= =?us-ascii?Q?3B9AcFf9J7mPRB0BOdegUbpPEhzcIaKtsTShI5jvsA4nsQ36ocM1Yl8M9sKb?= =?us-ascii?Q?DYxMdQNcU9WTcrr6/87PhDYU7h6FQF2nzVywqR07HyjUHF/2159RS+b48RrN?= =?us-ascii?Q?RsDs+MCf/0Rdm7HfFeE2EbLkZf73tNOtRs4W745EplZynUTGXEK8ae5SZTJh?= =?us-ascii?Q?mAJCZamxTRWcJ307JZgCniyHsy0qMfGw6O6bHzY9xz8uUNPP7VFoyf8a/bYn?= =?us-ascii?Q?S422nqwN21bllV/j5+yJfIY45CVRdBtfRVNwjUZmWT7UikqcADSYhp7+iDkH?= =?us-ascii?Q?DETTXHcuXqdc5sw8oPcA5XR39iV7iX6APbtQEYyW4gdcM2RXbINRJdT2pC6l?= =?us-ascii?Q?Q/l9XLM3zIQNnEtfhpOun6Z7StgaLEJUe4S/Rto0FKy+jMtlza35gaEpeU2P?= =?us-ascii?Q?Pg+rKhYxOViSmZYezxdwd59tJ8hThesAt5DTTrxLvCt6tL6yzIcF71XL+o0N?= =?us-ascii?Q?OFS+S/0ga3UPpCy0zCjqmG0Hn9WT69ogZTLgU4JBpXqHE5mtLQxgWNxkc3JE?= =?us-ascii?Q?09ZsjxsmhSjGLBCALXE5NjCNUjlwscOxrUtT1dOXMWbD1UQjcdOtMDWmX4Gv?= =?us-ascii?Q?B03vRLy3fvDH6qkidPQ8jwJpeYilV1OW2cWabOmcYX+6iOSJGupQTYDJVzBK?= =?us-ascii?Q?iNvGDd4dOkJDVFEtximv2IiILBfwPAFEE4KoUSNcTuUA0cVNicBT5SOmDerf?= =?us-ascii?Q?LmZOXFEkROMnTcyQsbpOnzmq4/SBC5VDgDxRkWZXjQXbl6NqPj7s7n4jrnbd?= =?us-ascii?Q?KqjMzfSk7EI=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM4PR10MB8218.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(376014)(366016)(7416014)(7053199007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?5YibZq3a6ChVbDWI3XVAX+/oCVwVei0vAiaJid0Ob3oYPdMxnuBIbf1KjCQ2?= =?us-ascii?Q?ZpeM7BSk4hW1KynunvWpIaEUHLqv8s+VNszJg9iNblrs9+i0TTRdjx/OfyZz?= =?us-ascii?Q?GqAjaAoikkgxxzSrHSb7Pw93xUclo4gGoeX6u3YXCYE+R6BgnWR3btItpd8S?= =?us-ascii?Q?wglHvvRspMDOzAUNpdGsaZCeyQ/QpPTePkFZ9gnFOwoyx4YJmYMBDr2Rwyqq?= =?us-ascii?Q?hkcd0b4kK0axIuMmOkbZf1rgwocJKGF1bl//rXl62pD5qG1WxAeO814vkTJe?= =?us-ascii?Q?ZdEsn0H7bQb6CpmU2dhBugHJRZ96NwGAbtaleSG85UjY8ZQGISdJur6m305H?= =?us-ascii?Q?aFENkzdgcwwV6aw7+QWQLA0zAweyYZuTqN3BjcNzl4VIBOOGBnbi88rlgNga?= =?us-ascii?Q?E1OzDvWdCjWTl2LBrkHbyOsGIS8dnc3HkuLL460CkGL12ic5KOrbGfdYDgVS?= =?us-ascii?Q?YHfiviNmmmHYjeui40VkXtKj7Oeq7tB6BPlD0/JYR5fHFtNxY7v/VDC+2vVA?= =?us-ascii?Q?UASivi+37MXzgcx35v0nqmAoUOygdlk+/CStt7gpHw0QgC4PMNmrmUXyj6mg?= =?us-ascii?Q?m0hxGjIqHKYTdFM1GtGJ4bbOqeTVbhEjDmkYs1q4Ec5INMaH4oS+W4OhuLyj?= =?us-ascii?Q?D8hXZFxM++eYm81dRQt+/kGQeVdHdfU3/TzClWEhnG5LkuyW4A5gOmI6aQho?= =?us-ascii?Q?D3qPYnDw0eugOTNpkHMD69QEhJCamwrOfgxX9Brw+Pw0tltx+CfGYchMoxIc?= =?us-ascii?Q?diA8PEWl5e+6A3hTjvAvDSPRUJd15CQGYiqRdkzUq7YCeQ360sdf9Cs8QfQq?= =?us-ascii?Q?3KN47jcBHsC4eu9JEMWFCHv4VskWD13eL17t5TXZl6lx7k+arZtW1/EHLaai?= =?us-ascii?Q?C+8NLjarlewA9gte6k9BWgHBlsjBi6Z8Z+r8kPaZKvIP2R3VqBZsjVMNTZeW?= =?us-ascii?Q?/8fRVJ6bFF1SEGYMOt+QwHPxL0ORbd1Wui8+HaUF8vVUyDJkee0pVnywcCP1?= =?us-ascii?Q?ohhoGq/LUxp4qiMlbbU62mmSHMrrGG4hEyZUIxN0/1AgoFGg4D/hhnfs1YYz?= =?us-ascii?Q?tG9mS3UKHyTnqTwTpY8sHom4ZVEhud594uP82uKcAV+9kVwbCqDRQPrgqGkt?= =?us-ascii?Q?0ObYh/Ol4NSy3ChCjrtOIMG1M8iwvZZGzrfQUQDZwdK4smNnqXzs4Btnq3s1?= =?us-ascii?Q?IXYoiaMthdF3RlHsB+ZcV8QcmRXd2CK9olhnzPrXNi2IJCSEL1Q3ohdhTLI9?= =?us-ascii?Q?kaK8FXz44d+mJPX28ldRXENUIrtNlV/FnQ9by2lAWFBRWhUA51zThM9POps6?= =?us-ascii?Q?CZotLEq5XhkgpSEKBE4E/A45enMa1fE/mcs4vzDtj0XfONs2qoNPozUrS6A8?= =?us-ascii?Q?AH2n54yjcA9J9xmyh6hHnR6wu8mwuzFnwe0hL22xdZ1XC4KxShc3GgjYoVry?= =?us-ascii?Q?kq4fOG7MH9Fc52psqsV26NOBx8Grxwezp2bq5NcD2eCYuWWzBu/3rcpYe5Tu?= =?us-ascii?Q?jSD6xM4vDxXDH06r9ZBy/hT5cGh9GfyPjaxvjZlFNobKzHC972WYHSwOotFw?= =?us-ascii?Q?Ewcarf4SwnGqCc1TqtAL0s0erbUTamO1o0wVoKHPo+4Msgy0AvV8dWUToSvU?= =?us-ascii?Q?8g=3D=3D?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: qPPcDbLXdLSK/LTylvFp720qMCkIK6HR1vyInFC+mPafPdGulZIrY5uf5QIdUH8RJLdEmXbjbe/31gk05d/KcjGBdkq2W/WgvDk0SVQ7N4EuVnIYRMifA6X9jZK7suAxGRiNHuLTG1ukQJt0G55ICCJ1cuephBfTWtHxfA+c+fFH35/e5FO+EuYRPRfqMtnfMcdCWbXK+GUOY5X7pdobdY4UZ8Fbn2egjMVs72gcYySIIcJF/x8jyYLsKjqwDn423IMG5Qst1TgGwtkcES7XkDixzqrU6gmidESgCVKrXbqxayXYP5rawW1QFx1YlUs/uoq2PeGlhbAZ++w14Ty5jvjgmVimGmNi63wuYkMD0pigWScIJLmPuun6gOfGI6tuniwmmDYXgcLYeQ2K/2LDIBqPK7LKbqv53NGsR21fpOib2kXxZEi2wGgNyLpIHCb77lUNktHmIemS50TpweFdH0ZIY+8wU0zn5LeYXZEzc9UZ3+uu6G7F4b6W20yJMF9NiBz5clGNZp7qFik4WcOrNhL78J1Sg0/GFEYONJK63Qr7BqsqqUPyHhi42LN1wiJPjUq7Fj2kCk3T1tH+pVBXovK5zoQesYbfYx6hNEXXWMs= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2466e27b-02b8-4582-f3a0-08dde65f6825 X-MS-Exchange-CrossTenant-AuthSource: DM4PR10MB8218.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Aug 2025 18:19:20.0803 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: UHSrZZ7IRsSQ7jCL+mgZDUr6WBeOqrd4d9/mv02Hwc0yLykPhxLuzw3pYfhgohqpG6JSm1wJfBCbz53qKdyJ/NwoPsQn4+jVb2MKnUSogD4= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR10MB6873 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-08-28_04,2025-08-28_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 bulkscore=0 malwarescore=0 adultscore=0 phishscore=0 suspectscore=0 mlxlogscore=999 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2508110000 definitions=main-2508280153 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwODIzMDAxOCBTYWx0ZWRfX5ddWEAXI5elz CHUIX7PX11nTt1Z0ZOyl9KCJmmDptYLKNbLGKX7EyYpzQmGAU5UekIkZPfsyQPZAcjekNOtRPSJ kik60GU+txpCZ08A48NpiJksLvaYwgSH4CPpnA7MZQXFyq/zDlgGwVWX6db9Zh3KaJHT3v0HRcl z2J8X+DDfpPEOFtBFUs8RR2i6Z8hgr73Bt3bKVSj52cjvqsafBcABw7dujcH3J48vDZ23pYyTx1 QrZGNXHHpXixoILZZinOAz4ITDgYcHiM6GeBROuQPBj6ij9tLYFLWNE6iSlGcbLKIvBQEm2SXik +uUrDjDcXkarEZcnnd9xaifxzz20AZJkg8+avICdXPqeoTZjQbKeyDj2d+xhnHIYhigkl334W4w 3KCNAVng X-Proofpoint-GUID: DhOcddl-9psiX1dCHRTL3X9Se839U3wV X-Authority-Analysis: v=2.4 cv=IZWHWXqa c=1 sm=1 tr=0 ts=68b09db1 cx=c_pps a=OOZaFjgC48PWsiFpTAqLcw==:117 a=OOZaFjgC48PWsiFpTAqLcw==:17 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=z/mQ4Ysz8XfWz/Q5cLBRGdckG28=:19 a=lCpzRmAYbLLaTzLvsPZ7Mbvzbb8=:19 a=wKuvFiaSGQ0qltdbU6+NXLB8nM8=:19 a=Ol13hO9ccFRV9qXi2t6ftBPywas=:19 a=xqWC_Br6kY4A:10 a=kj9zAlcOel0A:10 a=2OwXVqhp2XgA:10 a=GoEa3M9JfhUA:10 a=1XWaLZrsAAAA:8 a=20KFwNOVAAAA:8 a=yPCof4ZbAAAA:8 a=2XVGN-VCC70hLb22CjUA:9 a=CjuIK1q_8ugA:10 X-Proofpoint-ORIG-GUID: DhOcddl-9psiX1dCHRTL3X9Se839U3wV On Thu, Aug 28, 2025 at 12:01:38AM +0200, David Hildenbrand wrote: > We want to get rid of nth_page(), and kfence init code is the last user. > > Unfortunately, we might actually walk a PFN range where the pages are > not contiguous, because we might be allocating an area from memblock > that could span memory sections in problematic kernel configs (SPARSEMEM > without SPARSEMEM_VMEMMAP). Sad. > > We could check whether the page range is contiguous > using page_range_contiguous() and failing kfence init, or making kfence > incompatible these problemtic kernel configs. Sounds iffy though. > > Let's keep it simple and simply use pfn_to_page() by iterating PFNs. Yes. > > Cc: Alexander Potapenko > Cc: Marco Elver > Cc: Dmitry Vyukov > Signed-off-by: David Hildenbrand Stared at this and can't see anything wrong, so - LGTM and: Reviewed-by: Lorenzo Stoakes > --- > mm/kfence/core.c | 12 +++++++----- > 1 file changed, 7 insertions(+), 5 deletions(-) > > diff --git a/mm/kfence/core.c b/mm/kfence/core.c > index 0ed3be100963a..727c20c94ac59 100644 > --- a/mm/kfence/core.c > +++ b/mm/kfence/core.c > @@ -594,15 +594,14 @@ static void rcu_guarded_free(struct rcu_head *h) > */ > static unsigned long kfence_init_pool(void) > { > - unsigned long addr; > - struct page *pages; > + unsigned long addr, start_pfn; > int i; > > if (!arch_kfence_init_pool()) > return (unsigned long)__kfence_pool; > > addr = (unsigned long)__kfence_pool; > - pages = virt_to_page(__kfence_pool); > + start_pfn = PHYS_PFN(virt_to_phys(__kfence_pool)); > > /* > * Set up object pages: they must have PGTY_slab set to avoid freeing > @@ -613,11 +612,12 @@ static unsigned long kfence_init_pool(void) > * enters __slab_free() slow-path. > */ > for (i = 0; i < KFENCE_POOL_SIZE / PAGE_SIZE; i++) { > - struct slab *slab = page_slab(nth_page(pages, i)); > + struct slab *slab; > > if (!i || (i % 2)) > continue; > > + slab = page_slab(pfn_to_page(start_pfn + i)); > __folio_set_slab(slab_folio(slab)); > #ifdef CONFIG_MEMCG > slab->obj_exts = (unsigned long)&kfence_metadata_init[i / 2 - 1].obj_exts | > @@ -665,10 +665,12 @@ static unsigned long kfence_init_pool(void) > > reset_slab: > for (i = 0; i < KFENCE_POOL_SIZE / PAGE_SIZE; i++) { > - struct slab *slab = page_slab(nth_page(pages, i)); > + struct slab *slab; > > if (!i || (i % 2)) > continue; > + > + slab = page_slab(pfn_to_page(start_pfn + i)); > #ifdef CONFIG_MEMCG > slab->obj_exts = 0; > #endif > -- > 2.50.1 >