From: Jens Axboe <axboe@kernel.dk>
To: Bart Van Assche <Bart.VanAssche@wdc.com>,
"arnd@arndb.de" <arnd@arndb.de>
Cc: "jejb@linux.vnet.ibm.com" <jejb@linux.vnet.ibm.com>,
"davem@davemloft.net" <davem@davemloft.net>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"hare@suse.com" <hare@suse.com>,
"martin.petersen@oracle.com" <martin.petersen@oracle.com>,
"linux-ide@vger.kernel.org" <linux-ide@vger.kernel.org>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>
Subject: Re: [PATCH] block: fix CDROM dependency on BLK_DEV
Date: Thu, 2 Nov 2017 09:11:04 -0600 [thread overview]
Message-ID: <e11ff1e1-7555-1d8b-2223-bb8d7866a793@kernel.dk> (raw)
In-Reply-To: <1509634878.2484.5.camel@wdc.com>
On 11/02/2017 09:01 AM, Bart Van Assche wrote:
> On Thu, 2017-11-02 at 08:27 -0600, Jens Axboe wrote:
>> On 11/02/2017 05:19 AM, Arnd Bergmann wrote:
>>> After the cdrom cleanup, I get randconfig warnings for some configurations:
>>>
>>> warning: (BLK_DEV_IDECD && BLK_DEV_SR) selects CDROM which has unmet direct dependencies (BLK_DEV)
>>>
>>> This adds an explicit BLK_DEV dependency for both drivers. The other
>>> drivers that select 'CDROM' already have this and don't need a change.
>>
>> Thanks Arnd, applied.
>
> Hello Jens,
>
> Can you wait at least 24 hours after a patch has been posted before applying it
> such those who want to post review comments have a chance to do that?
I generally at least do that, unless they are trivial...
--
Jens Axboe
next prev parent reply other threads:[~2017-11-02 15:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-02 11:19 [PATCH] block: fix CDROM dependency on BLK_DEV Arnd Bergmann
2017-11-02 14:27 ` Jens Axboe
2017-11-02 15:01 ` Bart Van Assche
2017-11-02 15:11 ` Jens Axboe [this message]
2017-11-02 14:59 ` Bart Van Assche
2017-11-02 15:07 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e11ff1e1-7555-1d8b-2223-bb8d7866a793@kernel.dk \
--to=axboe@kernel.dk \
--cc=Bart.VanAssche@wdc.com \
--cc=arnd@arndb.de \
--cc=davem@davemloft.net \
--cc=hare@suse.com \
--cc=jejb@linux.vnet.ibm.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox