Re: [PATCH v2 5/8] ata: inline ata_port_probe()

[Jason Yan <yanaijie@huawei.com>]

On 2023/7/20 8:42, Niklas Cassel wrote:
> From: Hannes Reinecke <hare@suse.de>
> 
> Just used in one place.
> 
> Signed-off-by: Hannes Reinecke <hare@suse.de>
> Signed-off-by: Niklas Cassel <niklas.cassel@wdc.com>
> ---
>   drivers/ata/libata-core.c | 11 ++---------
>   1 file changed, 2 insertions(+), 9 deletions(-)
> 
> diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
> index 1f0306522649..c5e93e1a560d 100644
> --- a/drivers/ata/libata-core.c
> +++ b/drivers/ata/libata-core.c
> @@ -5884,14 +5884,6 @@ void __ata_port_probe(struct ata_port *ap)
>   	spin_unlock_irqrestore(ap->lock, flags);
>   }
>   
> -int ata_port_probe(struct ata_port *ap)
> -{
> -	__ata_port_probe(ap);
> -	ata_port_wait_eh(ap);
> -	return 0;
> -}
> -
> -
>   static void async_port_probe(void *data, async_cookie_t cookie)
>   {
>   	struct ata_port *ap = data;
> @@ -5906,7 +5898,8 @@ static void async_port_probe(void *data, async_cookie_t cookie)
>   	if (!(ap->host->flags & ATA_HOST_PARALLEL_SCAN) && ap->port_no != 0)
>   		async_synchronize_cookie(cookie);
>   
> -	(void)ata_port_probe(ap);
> +	__ata_port_probe(ap);
> +	ata_port_wait_eh(ap);
>   
>   	/* in order to keep device order, we need to synchronize at this point */
>   	async_synchronize_cookie(cookie);
> 

Reviewed-by: Jason Yan <yanaijie@huawei.com>

Thanks,
Jason