From: Sergey Shtylyov <s.shtylyov@omp.ru>
To: Damien Le Moal <damien.lemoal@opensource.wdc.com>,
<linux-ide@vger.kernel.org>
Cc: Dan Carpenter <dan.carpenter@oracle.com>
Subject: Re: [PATCH] ata: libata-sff: fix reading uninitialized variable in ata_sff_lost_interrupt()
Date: Sat, 19 Feb 2022 12:52:01 +0300 [thread overview]
Message-ID: <e429b92e-1848-37fd-0585-3c5b8e7bb92c@omp.ru> (raw)
In-Reply-To: <b6a7f09a-9e15-aac2-b80b-96f12f2df0a1@opensource.wdc.com>
On 2/19/22 5:39 AM, Damien Le Moal wrote:
>> Due to my sloppy coding in commit 2c75a451ecb0 ("ata: libata-sff: refactor
>> ata_sff_altstatus()"), in ata_sff_lost_interrupt() iff the device control
>> register doesn't exists, ata_port_warn() would print the 'status' variable
>> which never gets assigned. Restore the original order of the statements,
>> wrapping the ata_sff_altstatus() call in WARN_ON_ONCE()...
>>
>> While at it, fix crazy indentation in the ata_port_warn() call itself...
>>
>> Fixes: 2c75a451ecb0 ("ata: libata-sff: refactor ata_sff_altstatus()")
>> Reported-by: kernel test robot <lkp@intel.com>
>> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
>> Signed-off-by: Sergey Shtylyov <s.shtylyov@omp.ru>
>
> I squashed this in the commit being fixed.
I'm seeing a few typos/errors in the updated patch #2:
> In ata_sff_lost_interrupt(), wrap the ata_sff_altstatus() call in a
s/a/the/?
> WARN_ON_ONCE()
+ check?
> to issue a warning if the if the device control registert
Register? :-)
> does not exist. And while at it, fix crazy indentation in the
> ata_port_warn() call itself...
Not clear why you (we?) emphasize this by using "itself"...
Well, if you choose to fix those, I'll be thnakful. But you may as well
ignore me. :-)
[...]
MBR, Sergey
next prev parent reply other threads:[~2022-02-19 9:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-18 11:05 [PATCH] ata: libata-sff: fix reading uninitialized variable in ata_sff_lost_interrupt() Sergey Shtylyov
2022-02-18 11:17 ` Sergey Shtylyov
2022-02-18 23:00 ` Damien Le Moal
2022-02-19 2:39 ` Damien Le Moal
2022-02-19 9:52 ` Sergey Shtylyov [this message]
2022-02-19 23:01 ` Damien Le Moal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e429b92e-1848-37fd-0585-3c5b8e7bb92c@omp.ru \
--to=s.shtylyov@omp.ru \
--cc=damien.lemoal@opensource.wdc.com \
--cc=dan.carpenter@oracle.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox