From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Shtylyov Subject: Re: [PATCH] ata: pata_macio: add of_node_put() Date: Wed, 21 Nov 2018 18:24:43 +0300 Message-ID: References: <20181121130439.22255-1-tiny.windzz@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20181121130439.22255-1-tiny.windzz@gmail.com> Content-Language: en-MW Sender: linux-kernel-owner@vger.kernel.org To: Yangtao Li , b.zolnierkie@samsung.com, axboe@kernel.dk Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org List-Id: linux-ide@vger.kernel.org Hello! On 11/21/2018 04:04 PM, Yangtao Li wrote: > of_find_node_by_path() acquires a reference to the node > returned by it and that reference needs to be dropped by its caller. > bl_idle_init() doesn't do that, so fix it. I thought we're inside pata_macio_cable_detect()? > Signed-off-by: Yangtao Li > --- > drivers/ata/pata_macio.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/ata/pata_macio.c b/drivers/ata/pata_macio.c > index 9588e685d994..8cc9c429ad95 100644 > --- a/drivers/ata/pata_macio.c > +++ b/drivers/ata/pata_macio.c > @@ -483,6 +483,8 @@ static int pata_macio_cable_detect(struct ata_port *ap) > struct device_node *root = of_find_node_by_path("/"); > const char *model = of_get_property(root, "model", NULL); > > + of_node_put(root); > + > if (cable && !strncmp(cable, "80-", 3)) { > /* Some drives fail to detect 80c cable in PowerBook > * These machine use proprietary short IDE cable MBR, Sergei