From: Damien Le Moal <dlemoal@kernel.org>
To: Mika Westerberg <mika.westerberg@linux.intel.com>
Cc: linux-ide@vger.kernel.org, Koba Ko <koba.ko@canonical.com>
Subject: Re: [PATCH] ata: ahci: Add Intel Alder Lake-P AHCI controller to low power chipsets list
Date: Mon, 25 Sep 2023 11:09:01 +0200 [thread overview]
Message-ID: <e58ddf0f-3b7e-9599-dd7d-c6ed322d1184@kernel.org> (raw)
In-Reply-To: <20230925080538.2894982-1-mika.westerberg@linux.intel.com>
On 2023/09/25 10:05, Mika Westerberg wrote:
> Intel Alder Lake-P AHCI controller needs to be added to the mobile
> chipsets list in order to have link power management enabled. Without
> this the CPU cannot enter lower power C-states making idle power
> consumption high.
>
> Cc: Koba Ko <koba.ko@canonical.com>
> Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Looks OK, but given that there is a tendency of the low power stuff to be buggy,
was this well tested ? Also, does this need a Fixes/CC stable tag ? If not, I
will queue this for 6.7.
> ---
> drivers/ata/ahci.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/ata/ahci.c b/drivers/ata/ahci.c
> index 08745e7db820..d96f80b6ff5d 100644
> --- a/drivers/ata/ahci.c
> +++ b/drivers/ata/ahci.c
> @@ -423,6 +423,7 @@ static const struct pci_device_id ahci_pci_tbl[] = {
> { PCI_VDEVICE(INTEL, 0x02d7), board_ahci_low_power }, /* Comet Lake PCH RAID */
> /* Elkhart Lake IDs 0x4b60 & 0x4b62 https://sata-io.org/product/8803 not tested yet */
> { PCI_VDEVICE(INTEL, 0x4b63), board_ahci_low_power }, /* Elkhart Lake AHCI */
> + { PCI_VDEVICE(INTEL, 0x7ae2), board_ahci_low_power }, /* Alder Lake-P AHCI */
>
> /* JMicron 360/1/3/5/6, match class to avoid IDE function */
> { PCI_VENDOR_ID_JMICRON, PCI_ANY_ID, PCI_ANY_ID, PCI_ANY_ID,
--
Damien Le Moal
Western Digital Research
next prev parent reply other threads:[~2023-09-25 9:09 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-25 8:05 [PATCH] ata: ahci: Add Intel Alder Lake-P AHCI controller to low power chipsets list Mika Westerberg
2023-09-25 9:09 ` Damien Le Moal [this message]
2023-09-25 9:13 ` Mika Westerberg
2023-09-25 9:27 ` Damien Le Moal
2023-09-26 4:55 ` Koba Ko
2023-10-02 6:21 ` Mika Westerberg
2023-10-03 0:49 ` Damien Le Moal
2023-10-03 4:36 ` Mika Westerberg
2023-10-03 1:00 ` Damien Le Moal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e58ddf0f-3b7e-9599-dd7d-c6ed322d1184@kernel.org \
--to=dlemoal@kernel.org \
--cc=koba.ko@canonical.com \
--cc=linux-ide@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox