Re: [PATCH v2] ata: ahci_da850: switch to DEFINE_SIMPLE_DEV_PM_OPS

[Damien Le Moal <dlemoal@kernel.org>]

On 9/8/26 11:59, Li Jun wrote:
> Replace the deprecated SIMPLE_DEV_PM_OPS macro with the recommended
> DEFINE_SIMPLE_DEV_PM_OPS.use pm_ptr(&ahci_da850_pm_ops) to complete

Please add a space after the period and capitalize the first letter of the
sentence:

s/.use/. Use/

> the API migration and allow the structure to be correctly dropped
> when CONFIG_PM=n.
> 
> Signed-off-by: Li Jun <lijun01@kylinos.cn>
> ---
> changelogs:
> -add pm_ptr for ahci_da850_pm_ops in ahci_da850_driver.
> ---
>  drivers/ata/ahci_da850.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/ata/ahci_da850.c b/drivers/ata/ahci_da850.c
> index 4e53ff96d712..0b390395679e 100644
> --- a/drivers/ata/ahci_da850.c
> +++ b/drivers/ata/ahci_da850.c
> @@ -218,7 +218,7 @@ static int ahci_da850_probe(struct platform_device *pdev)
>  	return rc;
>  }
>  
> -static SIMPLE_DEV_PM_OPS(ahci_da850_pm_ops, ahci_platform_suspend,
> +static DEFINE_SIMPLE_DEV_PM_OPS(ahci_da850_pm_ops, ahci_platform_suspend,
>  			 ahci_platform_resume);

Please align this to ahci_da850_pm_ops.

With both nits fixed, feel free to add:

Reviewed-by: Damien Le Moal <dlemoal@kernel.org>

>  
>  static const struct of_device_id ahci_da850_of_match[] = {
> @@ -233,7 +233,7 @@ static struct platform_driver ahci_da850_driver = {
>  	.driver = {
>  		.name = DRV_NAME,
>  		.of_match_table = ahci_da850_of_match,
> -		.pm = &ahci_da850_pm_ops,
> +		.pm = pm_ptr(&ahci_da850_pm_ops),
>  	},
>  };
>  module_platform_driver(ahci_da850_driver);


-- 
Damien Le Moal
Western Digital Research