From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 568E0EB64DD for ; Thu, 6 Jul 2023 23:35:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231710AbjGFXfz (ORCPT ); Thu, 6 Jul 2023 19:35:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42746 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231407AbjGFXfz (ORCPT ); Thu, 6 Jul 2023 19:35:55 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6FB2F1BC3; Thu, 6 Jul 2023 16:35:54 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id EB41761208; Thu, 6 Jul 2023 23:35:53 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A5825C433C7; Thu, 6 Jul 2023 23:35:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1688686553; bh=DP7fJGvKQ0uhwcbMQ4HpQrGiWbGBPP9soTviBQgpsZQ=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=Q7IiS06KZPS2/0Au4NLJYv85CJJlKitaXhs2QzDXKtYT0bqaAlGzcfewrLv2vBIqJ jBjiNxB2iFpxrHwBHOdJ5GFe5zdTj5Sw303fT8DTwzS1MNPYjUwsGoAjg5RXATGwUM gY+xpiOK2qtEAxslDK9GPsOgm/cJfyGzjuu1GUhA61MPwRGTXgI0Pu0XjZnK8LZ9Jy Y+dtZuLX1jfaUVBoJ6jlJSw1GrzMyOIOWSTa3Ot3iYxlYFwQP7HxZ9XN5JjcrtiLfz e19fxmy0Shr/YaYyeIYNKPAlswcH9skyf/4So4HKy5tD45O8ZNqGUcLFjB7SsG8qiv zpRZSTaVTDt2Q== Message-ID: Date: Fri, 7 Jul 2023 08:35:51 +0900 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH 4/8] ahci: tegra: Convert to devm_platform_ioremap_resource() To: Yangtao Li , Thierry Reding , Jonathan Hunter Cc: linux-ide@vger.kernel.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org References: <20230706124239.23366-1-frank.li@vivo.com> <20230706124239.23366-4-frank.li@vivo.com> Content-Language: en-US From: Damien Le Moal Organization: Western Digital Research In-Reply-To: <20230706124239.23366-4-frank.li@vivo.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-ide@vger.kernel.org On 7/6/23 21:42, Yangtao Li wrote: > Use devm_platform_ioremap_resource() to simplify code. Please be consistent with the patch titles. This should be: ata: ahci_tegra: Convert to devm_platform_ioremap_resource() > > Signed-off-by: Yangtao Li > --- > drivers/ata/ahci_tegra.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/ata/ahci_tegra.c b/drivers/ata/ahci_tegra.c > index 21c20793e517..d1a35da7e824 100644 > --- a/drivers/ata/ahci_tegra.c > +++ b/drivers/ata/ahci_tegra.c > @@ -530,8 +530,7 @@ static int tegra_ahci_probe(struct platform_device *pdev) > tegra->pdev = pdev; > tegra->soc = of_device_get_match_data(&pdev->dev); > > - res = platform_get_resource(pdev, IORESOURCE_MEM, 1); > - tegra->sata_regs = devm_ioremap_resource(&pdev->dev, res); > + tegra->sata_regs = devm_platform_ioremap_resource(pdev, 1); > if (IS_ERR(tegra->sata_regs)) > return PTR_ERR(tegra->sata_regs); > -- Damien Le Moal Western Digital Research