Re: [PATCH V4] ata: libata-core: Print timeout value when internal command times

[Damien Le Moal <damien.lemoal@opensource.wdc.com>]

On 2022/08/10 10:59, Tomas Henzl wrote:
> Printing the timeout value may help in troubleshooting failures.
> 
> Signed-off-by: David Milburn <dmilburn@redhat.com>
> Signed-off-by: Tomas Henzl <thenzl@redhat.com>
> ---
> V4: a whitespace change
>     a switch from an an infinitive to an -ing form in the body
>     a fix to the title prefix
> V3: rewording subject and description, no functional change
> V2: timeout changed to unsigned int as in for-next
> ---
>  drivers/ata/libata-core.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
> index 826d41f341e4..9478194740e0 100644
> --- a/drivers/ata/libata-core.c
> +++ b/drivers/ata/libata-core.c
> @@ -1578,8 +1578,8 @@ static unsigned ata_exec_internal_sg(struct ata_device *dev,
>  			else
>  				ata_qc_complete(qc);
>  
> -			ata_dev_warn(dev, "qc timeout (cmd 0x%x)\n",
> -				     command);
> +			ata_dev_warn(dev, "qc timeout after %u msecs (cmd 0x%x)\n",
> +				     timeout, command);
>  		}
>  
>  		spin_unlock_irqrestore(ap->lock, flags);

Applied to for-6.1. Thanks !

-- 
Damien Le Moal
Western Digital Research