public inbox for linux-ide@vger.kernel.org
 help / color / mirror / Atom feed
From: Hans de Goede <hdegoede@redhat.com>
To: Charles Rose <charles.rose@dell.com>,
	linux-ide@vger.kernel.org, axboe@kernel.dk
Cc: Mika Westerberg <mika.westerberg@intel.com>
Subject: Re: [PATCH] ahci: Add support for Dell S140 and later controllers
Date: Thu, 17 Jun 2021 12:31:26 +0200	[thread overview]
Message-ID: <e7067ad7-07ad-e747-ed18-8587c6b6a2c2@redhat.com> (raw)
In-Reply-To: <20210615190801.1744466-1-charles.rose@dell.com>

Hi,

On 6/15/21 9:08 PM, Charles Rose wrote:
> This patch enables support for Dell S140 and later controllers
> that use Intel's PCHs configured as PCI_CLASS_STORAGE_RAID.
> 
> Reviewed-by: Mika Westerberg <mika.westerberg@intel.com>
> Signed-off-by: Charles Rose <charles.rose@dell.com>

Thanks, patch looks good to me:

Reviewed-by: Hans de Goede <hdegoede@redhat.com>

Regards,

Hans


> ---
>  drivers/ata/ahci.c      | 4 ++++
>  include/linux/pci_ids.h | 2 ++
>  2 files changed, 6 insertions(+)
> 
> diff --git a/drivers/ata/ahci.c b/drivers/ata/ahci.c
> index 33192a8f687d..186cbf90c8ea 100644
> --- a/drivers/ata/ahci.c
> +++ b/drivers/ata/ahci.c
> @@ -446,6 +446,10 @@ static const struct pci_device_id ahci_pci_tbl[] = {
>  	{ PCI_VENDOR_ID_AMD, PCI_ANY_ID, PCI_ANY_ID, PCI_ANY_ID,
>  	  PCI_CLASS_STORAGE_RAID << 8, 0xffffff, board_ahci },
>  
> +	/* Dell S140/S150 */
> +	{ PCI_VENDOR_ID_INTEL, PCI_ANY_ID, PCI_SUBVENDOR_ID_DELL, PCI_ANY_ID,
> +	  PCI_CLASS_STORAGE_RAID << 8, 0xffffff, board_ahci },
> +
>  	/* VIA */
>  	{ PCI_VDEVICE(VIA, 0x3349), board_ahci_vt8251 }, /* VIA VT8251 */
>  	{ PCI_VDEVICE(VIA, 0x6287), board_ahci_vt8251 }, /* VIA VT8251 */
> diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h
> index 4c3fa5293d76..803ec446a729 100644
> --- a/include/linux/pci_ids.h
> +++ b/include/linux/pci_ids.h
> @@ -631,6 +631,8 @@
>  #define PCI_DEVICE_ID_DELL_RAC4		0x0012
>  #define PCI_DEVICE_ID_DELL_PERC5	0x0015
>  
> +#define PCI_SUBVENDOR_ID_DELL		0x1028
> +
>  #define PCI_VENDOR_ID_MATROX		0x102B
>  #define PCI_DEVICE_ID_MATROX_MGA_2	0x0518
>  #define PCI_DEVICE_ID_MATROX_MIL	0x0519
> 


      parent reply	other threads:[~2021-06-17 10:31 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-15 19:08 [PATCH] ahci: Add support for Dell S140 and later controllers Charles Rose
2021-06-15 21:44 ` Jens Axboe
2021-06-17 10:31 ` Hans de Goede [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e7067ad7-07ad-e747-ed18-8587c6b6a2c2@redhat.com \
    --to=hdegoede@redhat.com \
    --cc=axboe@kernel.dk \
    --cc=charles.rose@dell.com \
    --cc=linux-ide@vger.kernel.org \
    --cc=mika.westerberg@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox