Re: [PATCH v2 0/6] misc LPM related fixes

[wolf@yoxt.cc]

On 2026-01-12 13:20, Niklas Cassel wrote:
> Hello there,
> 
> we had a recent bug report on the mailing list related to LPM, which 
> made
> me review the LPM related code.
> 
> While doing so, I found some issues. This series fixes those issues.
> 
> The most serious issue is that ATA_QUIRK_NOLPM was not getting applied 
> for
> ATAPI devices and that we read the per port area for unimplemented 
> ports,
> even though the AHCI specification explicitly forbids this.
> 
> 
> Kind regards,
> Niklas
> 
> 
> Changes since v1:
> -Fixed typos in commit messages
> -Split early return patch into two, so that they only have a single
>  Fixes-tag each.
> -Reordered patches to make it easier to only apply the important ones
>  for the current v6.19 kernel.
> 
> 
> Niklas Cassel (6):
>   ata: ahci: Do not read the per port area for unimplemented ports
>   ata: libata: Call ata_dev_config_lpm() for ATAPI devices
>   ata: libata-sata: Improve link_power_management_supported sysfs
>     attribute
>   ata: libata: Add cpr_log to ata_dev_print_features() early return
>   ata: libata: Add DIPM and HIPM to ata_dev_print_features() early
>     return
>   ata: libata: Print features also for ATAPI devices
> 
>  drivers/ata/ahci.c        | 10 +++++-----
>  drivers/ata/libata-core.c |  8 +++++++-
>  drivers/ata/libata-sata.c |  2 +-
>  3 files changed, 13 insertions(+), 7 deletions(-)
> 
> 
> base-commit: 97e01439e902b743b8f89497e9c144e3ddda5e59

Tested-by: Wolf <wolf@yoxt.cc>