From: Jason Yan <yanaijie@huawei.com>
To: Niklas Cassel <nks@flawful.org>,
Damien Le Moal <dlemoal@kernel.org>,
John Garry <john.g.garry@oracle.com>,
"James E.J. Bottomley" <jejb@linux.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>
Cc: Hannes Reinecke <hare@suse.com>, <linux-ide@vger.kernel.org>,
<linux-scsi@vger.kernel.org>, Hannes Reinecke <hare@suse.de>,
Niklas Cassel <niklas.cassel@wdc.com>
Subject: Re: [PATCH v3 2/9] ata,scsi: remove ata_sas_port_{start,stop} callbacks
Date: Fri, 28 Jul 2023 10:05:47 +0800 [thread overview]
Message-ID: <ed32011d-4bba-2679-5efd-b8bc164d4ecf@huawei.com> (raw)
In-Reply-To: <20230721163229.399676-3-nks@flawful.org>
On 2023/7/22 0:32, Niklas Cassel wrote:
> Also, remove the call to ap->ops->port_start() in ata_sas_port_init(),
> as this would otherwise cause a NULL pointer dereference, now when the
> callback is gone.
>
> Signed-off-by: Hannes Reinecke<hare@suse.de>
> [niklas: remove the call to ap->ops->port_start() in ata_sas_port_init()]
> Signed-off-by: Niklas Cassel<niklas.cassel@wdc.com>
> ---
> drivers/ata/libata-sata.c | 38 -----------------------------------
> drivers/scsi/libsas/sas_ata.c | 2 --
> include/linux/libata.h | 2 --
> 3 files changed, 42 deletions(-)
Reviewed-by: Jason Yan <yanaijie@huawei.com>
next prev parent reply other threads:[~2023-07-28 2:05 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-21 16:32 [PATCH v3 0/9] libata: remove references to 'old' error handler Niklas Cassel
2023-07-21 16:32 ` [PATCH v3 1/9] ata: remove reference to non-existing error_handler() Niklas Cassel
2023-07-25 11:09 ` John Garry
2023-07-28 2:05 ` Jason Yan
2023-07-21 16:32 ` [PATCH v3 2/9] ata,scsi: remove ata_sas_port_{start,stop} callbacks Niklas Cassel
2023-07-28 2:05 ` Jason Yan [this message]
2023-07-21 16:32 ` [PATCH v3 3/9] ata,scsi: remove ata_sas_port_destroy() Niklas Cassel
2023-07-25 11:11 ` John Garry
2023-07-28 2:06 ` Jason Yan
2023-07-21 16:32 ` [PATCH v3 4/9] ata: remove ata_sas_sync_probe() Niklas Cassel
2023-07-25 11:12 ` John Garry
2023-07-21 16:32 ` [PATCH v3 5/9] ata: inline ata_port_probe() Niklas Cassel
2023-07-25 11:13 ` John Garry
2023-07-21 16:32 ` [PATCH v3 6/9] ata,scsi: cleanup __ata_port_probe() Niklas Cassel
2023-07-25 11:16 ` John Garry
2023-07-21 16:32 ` [PATCH v3 7/9] ata: sata_sx4: drop already completed TODO Niklas Cassel
2023-07-25 11:16 ` John Garry
2023-07-21 16:32 ` [PATCH v3 8/9] ata: remove ata_bus_probe() Niklas Cassel
2023-07-25 11:19 ` John Garry
2023-07-28 2:06 ` Jason Yan
2023-07-21 16:32 ` [PATCH v3 9/9] ata: remove deprecated EH callbacks Niklas Cassel
2023-07-25 11:20 ` John Garry
2023-07-25 12:01 ` John Garry
2023-07-26 19:29 ` Sergey Shtylyov
2023-07-28 2:07 ` Jason Yan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ed32011d-4bba-2679-5efd-b8bc164d4ecf@huawei.com \
--to=yanaijie@huawei.com \
--cc=dlemoal@kernel.org \
--cc=hare@suse.com \
--cc=hare@suse.de \
--cc=jejb@linux.ibm.com \
--cc=john.g.garry@oracle.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=niklas.cassel@wdc.com \
--cc=nks@flawful.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox