Linux ATA/IDE development
 help / color / mirror / Atom feed
From: Damien Le Moal <dlemoal@kernel.org>
To: Niklas Cassel <cassel@kernel.org>
Cc: linux-ide@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH] ata: libata-scsi: fix the INC_512 bit test for SECURITY PROTOCOL IN/OUT
Date: Mon, 16 Nov 2026 12:42:38 -0800	[thread overview]
Message-ID: <ed90f523-62c6-4066-b67d-76d5de4c7544@kernel.org> (raw)
In-Reply-To: <20261116191008.2954277-2-cassel@kernel.org>

On 11/16/26 11:10, Niklas Cassel wrote:
> ata_scsi_security_inout_xlat() tests the INC_512 bit with cdb[4] & 7.
> INC_512 is bit 7 of byte 4 of the SECURITY PROTOCOL IN and SECURITY
> PROTOCOL OUT CDBs (SPC-6, tables 280 and 282), and bits 6:0 of that
> byte are reserved.
> 
> Test bit 7 instead.
> 
> Fixes: 818831c8b22f ("libata: implement SECURITY PROTOCOL IN/OUT")
> Cc: stable@vger.kernel.org
> Signed-off-by: Niklas Cassel <cassel@kernel.org>

Reviewed-by: Damien Le Moal <dlemoal@kernel.org>


-- 
Damien Le Moal
Western Digital Research

      reply	other threads:[~2026-11-16 20:42 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-16 19:10 [PATCH] ata: libata-scsi: fix the INC_512 bit test for SECURITY PROTOCOL IN/OUT Niklas Cassel
2026-11-16 20:42 ` Damien Le Moal [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ed90f523-62c6-4066-b67d-76d5de4c7544@kernel.org \
    --to=dlemoal@kernel.org \
    --cc=cassel@kernel.org \
    --cc=linux-ide@vger.kernel.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox