From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 64EAF38F9C for ; Mon, 28 Jul 2025 05:33:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753680829; cv=none; b=cIq1tYCOIFSN4+YXgZhsw9IBEDbnuAOjV3xYu2DoP3GzVIbh/oX2xKV1z91H9zdHFohJ/JzW442NrrueSXaWO6GqwuhbuMaceM+vSKWv17c8dVBO8dluoGO4leJ7Ig+nZ+6A1l5XmV0Y6cMAqQdGAXkYSUl2Px4C9V9gKm3zv+c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753680829; c=relaxed/simple; bh=u6ERUNOOEzSBij/Uojzy5/MsKeWwSjrvHTW6EgVbPQI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=T7cckhb1Uzf9cnAhUqTWNXoRPtLGGvtnVSAjXyxf21ty35CHrle78AywqVhm7jxawDk/Wfg37NgDJKo+86Pt8MYfjxbEyOFDmwxNYH5qPZgiSshSUCk4IXsAqpD9/QSTLx7kryX+QEgLHQsF7x3euk4+zg0QzX/jxCvf+E+4WXA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=eZBRFXqG; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="eZBRFXqG" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 79101C4CEE7; Mon, 28 Jul 2025 05:33:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1753680828; bh=u6ERUNOOEzSBij/Uojzy5/MsKeWwSjrvHTW6EgVbPQI=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=eZBRFXqGmSa0uoG2YegRuFgCnx/Q4jEVLwmjYc5FsrSXgnbIe+K4CG2ICeotCssIY hjRYPGlWciyD8PnomqYkdaqEnnNmMpNPAf0aHyH7XDqgjt1JVK6Ls1U4sSOvaJhcU0 ZMpPaL9aGAWUIzvlO1OoSljFHEABVf/cBg3EqXTdL9vqV0nCEQS4OqaV461GU4BMtF mgFJQ7rAjeA1kmJNr7o0TFCHiW9so5wHsI9TO9O+AfhDLRBKt66UK0GPy0xoaJ0iGk AkKM3uP7vz9tr/en1mzAz5pnEWAQIF2+hpXB1A3bEouEv7uuYnkYtkz+Y1TEzhJr5x m+1Csc9hDAlKw== Message-ID: Date: Mon, 28 Jul 2025 14:31:17 +0900 Precedence: bulk X-Mailing-List: linux-ide@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: Regression on linux-next (next-20250708) To: "Borah, Chaitanya Kumar" Cc: "intel-gfx@lists.freedesktop.org" , "intel-xe@lists.freedesktop.org" , linux-ide@vger.kernel.org, mika.westerberg@intel.com, anshuman.gupta@intel.com, "Kurmi, Suresh Kumar" , "Saarinen, Jani" , lucas.demarchi@intel.com References: <07563042-6576-41cd-9a95-de83cfc95de1@intel.com> From: Damien Le Moal Content-Language: en-US Organization: Western Digital Research In-Reply-To: <07563042-6576-41cd-9a95-de83cfc95de1@intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 7/25/25 3:43 PM, Borah, Chaitanya Kumar wrote: > For some context in our kms_pm_rpm tests, we enable min_power policy for SATA > so that we can reach deep runtime power states and restore the original policy > after finishing. [5][6] > > IIUC, the above change is based on spec and not something which can be > reverted. So as I see it, we have to drop this code path for external ports. > However I am not sure if we can achieve deep power states without enforcing it > through the sysfs entry. > > Atleast for the basic-rte subtest, the test passes if we comment out the > functions controlling the SATA ports. We will need more testing to determine if > this approach work. Any thoughts on it? > > Also, are there other ways to detect a port is external other than receiving > EOPNOTSUPP on the sysfs write? I completely forgot to mention one important thing: please check your test machine BIOS settings and see if you have "hotplug support" set to enable for SATA ports. If it is, set that BIOS setting to disable and you will see the SATA port as a regular one, not as an external port. So LPM support will be back and your test program will not need changes. Not all BIOSes have such setting though. Most of the machine I have do have it though and I checked that it does affect how the ahci driver sees the port (external or regular with LPM). -- Damien Le Moal Western Digital Research