linux-ide.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* Re: [PATCH v4] ata: libata: disable LPM for WDC WD20EFAX-68FB5N0 hard drives
@ 2025-04-30 20:36 Ioannis Barkas
  2025-05-01 18:47 ` Damien Le Moal
  0 siblings, 1 reply; 36+ messages in thread
From: Ioannis Barkas @ 2025-04-30 20:36 UTC (permalink / raw)
  To: linux-ide

Hello guys,

It would be better to have more details on this since only the 2TB
model is targeted.

Please provide hdparm, health details from the affected disk, full
dmesg on the latest kernel you get errors so that we can confirm
active lpm-pol and see platform in use as well as board & chipset.
Have you tested this disk at another LPM capable system or HBA?

If the disk is in mint condition then it should be blacklisted if it
fails on LPM transitions.

Best regards,
Ioannis

^ permalink raw reply	[flat|nested] 36+ messages in thread
* Re: [PATCH v4] ata: libata: disable LPM for WDC WD20EFAX-68FB5N0 hard drives
@ 2025-05-05 19:38 Ioannis Barkas
  2025-05-05 23:33 ` Damien Le Moal
  2025-05-06 11:29 ` Mikko Juhani Korhonen
  0 siblings, 2 replies; 36+ messages in thread
From: Ioannis Barkas @ 2025-05-05 19:38 UTC (permalink / raw)
  To: linux-ide

Hello Mikko, thanks for sharing all those details, we have some
additional information on this.

I am suspicious with hw and not with you. A quirk will affect lots of
devices and we need to be sure that we have examined the error you get
so that there is no need to revert things. FYI, I have a disk with a
quirk for no obvious reason on all hosts because nForce had NCQ
trouble with it. If a quirk gets applied usually it stays for a long
time if not forever.

Back to your case, on first look I can see that disks are in mint
condition and are running the default fw, 82.00A82. Damien is there a
newer version available?
Please run a short test to each one to ensure that everything is OK
after working for 10K+ hours and share their health log again. It is
clear that both go south at the same time so RAID array dies as
expected following that initial event. You just leave the PC on and
then you get that event on both?

Supposing you get no error at disks after all that but still disks go
offline, I would suggest to update your board fw to version 3621 and
retest. The controller-disk combo should work fine. Just to clarify
things, upon turning off LPM, you get no error at all?

Except the short form of lspci, let's get the fulll dump for SATA
controller to see its active PCI settings with:
sudo lspci -nnnnvvvvxxxxks 01:00.1

You can get it before touching anything and then with 3621 fw if you
update your board. This will pinpoint if anything has been modified
between different fw releases.

If the problem remains no matter what, a quirk is inevitable. Do we
wish to block LPM on Intel hosts while no one has reported errors? How
about a new quirk called ATA_QUIRK_NO_LPM_ON_AMD500 for 500 series ICs
or ATA_QUIRK_NO_LPM_ON_AMD similar to ATA_QUIRK_NO_LPM_ON_ATI blocking
LPM for ATI chips?

Best regards,
Ioannis

^ permalink raw reply	[flat|nested] 36+ messages in thread
* [PATCH v4] ata: libata: disable LPM for WDC WD20EFAX-68FB5N0 hard drives
@ 2025-04-29 16:44 Mikko Korhonen
  2025-04-30  6:35 ` Niklas Cassel
  0 siblings, 1 reply; 36+ messages in thread
From: Mikko Korhonen @ 2025-04-29 16:44 UTC (permalink / raw)
  To: linux-ide, linux-kernel, Damien Le Moal, Niklas Cassel; +Cc: Mikko Korhonen

Make WDC WD20EFAX-68FB5N0 hard drives work again after regression in
6.9.0 when LPM was enabled, so disable it for this model.

Fixes: 7627a0edef54 ("ata: ahci: Drop low power policy board type")
Signed-off-by: Mikko Korhonen <mjkorhon@gmail.com>
---
 drivers/ata/libata-core.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
index 773799cfd443..5c2f26945d61 100644
--- a/drivers/ata/libata-core.c
+++ b/drivers/ata/libata-core.c
@@ -4239,6 +4239,11 @@ static const struct ata_dev_quirks_entry __ata_dev_quirks[] = {
 	{ "WDC WD3000JD-*",		NULL,	ATA_QUIRK_WD_BROKEN_LPM },
 	{ "WDC WD3200JD-*",		NULL,	ATA_QUIRK_WD_BROKEN_LPM },
 
+	/*
+	 * This specific WD SATA-3 model has problems with LPM.
+	 */
+	{ "WDC WD20EFAX-68FB5N0",	NULL,	ATA_QUIRK_NOLPM },
+
 	/*
 	 * This sata dom device goes on a walkabout when the ATA_LOG_DIRECTORY
 	 * log page is accessed. Ensure we never ask for this log page with
-- 
2.47.2


^ permalink raw reply related	[flat|nested] 36+ messages in thread
end of thread, other threads:[~2025-06-11 13:33 UTC | newest]

Thread overview: 36+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-04-30 20:36 [PATCH v4] ata: libata: disable LPM for WDC WD20EFAX-68FB5N0 hard drives Ioannis Barkas
2025-05-01 18:47 ` Damien Le Moal
2025-05-02  1:32   ` Damien Le Moal
2025-05-05  7:58     ` Mikko Juhani Korhonen
2025-05-05 15:37       ` Niklas Cassel
2025-05-05 17:09         ` Mikko Juhani Korhonen
2025-05-07  8:55           ` Damien Le Moal
2025-05-10 10:14             ` Mikko Juhani Korhonen
2025-05-10 11:59               ` Niklas Cassel
2025-05-10 18:29                 ` Ioannis Barkas
2025-05-11 17:08                 ` Mikko Juhani Korhonen
2025-05-11 18:53                   ` Niklas Cassel
2025-05-11 18:59                     ` Mikko Juhani Korhonen
2025-05-11 19:18                       ` Niklas Cassel
2025-05-11 20:40                         ` Mikko Juhani Korhonen
2025-05-12  5:37                         ` Mikko Juhani Korhonen
2025-05-12  9:25                           ` Niklas Cassel
2025-05-12 10:34                             ` Mikko Juhani Korhonen
2025-05-12 11:20                               ` Niklas Cassel
     [not found]                                 ` <CAAZ0mTeiVqZQvkWzJ8aFH4FUPCZwy5O+9hPBgDPhSgNNz+t6HA@mail.gmail.com>
2025-05-14 17:57                                   ` Niklas Cassel
2025-05-17 16:31                                     ` Mikko Juhani Korhonen
     [not found]                                     ` <CAAZ0mTdZEd6n+tDvqbqzMQS2W+3efpYOeHupYcj3rDSVeuHFBA@mail.gmail.com>
2025-05-23 14:05                                       ` Niklas Cassel
2025-06-02 11:17                                     ` Mikko Juhani Korhonen
2025-06-05 12:18                                       ` Niklas Cassel
2025-06-09 13:49                                         ` Niklas Cassel
2025-06-11 13:14                                           ` Mikko Juhani Korhonen
2025-06-11 13:33                                             ` Niklas Cassel
2025-05-07  8:59           ` Niklas Cassel
2025-05-08 19:24             ` Mario Limonciello
2025-05-07  8:59           ` Damien Le Moal
2025-05-11 18:55             ` Mikko Juhani Korhonen
  -- strict thread matches above, loose matches on Subject: below --
2025-05-05 19:38 Ioannis Barkas
2025-05-05 23:33 ` Damien Le Moal
2025-05-06 11:29 ` Mikko Juhani Korhonen
2025-04-29 16:44 Mikko Korhonen
2025-04-30  6:35 ` Niklas Cassel

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).