From: "Colin King (gmail)" <colin.i.king@gmail.com>
To: Damien Le Moal <damien.lemoal@opensource.wdc.com>,
Sergey Shtylyov <s.shtylyov@omp.ru>,
linux-ide@vger.kernel.org
Cc: kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] ata: pata_pdc202xx_old: make make static read-only array pio_timing const
Date: Mon, 24 Jan 2022 23:02:38 +0000 [thread overview]
Message-ID: <f6dac007-f7d4-0152-7e42-a6b0d0c1bbb3@gmail.com> (raw)
In-Reply-To: <9a4c9ba0-00a3-eb1d-8cdd-f44d94f7c92a@opensource.wdc.com>
On 24/01/2022 21:37, Damien Le Moal wrote:
> On 2022/01/25 2:15, Sergey Shtylyov wrote:
>> Hello!
>>
>> Too many verbs in the subject. :-)
>
> Yep. I will fix that when applying. No need to resend !
Thanks for fixing this up. Much appreciated.
>
>>
>> On 1/24/22 1:22 AM, Colin Ian King wrote:
>>
>>> The static array pio_timing is read-only so it make sense to make
>>> it const.
>>>
>>> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
>>
>> With that fixed:
>>
>> Reviewed-by: Sergey Shtylyov <s.shtylyov@omp.ru>
>
> Thanks for the review.
>
>>
>> [...]
>>
>> MBR, Sergey
>
>
next prev parent reply other threads:[~2022-01-25 7:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-23 22:22 [PATCH] ata: pata_pdc202xx_old: make make static read-only array pio_timing const Colin Ian King
2022-01-24 17:15 ` Sergey Shtylyov
2022-01-24 21:37 ` Damien Le Moal
2022-01-24 23:02 ` Colin King (gmail) [this message]
2022-01-27 23:36 ` Damien Le Moal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f6dac007-f7d4-0152-7e42-a6b0d0c1bbb3@gmail.com \
--to=colin.i.king@gmail.com \
--cc=damien.lemoal@opensource.wdc.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=s.shtylyov@omp.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox