From mboxrd@z Thu Jan 1 00:00:00 1970 From: s ponnusa Subject: Re: Linux kernel - Libata bad block error handling to user mode program Date: Sat, 13 Mar 2010 19:12:19 -0500 Message-ID: References: <20100303224245.ae8d1f7a.akpm@linux-foundation.org> <87f94c371003040617t4a4fcd0dt1c9fc0f50e6002c4@mail.gmail.com> <4B8FC6AC.4060801@teksavvy.com> <87f94c371003111029s7c7daebgf691ab11e6bdda25@mail.gmail.com> <4B9C2376.9040309@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from mail-vw0-f46.google.com ([209.85.212.46]:51500 "EHLO mail-vw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759431Ab0CNAMU convert rfc822-to-8bit (ORCPT ); Sat, 13 Mar 2010 19:12:20 -0500 In-Reply-To: <4B9C2376.9040309@gmail.com> Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: Robert Hancock Cc: Greg Freemyer , Mark Lord , Andrew Morton , linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org, Jens Axboe , linux-mm@kvack.org Is it the case even during the blocking operation where the write op waits for the call return? Even, fsync does not catch the errors. (or alteast in the 2.6.27). I agree with you on the process flow. Will post more testing results and details within a couple of days. - SP On Sat, Mar 13, 2010 at 6:44 PM, Robert Hancock = wrote: > On 03/13/2010 04:44 PM, s ponnusa wrote: >> >> Had some issues with the libata in 2.6.27 kernel's libata code, but >> believe the issues were fixed in the subsequent versions. Atleast on= e >> prominent issue was with a Western Digital HDD of 40 GB size. The >> manufacturer specific LBA was 78125000 and was reported as correctly >> in Win32 and DOS applications. But the 2.6.27 kernel was reporting >> ~40000 sectors more. But the problem dissappeared with the 2.6.3x >> kernel and I did not bother to check the patches due to lack of time= =2E >> But still, the write's failure is not being seen by the application.= I >> can understand the fact of not checking the media errors during the >> write operation, and had posted a request for a quick suggestions of >> the locations which needs to be changed / checked for the return >> value. ( Should it be handled at the vfs or at the libata code?). Wi= ll >> surely update the testing results with the new kernel (Well, not >> exactly as I am not using the latest version though! Currently tryin= g >> with 2.6.31). Thank you all for suggestions. > > It's quite likely for write errors not to be noticed by the applicati= on. > Even if the drive does report a write error, the application that wro= te the > data could have completed the write and even closed the file or exite= d > before the data actually gets written to disk. Only if fsync (or rela= ted > functions) are called on the file is it guaranteed that the data has = been > written out to the drive (and any generated errors should be seen at = that > time). > >> - >> SP >> >> On Thu, Mar 11, 2010 at 1:29 PM, Greg Freemyer >> =A0wrote: >>>> >>>> But really.. isn't "hdparm --security-erase NULL /dev/sdX" good en= ough >>>> ??? >>>> >>> >>> This thread seems to have died off. =A0If there is a real problem, = I >>> hope it picks back up. >>> >>> Mark, as to your question the few times I've tried that the bios on >>> the test machine blocked the command. =A0So it may have some specif= ic >>> utility, but it's a not a generic solution in my mind. >>> >>> Greg >>> >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-ide"= in >> the body of a message to majordomo@vger.kernel.org >> More majordomo info at =A0http://vger.kernel.org/majordomo-info.html >> > >