From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A6728C4332F for ; Thu, 6 Oct 2022 06:30:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230029AbiJFGa4 (ORCPT ); Thu, 6 Oct 2022 02:30:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54960 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229796AbiJFGaz (ORCPT ); Thu, 6 Oct 2022 02:30:55 -0400 Received: from esa4.hgst.iphmx.com (esa4.hgst.iphmx.com [216.71.154.42]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 78B6B3F301 for ; Wed, 5 Oct 2022 23:30:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1665037854; x=1696573854; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=x7kTAo4qP3/SnUW9k2mZ8CbPne03lLNrJUiyWWlRBzs=; b=P7KCU76mpPHCvY5a43VwcfRtunhQw+pCtQg+QBECD57HsAIrunok7Gx2 sYq0wahPjXyk+LQ48sJytAjVWGDoSVLKl+8C2iROQ6frRcBHwq2X4ZdSn lJfARg+ubOE+3V81khBX3w2+wOqh7O/CEd5t8AWcuyKDXGuwI0eJbDovY BZIW0kBbLWaqfZQeRX3mibcY2TDBwSOvSPzGwYB2Nedz3VLhWfKB0BksR PyDuBdCuSBGZkFCOP9t5px9V49UztrbpTFeT2zqje04QPohgXIFJNNIjE 3SE/8FLEXdeL/ArN3gfeLzVR1K9A1lTHwe/E2c9yQiYL4ZbzfILi+tM96 w==; X-IronPort-AV: E=Sophos;i="5.95,163,1661788800"; d="scan'208";a="211457007" Received: from uls-op-cesaip02.wdc.com (HELO uls-op-cesaep02.wdc.com) ([199.255.45.15]) by ob1.hgst.iphmx.com with ESMTP; 06 Oct 2022 14:30:52 +0800 IronPort-SDR: +ydmNJzjm6wn71ipKkcTdcjERZXt4eRWAxK85o3rSHtlmrdrPr/0ypo/TkdyEOmkBYLXbeEU19 ZIEsvjgLkZOWHltQnG4RuQ+NUqD2CMM0EAuhBdL8imppwvvcl+aYP+rQUjBQKNvO9mVDmitwyP DpZ2ZPpYhz+R8Rf9PKUqWgE8Sa9jXJ0gZrtNza62lUTmTeQP1fjMIRm4sIWTd4sQ/Map7TpoFC PkEY4N6xL10pLvhGsY3vD76T+CZMg1DiNL9YLyUYMVtoTeMcgyV0tEGaypG+4kD7rm94KIb1+c vIjyV6zN8AtpkS/Di8uyq1uG Received: from uls-op-cesaip02.wdc.com ([10.248.3.37]) by uls-op-cesaep02.wdc.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 05 Oct 2022 22:45:03 -0700 IronPort-SDR: RCqLPALbvtgv7g4rSkbKHnnXdEx3qmLu1TgFaXRzgi3ydKHM5GDlH2CEplivlZVGxBqC9R3b89 z7JIei4XUqp8DPwtJFDA35xVVKN7hcyFo0w67YzOnYsPhEjZBRW5/06Qnc0RANAs7GYE1tT23B hDV9+TM65F+eQA7vn5iznt4uMu6k/bz2+K19Oar9oHVH9WtEp7mTLkZmVtKywItZBc3valfwky IlwLYVlU2qdx1BkYzcKoVI2d45I16/KYv4KAA+iAsw/8ayUscsnf3yOH9qx+tCH1TTKf1ibfNJ EAQ= WDCIronportException: Internal Received: from usg-ed-osssrv.wdc.com ([10.3.10.180]) by uls-op-cesaip02.wdc.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 05 Oct 2022 23:30:52 -0700 Received: from usg-ed-osssrv.wdc.com (usg-ed-osssrv.wdc.com [127.0.0.1]) by usg-ed-osssrv.wdc.com (Postfix) with ESMTP id 4MjhQh0ytkz1RwqL for ; Wed, 5 Oct 2022 23:30:52 -0700 (PDT) Authentication-Results: usg-ed-osssrv.wdc.com (amavisd-new); dkim=pass reason="pass (just generated, assumed good)" header.d=opensource.wdc.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d= opensource.wdc.com; h=content-transfer-encoding:content-type :in-reply-to:organization:from:references:to:content-language :subject:user-agent:mime-version:date:message-id; s=dkim; t= 1665037851; x=1667629852; bh=x7kTAo4qP3/SnUW9k2mZ8CbPne03lLNrJUi yWWlRBzs=; b=ozGb8CeM8yxm6fW3xag9MQAVtqvSsWoZjyAGS5zRcRTzurLYnXB H9G9p1p2w9KITvFSgnQ2IMJ0h+kME2E/4AELn4KY6SfxAsByDJYXr8Wg4HBA+d6/ RuuxNEDOBXfQco2XhTntt6lqGhTHc0xbC6v9ERODNbtCLqgV+q8tph1rV2Gwi5dF bRkUSo8yC+0pDrnBJxedE1bbrLnmpJEG2gIIbhPsin5hHv2PwKFExnjTa8gOCp5T fU61UYxrsiWcfFx47M92xRPp1z46cQOPUk/ZFZka10A4wT45g56z8JuzHKErCdvN GjOvF+YmwvsDYIpYHcrjF4ETdYvSAd/c/Ug== X-Virus-Scanned: amavisd-new at usg-ed-osssrv.wdc.com Received: from usg-ed-osssrv.wdc.com ([127.0.0.1]) by usg-ed-osssrv.wdc.com (usg-ed-osssrv.wdc.com [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id yBm1niUDbupC for ; Wed, 5 Oct 2022 23:30:51 -0700 (PDT) Received: from [10.225.163.106] (unknown [10.225.163.106]) by usg-ed-osssrv.wdc.com (Postfix) with ESMTPSA id 4MjhQg0DJxz1RvLy; Wed, 5 Oct 2022 23:30:50 -0700 (PDT) Message-ID: Date: Thu, 6 Oct 2022 15:30:49 +0900 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.1 Subject: Re: [PATCH] ata: pata_mpc52xx: Replace NO_IRQ by 0 Content-Language: en-US To: Christophe Leroy , Sergey Shtylyov Cc: "linux-kernel@vger.kernel.org" , "linux-ide@vger.kernel.org" References: <60557988-a5e5-8c81-72f9-c0f3ab9ed573@opensource.wdc.com> <14fa0e63-1a43-6c80-5ffe-1c7100ed88ba@csgroup.eu> From: Damien Le Moal Organization: Western Digital Research In-Reply-To: <14fa0e63-1a43-6c80-5ffe-1c7100ed88ba@csgroup.eu> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-ide@vger.kernel.org On 10/6/22 14:49, Christophe Leroy wrote: >=20 >=20 > Le 06/10/2022 =C3=A0 07:45, Damien Le Moal a =C3=A9crit=C2=A0: >> On 10/6/22 14:17, Christophe Leroy wrote: >>> NO_IRQ is used to check the return of irq_of_parse_and_map(). >>> >>> On some architecture NO_IRQ is 0, on other architectures it is -1. >>> >>> irq_of_parse_and_map() returns 0 on error, independent of NO_IRQ. >>> >>> So use 0 instead of using NO_IRQ. >>> >>> Signed-off-by: Christophe Leroy >> >> Doesn't this need fixes and cc:stable tags ? >=20 > I don't think so, because the only user of this driver is powerpc and=20 > powerpc has NO_IRQ set to 0. >=20 > I'm sending this because I was to remove NO_IRQ in powerpc in a second = step. OK. Got it. So queuing this for 6.2 is OK ? Or do you prefer seeing this as a "fix" in 6.1 ? >=20 >> >>> --- >>> drivers/ata/pata_mpc52xx.c | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/drivers/ata/pata_mpc52xx.c b/drivers/ata/pata_mpc52xx.c >>> index 6559b606736d..3ebd6522a1fd 100644 >>> --- a/drivers/ata/pata_mpc52xx.c >>> +++ b/drivers/ata/pata_mpc52xx.c >>> @@ -731,7 +731,7 @@ static int mpc52xx_ata_probe(struct platform_devi= ce *op) >>> udma_mask =3D ATA_UDMA2 & ((1 << (*prop + 1)) - 1); >>> =20 >>> ata_irq =3D irq_of_parse_and_map(op->dev.of_node, 0); >>> - if (ata_irq =3D=3D NO_IRQ) { >>> + if (!ata_irq) { >>> dev_err(&op->dev, "error mapping irq\n"); >>> return -EINVAL; >>> } --=20 Damien Le Moal Western Digital Research