From: JeffleXu <jefflexu@linux.alibaba.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: davem@davemloft.net, linux-ide@vger.kernel.org,
joseph.qi@linux.alibaba.com
Subject: Re: [PATCH] ide: set missing QUEUE_FLAG_ADD_RANDOM
Date: Tue, 9 Feb 2021 17:00:11 +0800 [thread overview]
Message-ID: <fde2f52d-48a4-b193-adfc-8abbaeb5c04f@linux.alibaba.com> (raw)
In-Reply-To: <20210209083220.GA1708073@infradead.org>
On 2/9/21 4:32 PM, Christoph Hellwig wrote:
> On Tue, Feb 09, 2021 at 04:10:13PM +0800, Jeffle Xu wrote:
>> While the whole block layer has migrated to mq framework,
>> QUEUE_FLAG_ADD_RANDOM is not included in QUEUE_FLAG_MQ_DEFAULT as the
>> default flags.
>
> If you are using the legacy ide code anywhere please switch to libata
> ASAP as it is about to go away.
>
Thanks for replying. I have not encountered any trouble in reality
world. Actually I just find that this code can't work well when I'm
search QUEUE_FLAG_ADD_RANDOM. I'm not familiar with ide world. Please
let me know if I miss something.
Also there are several device drivers still calling
'blk_queue_flag_clear(QUEUE_FLAG_ADD_RANDOM, q)', though they have
migrated to mq and have no need clearing QUEUE_FLAG_ADD_RANDOM.
--
Thanks,
Jeffle
prev parent reply other threads:[~2021-02-09 9:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-09 8:10 [PATCH] ide: set missing QUEUE_FLAG_ADD_RANDOM Jeffle Xu
2021-02-09 8:32 ` Christoph Hellwig
2021-02-09 9:00 ` JeffleXu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fde2f52d-48a4-b193-adfc-8abbaeb5c04f@linux.alibaba.com \
--to=jefflexu@linux.alibaba.com \
--cc=davem@davemloft.net \
--cc=hch@infradead.org \
--cc=joseph.qi@linux.alibaba.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox