From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3702DC77B76 for ; Tue, 18 Apr 2023 08:00:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230327AbjDRIAH (ORCPT ); Tue, 18 Apr 2023 04:00:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39872 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229962AbjDRIAG (ORCPT ); Tue, 18 Apr 2023 04:00:06 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 66D4BC5; Tue, 18 Apr 2023 01:00:05 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 05900628D9; Tue, 18 Apr 2023 08:00:05 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1A44DC433D2; Tue, 18 Apr 2023 08:00:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1681804804; bh=s60CVmIII2Y0/UiFhD2Gk75AqSi4Ndp6RwEByH1gFpc=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=SOzUZ4nk0TBp9MMijNlh6Pbw55PQVlaLmg8Bg+4JlUXrqtNE7D8WceZkiP6RMXwpp HysXBOvRm6VLgLv9OCK4+m6XYX5bVZeXG5vB6QVADoswsOzhjsdApsPSjWOhSbtZf4 2T3o2C10uyGZt1VpWV0yuDqQIR/jLRQoUEwGGu+vSFTjapVMt2uKRCE3wNXzqjmYmL iXQFE0F0MlVZNcZS83Puc41mNJVOtHon8/c70Q6U4aO5TcX2malrU/OdQzpZXKrqdG +y3SupcJFs7zWKwd+60uwjHYv7oEuA/I0H3DmO85CvygO3Mh6eltx7+cdkDFJDTLg8 w3sYs1fhdgHmQ== Message-ID: Date: Tue, 18 Apr 2023 17:00:01 +0900 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH 2/2] ata: libata-core: Apply ATI NCQ horkage to ASPEED as well Content-Language: en-US To: Christoph Hellwig , Patrick McLean Cc: linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org, Bjorn Helgaas , linux-pci@vger.kernel.org, Dave Airlie , Thomas Zimmermann , dri-devel@lists.freedesktop.org References: <20230418011720.3900090-1-chutzpah@gentoo.org> <20230418011720.3900090-3-chutzpah@gentoo.org> From: Damien Le Moal Organization: Western Digital Research In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-ide@vger.kernel.org On 4/18/23 14:24, Christoph Hellwig wrote: > On Mon, Apr 17, 2023 at 06:17:20PM -0700, Patrick McLean wrote: >> We have some machines with ASPEED SATA controllers, and are seeing the same NCQ >> issues that ATI controllers (I am not sure if it's a rebranded ATI controller, >> or they both have some faulty implementation). This NCQ breakage is consistent >> across a few different types of drives. >> >> Instead of maintaining a list of drives that are broken with ASPEED controllers > > Are these ASPEED controllers all the same or a wide variety? > Quirking all controllers from the same vendor seems like an overly > broad approach to me. Indeed. If you checked only one adapter model from ASPEED, then all that is needed is define it with "board_ahci_noncq" in drivers/ata/ahci.c (see ahci_pci_tbl array). NCQ support will be turned off for that particular adapter with that.