Re: [Fwd: [BUG] sata_via doesn't detect anymore my disks (broken between rc1 and rc3)]

[Thierry Vignaud <tvignaud@mandriva.com>]

[-- Attachment #1: Type: text/plain, Size: 436 bytes --]

Tejun Heo <htejun@gmail.com> writes:

> [cc'ing linux-ide]
> 
> (this is regarding vt6421 failing to detect devices on boot after EH udpate)
> 
> > I think I have (but I was so tired I won't 100% claim to).
> > I'll retest tonight.

The following one-liner on top of your previous patch fixed detecting
disks on vt6421 with 2.6.18-rc4-mm1 (sorry for the delay, I was
offline due to illness). (s!/scsi!/ata! b/c of alan changes in -mm)


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: work1.diff --]
[-- Type: text/x-patch, Size: 480 bytes --]

fix detecting devices on vt6421 SATA controller
("ATA: abnormal status 0x7F on port 0xB007"):
--- drivers/ata/sata_via.c.tv6	2006-08-20 16:37:41.000000000 +0200
+++ drivers/ata/sata_via.c	2006-08-20 17:20:23.000000000 +0200
@@ -244,7 +244,7 @@
 
 static void vt6421_error_handler(struct ata_port *ap)
 {
-	return ata_bmdma_drive_eh(ap, ata_std_prereset, NULL,
+	return ata_bmdma_drive_eh(ap, vt6420_prereset, ata_std_softreset,
 				  sata_std_hardreset, ata_std_postreset);
 }
 

[-- Attachment #3: Type: text/plain, Size: 632 bytes --]

 
> Can you please test two patches attached in this mail?  Just quick
> result will be enough.  If both don't work, I'll go ahead and create
> a third one - which emulates the old phy hardreset exactly as I did
> for softreset of vt6420.

I'll.

As, I've tested that using:
- ata_std_prereset + ata_std_softreset didn't work
- vt6420_prereset + ata_std_softreset worked
- vt6420_prereset w/o ata_std_softreset didn't work

I simple interdiff between your two patches makes me think the odds're
higher the second will succeed but you've done some extra changes
since your previous patch.
I'll you tell you more about this tomorrow.