From: Arnaud Patard <apatard@mandriva.com>
To: linux-ide@vger.kernel.org
Cc: alan@redhat.com
Subject: [PATCH] pata_marvell: fix cable detection
Date: Fri, 17 Nov 2006 19:04:06 +0100 [thread overview]
Message-ID: <m3fycidk6h.fsf@anduin.mandriva.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 171 bytes --]
A "break;" is missing in the cable detection switch() statement, leading
to a wrong detection of the cable type.
Signed-off-by: Arnaud Patard <apatard@mandriva.com>
---
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: pata_marvell_fix_cbl_detect.patch --]
[-- Type: text/x-patch, Size: 401 bytes --]
Index: libata-dev/drivers/ata/pata_marvell.c
===================================================================
--- libata-dev.orig/drivers/ata/pata_marvell.c
+++ libata-dev/drivers/ata/pata_marvell.c
@@ -62,6 +62,7 @@ static int marvell_pre_reset(struct ata_
ap->cbl = ATA_CBL_PATA80;
else
ap->cbl = ATA_CBL_PATA40;
+ break;
case 1: /* Legacy SATA port */
ap->cbl = ATA_CBL_SATA;
next reply other threads:[~2006-11-17 18:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-17 18:04 Arnaud Patard [this message]
2006-11-17 23:40 ` [PATCH] pata_marvell: fix cable detection Alan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3fycidk6h.fsf@anduin.mandriva.com \
--to=apatard@mandriva.com \
--cc=alan@redhat.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox