From: Krzysztof Halasa <khc@pm.waw.pl>
To: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Cc: Sergei Shtylyov <sshtylyov@ru.mvista.com>,
Joe Perches <joe@perches.com>,
linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org,
Borislav Petkov <petkovbb@gmail.com>
Subject: Re: [PATCH 6/6] drivers/ide: Convert printk(KERN_NOTICE to pr_notice(
Date: Mon, 18 May 2009 19:18:52 +0200 [thread overview]
Message-ID: <m3octqib2b.fsf@intrepid.localdomain> (raw)
In-Reply-To: <200905181550.07723.bzolnier@gmail.com> (Bartlomiej Zolnierkiewicz's message of "Mon\, 18 May 2009 15\:50\:07 +0200")
Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> writes:
>> Though I think most people would agree that the latter is much better,
>> no?
>
> No, it just hides the real issue:
I didn't say it's best. Just better :-)
>> I think removal (rewording) of this rule has already been agreed upon,
>> though not exactly yet codified.
>
> This is not a strict rule but in 99% cases it shows that the code could
> be improved further without >80 chars lines.
I don't have the stat numbers handy but the established idea is that
since the texts could be up to 80-chars long (and it's a good thing),
the printk line needed to output them has to be longer.
IOW, breaking the text into pieces is worse. Obviously, that doesn't
mean one can't do better.
--
Krzysztof Halasa
next prev parent reply other threads:[~2009-05-18 17:18 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1242609803.git.joe@perches.com>
2009-05-18 2:21 ` [PATCH 1/6] drivers/ide: Convert printk(KERN_DEBUG to pr_debug( Joe Perches
2009-05-18 9:34 ` Sergei Shtylyov
2009-05-18 2:21 ` [PATCH 2/6] drivers/ide: Convert printk(KERN_INFO to pr_info( Joe Perches
2009-05-18 2:31 ` Joe Perches
2009-05-18 2:21 ` [PATCH 3/6] drivers/ide: Convert printk(KERN_ERR to pr_err( Joe Perches
2009-05-18 2:21 ` [PATCH 4/6] drivers/ide: Convert printk(KERN_WARNING to pr_warning( Joe Perches
2009-05-18 2:21 ` [PATCH 5/6] drivers/ide: Convert printk(KERN_CONT to pr_cont( Joe Perches
2009-05-18 2:21 ` [PATCH 6/6] drivers/ide: Convert printk(KERN_NOTICE to pr_notice( Joe Perches
2009-05-18 10:11 ` Sergei Shtylyov
2009-05-18 13:22 ` Krzysztof Halasa
2009-05-18 13:38 ` Sergei Shtylyov
2009-05-18 13:50 ` Bartlomiej Zolnierkiewicz
2009-05-18 17:18 ` Krzysztof Halasa [this message]
2009-05-18 18:55 ` Alan Cox
2009-05-18 13:32 ` Joe Perches
2009-05-18 14:12 ` [PATCH 0/6] drivers/ide Convert printk(KERN_<foo> to pr_<foo>( Bartlomiej Zolnierkiewicz
2009-05-18 15:41 ` Joe Perches
2009-05-18 15:48 ` Bartlomiej Zolnierkiewicz
2009-05-18 15:56 ` James Bottomley
2009-05-18 20:59 ` Joe Perches
2009-05-18 21:15 ` James Bottomley
2009-05-18 21:21 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3octqib2b.fsf@intrepid.localdomain \
--to=khc@pm.waw.pl \
--cc=bzolnier@gmail.com \
--cc=joe@perches.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=petkovbb@gmail.com \
--cc=sshtylyov@ru.mvista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).