* Re: powerpc: disable IDE subsystem in pasemi_defconfig
From: Michael Ellerman @ 2016-11-17 12:04 UTC (permalink / raw)
To: linuxppc-dev, Benjamin Herrenschmidt, Paul Mackerras
Cc: Olof Johansson, linux-ide, linux-kernel, b.zolnierkie
In-Reply-To: <1454514630-29269-17-git-send-email-b.zolnierkie@samsung.com>
On Wed, 2016-03-02 at 15:50:23 UTC, Bartlomiej Zolnierkiewicz wrote:
> This patch disables deprecated IDE subsystem in pasemi_defconfig
> (no IDE host drivers are selected in this config so there is no valid
> reason to enable IDE subsystem itself).
>
> Cc: Olof Johansson <olof@lixom.net>
> Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/23bf36cd120f97e85ce089c841197f
cheers
^ permalink raw reply
* Re: [RFT] powerpc: convert cell_defconfig to use libata PATA drivers
From: Michael Ellerman @ 2016-11-17 12:04 UTC (permalink / raw)
To: linuxppc-dev, Benjamin Herrenschmidt, Paul Mackerras
Cc: linux-ide, linux-kernel, b.zolnierkie
In-Reply-To: <1454514630-29269-13-git-send-email-b.zolnierkie@samsung.com>
On Wed, 2016-03-02 at 15:50:19 UTC, Bartlomiej Zolnierkiewicz wrote:
> IDE subsystem has been deprecated since 2009 and the majority
> (if not all) of Linux distributions have switched to use
> libata for ATA support exclusively. However there are still
> some users (mostly old or/and embedded non-x86 systems) that
> have not converted from using IDE subsystem to libata PATA
> drivers. This doesn't seem to be good thing in the long-term
> for Linux as while there is less and less PATA systems left
> in use:
>
> * testing efforts are divided between two subsystems
>
> * having duplicate drivers for same hardware confuses users
>
> This patch converts cell_defconfig to use libata PATA drivers.
>
> Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/8020c1220dd4ff324698668f067746
cheers
^ permalink raw reply
* Re: [RFT] powerpc: convert chrp32_defconfig to use libata PATA drivers
From: Michael Ellerman @ 2016-11-17 12:04 UTC (permalink / raw)
To: linuxppc-dev, Benjamin Herrenschmidt, Paul Mackerras
Cc: linux-ide, linux-kernel, b.zolnierkie
In-Reply-To: <1454514630-29269-14-git-send-email-b.zolnierkie@samsung.com>
On Wed, 2016-03-02 at 15:50:20 UTC, Bartlomiej Zolnierkiewicz wrote:
> IDE subsystem has been deprecated since 2009 and the majority
> (if not all) of Linux distributions have switched to use
> libata for ATA support exclusively. However there are still
> some users (mostly old or/and embedded non-x86 systems) that
> have not converted from using IDE subsystem to libata PATA
> drivers. This doesn't seem to be good thing in the long-term
> for Linux as while there is less and less PATA systems left
> in use:
>
> * testing efforts are divided between two subsystems
>
> * having duplicate drivers for same hardware confuses users
>
> This patch converts chrp32_defconfig to use libata PATA
> drivers.
>
> Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/f22cc4d7bb268ffc585a5f8593138b
cheers
^ permalink raw reply
* Re: [RFT] powerpc: convert g5_defconfig to use libata PATA drivers
From: Michael Ellerman @ 2016-11-17 12:04 UTC (permalink / raw)
To: linuxppc-dev, Benjamin Herrenschmidt, Paul Mackerras
Cc: linux-ide, linux-kernel, b.zolnierkie
In-Reply-To: <1454514630-29269-15-git-send-email-b.zolnierkie@samsung.com>
On Wed, 2016-03-02 at 15:50:21 UTC, Bartlomiej Zolnierkiewicz wrote:
> IDE subsystem has been deprecated since 2009 and the majority
> (if not all) of Linux distributions have switched to use
> libata for ATA support exclusively. However there are still
> some users (mostly old or/and embedded non-x86 systems) that
> have not converted from using IDE subsystem to libata PATA
> drivers. This doesn't seem to be good thing in the long-term
> for Linux as while there is less and less PATA systems left
> in use:
>
> * testing efforts are divided between two subsystems
>
> * having duplicate drivers for same hardware confuses users
>
> This patch converts g5_defconfig to use libata PATA drivers.
>
> Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/b10fd396376c9b1b1f5b0a3980b487
cheers
^ permalink raw reply
* Re: [RFT] powerpc: convert maple_defconfig to use libata PATA drivers
From: Michael Ellerman @ 2016-11-17 12:04 UTC (permalink / raw)
To: linuxppc-dev, Benjamin Herrenschmidt, Paul Mackerras
Cc: linux-ide, linux-kernel, b.zolnierkie
In-Reply-To: <1454514630-29269-16-git-send-email-b.zolnierkie@samsung.com>
On Wed, 2016-03-02 at 15:50:22 UTC, Bartlomiej Zolnierkiewicz wrote:
> IDE subsystem has been deprecated since 2009 and the majority
> (if not all) of Linux distributions have switched to use
> libata for ATA support exclusively. However there are still
> some users (mostly old or/and embedded non-x86 systems) that
> have not converted from using IDE subsystem to libata PATA
> drivers. This doesn't seem to be good thing in the long-term
> for Linux as while there is less and less PATA systems left
> in use:
>
> * testing efforts are divided between two subsystems
>
> * having duplicate drivers for same hardware confuses users
>
> This patch converts maple_defconfig to use libata PATA
> drivers.
>
> Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/c1f9d2938bd75c0245f640ad30d81e
cheers
^ permalink raw reply
* Re: [RFT] powerpc: convert pmac32_defconfig to use libata PATA drivers
From: Michael Ellerman @ 2016-11-17 12:04 UTC (permalink / raw)
To: linuxppc-dev, Benjamin Herrenschmidt, Paul Mackerras
Cc: linux-ide, linux-kernel, b.zolnierkie
In-Reply-To: <1454514630-29269-18-git-send-email-b.zolnierkie@samsung.com>
On Wed, 2016-03-02 at 15:50:24 UTC, Bartlomiej Zolnierkiewicz wrote:
> IDE subsystem has been deprecated since 2009 and the majority
> (if not all) of Linux distributions have switched to use
> libata for ATA support exclusively. However there are still
> some users (mostly old or/and embedded non-x86 systems) that
> have not converted from using IDE subsystem to libata PATA
> drivers. This doesn't seem to be good thing in the long-term
> for Linux as while there is less and less PATA systems left
> in use:
>
> * testing efforts are divided between two subsystems
>
> * having duplicate drivers for same hardware confuses users
>
> This patch converts pmac32_defconfig to use libata PATA
> drivers.
>
> Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/b0d3a074174138b7714533968be723
cheers
^ permalink raw reply
* Re: [RFT] powerpc: convert ppc64_defconfig to use libata PATA drivers
From: Michael Ellerman @ 2016-11-17 12:04 UTC (permalink / raw)
To: linuxppc-dev, Benjamin Herrenschmidt, Paul Mackerras
Cc: linux-ide, linux-kernel, b.zolnierkie
In-Reply-To: <1454514630-29269-19-git-send-email-b.zolnierkie@samsung.com>
On Wed, 2016-03-02 at 15:50:25 UTC, Bartlomiej Zolnierkiewicz wrote:
> IDE subsystem has been deprecated since 2009 and the majority
> (if not all) of Linux distributions have switched to use
> libata for ATA support exclusively. However there are still
> some users (mostly old or/and embedded non-x86 systems) that
> have not converted from using IDE subsystem to libata PATA
> drivers. This doesn't seem to be good thing in the long-term
> for Linux as while there is less and less PATA systems left
> in use:
>
> * testing efforts are divided between two subsystems
>
> * having duplicate drivers for same hardware confuses users
>
> This patch converts ppc64_defconfig to use libata PATA
> drivers.
>
> Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/7ddf3db3d775d09da87f38ab39f261
cheers
^ permalink raw reply
* Re: [RFT] powerpc: convert amigaone_defconfig to use libata PATA drivers
From: Michael Ellerman @ 2016-11-17 12:04 UTC (permalink / raw)
To: linuxppc-dev, Benjamin Herrenschmidt, Paul Mackerras
Cc: linux-ide, linux-kernel, b.zolnierkie
In-Reply-To: <1454514630-29269-12-git-send-email-b.zolnierkie@samsung.com>
On Wed, 2016-03-02 at 15:50:18 UTC, Bartlomiej Zolnierkiewicz wrote:
> IDE subsystem has been deprecated since 2009 and the majority
> (if not all) of Linux distributions have switched to use
> libata for ATA support exclusively. However there are still
> some users (mostly old or/and embedded non-x86 systems) that
> have not converted from using IDE subsystem to libata PATA
> drivers. This doesn't seem to be good thing in the long-term
> for Linux as while there is less and less PATA systems left
> in use:
>
> * testing efforts are divided between two subsystems
>
> * having duplicate drivers for same hardware confuses users
>
> This patch converts amigaone_defconfig to use libata PATA
> drivers.
>
> Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/67f6d66559930eddea06c6bfdaf0e5
cheers
^ permalink raw reply
* Re: [RFT] powerpc: convert ppc6xx_defconfig to use libata PATA drivers
From: Michael Ellerman @ 2016-11-17 12:04 UTC (permalink / raw)
To: linuxppc-dev, Benjamin Herrenschmidt, Paul Mackerras
Cc: linux-ide, linux-kernel, b.zolnierkie
In-Reply-To: <1454514630-29269-21-git-send-email-b.zolnierkie@samsung.com>
On Wed, 2016-03-02 at 15:50:27 UTC, Bartlomiej Zolnierkiewicz wrote:
> IDE subsystem has been deprecated since 2009 and the majority
> (if not all) of Linux distributions have switched to use
> libata for ATA support exclusively. However there are still
> some users (mostly old or/and embedded non-x86 systems) that
> have not converted from using IDE subsystem to libata PATA
> drivers. This doesn't seem to be good thing in the long-term
> for Linux as while there is less and less PATA systems left
> in use:
>
> * testing efforts are divided between two subsystems
>
> * having duplicate drivers for same hardware confuses users
>
> This patch converts ppc6xx_defconfig to use libata PATA
> drivers.
>
> Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/7f10fe36369068341aff05c067a786
cheers
^ permalink raw reply
* Re: [RFT] powerpc: convert ppc64e_defconfig to use libata PATA drivers
From: Michael Ellerman @ 2016-11-17 12:04 UTC (permalink / raw)
To: linuxppc-dev, Benjamin Herrenschmidt, Paul Mackerras
Cc: linux-ide, linux-kernel, b.zolnierkie
In-Reply-To: <1454514630-29269-20-git-send-email-b.zolnierkie@samsung.com>
On Wed, 2016-03-02 at 15:50:26 UTC, Bartlomiej Zolnierkiewicz wrote:
> IDE subsystem has been deprecated since 2009 and the majority
> (if not all) of Linux distributions have switched to use
> libata for ATA support exclusively. However there are still
> some users (mostly old or/and embedded non-x86 systems) that
> have not converted from using IDE subsystem to libata PATA
> drivers. This doesn't seem to be good thing in the long-term
> for Linux as while there is less and less PATA systems left
> in use:
>
> * testing efforts are divided between two subsystems
>
> * having duplicate drivers for same hardware confuses users
>
> This patch converts ppc64e_defconfig to use libata PATA
> drivers.
>
> Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/4a0b4bfe0101901126dc4dba0ba904
cheers
^ permalink raw reply
* Re: [RFT] powerpc: convert pseries_defconfig to use libata PATA drivers
From: Michael Ellerman @ 2016-11-17 12:04 UTC (permalink / raw)
To: linuxppc-dev, Benjamin Herrenschmidt, Paul Mackerras
Cc: linux-ide, linux-kernel, b.zolnierkie
In-Reply-To: <1454514630-29269-23-git-send-email-b.zolnierkie@samsung.com>
On Wed, 2016-03-02 at 15:50:29 UTC, Bartlomiej Zolnierkiewicz wrote:
> IDE subsystem has been deprecated since 2009 and the majority
> (if not all) of Linux distributions have switched to use
> libata for ATA support exclusively. However there are still
> some users (mostly old or/and embedded non-x86 systems) that
> have not converted from using IDE subsystem to libata PATA
> drivers. This doesn't seem to be good thing in the long-term
> for Linux as while there is less and less PATA systems left
> in use:
>
> * testing efforts are divided between two subsystems
>
> * having duplicate drivers for same hardware confuses users
>
> This patch converts pseries_defconfig to use libata PATA
> drivers.
>
> Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/80269fe4203432168dae6e49770d64
cheers
^ permalink raw reply
* Re: [RFT] powerpc: convert storcenter_defconfig to use libata PATA drivers
From: Michael Ellerman @ 2016-11-17 12:04 UTC (permalink / raw)
To: linuxppc-dev, Benjamin Herrenschmidt, Paul Mackerras
Cc: linux-ide, linux-kernel, b.zolnierkie
In-Reply-To: <1454514630-29269-24-git-send-email-b.zolnierkie@samsung.com>
On Wed, 2016-03-02 at 15:50:30 UTC, Bartlomiej Zolnierkiewicz wrote:
> IDE subsystem has been deprecated since 2009 and the majority
> (if not all) of Linux distributions have switched to use
> libata for ATA support exclusively. However there are still
> some users (mostly old or/and embedded non-x86 systems) that
> have not converted from using IDE subsystem to libata PATA
> drivers. This doesn't seem to be good thing in the long-term
> for Linux as while there is less and less PATA systems left
> in use:
>
> * testing efforts are divided between two subsystems
>
> * having duplicate drivers for same hardware confuses users
>
> This patch converts storcenter_defconfig to use libata PATA
> drivers.
>
> Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/1aed61f9c9664cc7331079a66aba99
cheers
^ permalink raw reply
* [PATCH v2] ata: xgene: Enable NCQ support for APM X-Gene SATA controller hardware v1.1
From: Rameshwar Prasad Sahu @ 2016-11-18 9:45 UTC (permalink / raw)
To: olof-nZhT3qVonbNeoWH0uzbU5w, tj-DgEjT+Ai2ygdnm+yROfE0A,
arnd-r2nGTMty4D4
Cc: linux-scsi-u79uwXL29TY76Z2rM5mHXA,
linux-ide-u79uwXL29TY76Z2rM5mHXA,
devicetree-u79uwXL29TY76Z2rM5mHXA,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
mlangsdo-H+wXaHxf7aLQT0dZR+AlfA, jcm-H+wXaHxf7aLQT0dZR+AlfA,
patches-qTEPVZfXA3Y, Rameshwar Prasad Sahu
This patch enables NCQ support for APM X-Gene SATA controller hardware v1.1
that was broken with hardware v1.0. Second thing, here we should not assume
XGENE_AHCI_V2 always in case of having valid _CID in ACPI table. I need to
remove this assumption because V1_1 also has a valid _CID for backward
compatibly with v1.
v2 changes:
1. Changed patch description
Signed-off-by: Rameshwar Prasad Sahu <rsahu-qTEPVZfXA3Y@public.gmane.org>
---
drivers/ata/ahci_xgene.c | 14 ++++++++------
1 files changed, 8 insertions(+), 6 deletions(-)
diff --git a/drivers/ata/ahci_xgene.c b/drivers/ata/ahci_xgene.c
index 73b19b2..8b88be9 100644
--- a/drivers/ata/ahci_xgene.c
+++ b/drivers/ata/ahci_xgene.c
@@ -87,6 +87,7 @@
enum xgene_ahci_version {
XGENE_AHCI_V1 = 1,
+ XGENE_AHCI_V1_1,
XGENE_AHCI_V2,
};
@@ -734,6 +735,7 @@ static struct scsi_host_template ahci_platform_sht = {
#ifdef CONFIG_ACPI
static const struct acpi_device_id xgene_ahci_acpi_match[] = {
{ "APMC0D0D", XGENE_AHCI_V1},
+ { "APMC0D67", XGENE_AHCI_V1_1},
{ "APMC0D32", XGENE_AHCI_V2},
{},
};
@@ -742,6 +744,7 @@ MODULE_DEVICE_TABLE(acpi, xgene_ahci_acpi_match);
static const struct of_device_id xgene_ahci_of_match[] = {
{.compatible = "apm,xgene-ahci", .data = (void *) XGENE_AHCI_V1},
+ {.compatible = "apm,xgene-ahci-v1-1", .data = (void *) XGENE_AHCI_V1_1},
{.compatible = "apm,xgene-ahci-v2", .data = (void *) XGENE_AHCI_V2},
{},
};
@@ -755,8 +758,7 @@ static int xgene_ahci_probe(struct platform_device *pdev)
struct resource *res;
const struct of_device_id *of_devid;
enum xgene_ahci_version version = XGENE_AHCI_V1;
- const struct ata_port_info *ppi[] = { &xgene_ahci_v1_port_info,
- &xgene_ahci_v2_port_info };
+ const struct ata_port_info *ppi;
int rc;
hpriv = ahci_platform_get_resources(pdev);
@@ -821,8 +823,6 @@ static int xgene_ahci_probe(struct platform_device *pdev)
dev_warn(&pdev->dev, "%s: Error reading device info. Assume version1\n",
__func__);
version = XGENE_AHCI_V1;
- } else if (info->valid & ACPI_VALID_CID) {
- version = XGENE_AHCI_V2;
}
}
}
@@ -858,18 +858,20 @@ skip_clk_phy:
switch (version) {
case XGENE_AHCI_V1:
+ ppi = &xgene_ahci_v1_port_info;
hpriv->flags = AHCI_HFLAG_NO_NCQ;
break;
case XGENE_AHCI_V2:
+ ppi = &xgene_ahci_v2_port_info;
hpriv->flags |= AHCI_HFLAG_YES_FBS;
hpriv->irq_handler = xgene_ahci_irq_intr;
break;
default:
+ ppi = &xgene_ahci_v1_port_info;
break;
}
- rc = ahci_platform_init_host(pdev, hpriv, ppi[version - 1],
- &ahci_platform_sht);
+ rc = ahci_platform_init_host(pdev, hpriv, ppi, &ahci_platform_sht);
if (rc)
goto disable_resources;
--
1.7.1
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related
* [PATCH] ahci: always fall back to single-MSI mode
From: Christoph Hellwig @ 2016-11-18 13:09 UTC (permalink / raw)
To: tj; +Cc: michael, linux-ide
Don't try to guess what the errors from pci_irq_alloc_vectors mean, as
that's too fragile. Instead always try allocating a single vector
when multi-MSI mode fails. This makes various intel Desktop and
Laptop CPUs use MSI again.
Signed-off-by: Christoph Hellwig <hch@lst.de>
Reported-by: Michael Marley <michael@michaelmarley.com>
Tested-by: Michael Marley <michael@michaelmarley.com>
Fixes: 0b9e2988ab22 ("ahci: use pci_alloc_irq_vectors")
---
drivers/ata/ahci.c | 7 -------
1 file changed, 7 deletions(-)
diff --git a/drivers/ata/ahci.c b/drivers/ata/ahci.c
index 9669fc7..74f4c66 100644
--- a/drivers/ata/ahci.c
+++ b/drivers/ata/ahci.c
@@ -1436,13 +1436,6 @@ static int ahci_init_msi(struct pci_dev *pdev, unsigned int n_ports,
"ahci: MRSM is on, fallback to single MSI\n");
pci_free_irq_vectors(pdev);
}
-
- /*
- * -ENOSPC indicated we don't have enough vectors. Don't bother
- * trying a single vectors for any other error:
- */
- if (nvec < 0 && nvec != -ENOSPC)
- return nvec;
}
/*
--
2.1.4
^ permalink raw reply related
* Re: [PATCH 1/2] dt-bindings: ahci-fsl-qoriq: added explanation for reg-names
From: Rob Herring @ 2016-11-18 14:21 UTC (permalink / raw)
To: yuantian.tang
Cc: mark.rutland, devicetree, catalin.marinas, will.deacon,
linux-kernel, linux-ide, tj, shawnguo, linux-arm-kernel
In-Reply-To: <1479369560-9188-1-git-send-email-yuantian.tang@nxp.com>
On Thu, Nov 17, 2016 at 03:59:19PM +0800, yuantian.tang@nxp.com wrote:
> From: Tang Yuantian <Yuantian.Tang@nxp.com>
>
> Added explanation for reg-names to make it more clear.
>
> Signed-off-by: Tang Yuantian <yuantian.tang@nxp.com>
> ---
> Documentation/devicetree/bindings/ata/ahci-fsl-qoriq.txt | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/ata/ahci-fsl-qoriq.txt b/Documentation/devicetree/bindings/ata/ahci-fsl-qoriq.txt
> index fc33ca0..80cf10c 100644
> --- a/Documentation/devicetree/bindings/ata/ahci-fsl-qoriq.txt
> +++ b/Documentation/devicetree/bindings/ata/ahci-fsl-qoriq.txt
> @@ -10,6 +10,8 @@ Required properties:
> Optional properties:
> - dma-coherent: Enable AHCI coherent DMA operation.
> - reg-names: register area names when there are more than 1 register area.
> + example: 'ahci' is for sata controller register.
> + 'sata-ecc' is for sata ecc register.
This is not an example, but should be exactly what names are used.
When is there more than one area? That should be defined by the
compatible string and spelled out here.
Rob
^ permalink raw reply
* Re: [PATCH 0/5] ahci: nvme remap support
From: Dan Williams @ 2016-11-19 6:12 UTC (permalink / raw)
To: Christoph Hellwig
Cc: Tejun Heo, Keith Busch, IDE/ATA development list, linux-nvme
In-Reply-To: <20161115185207.GB5854@lst.de>
On Tue, Nov 15, 2016 at 10:52 AM, Christoph Hellwig <hch@lst.de> wrote:
> As it's been a few weeks since this initial posting: What's the
> status of either getting the magic chipset handshake mode published
> to take the chipset out of this degraded mode, or implementing a bridge
> driver like VMD?
The setting is done via write-once registers (once per reset), so
there is no mechanism for an OS to undo it.
> It seems devices supporting this "slow down the devices and make life
> hell for the OS" mode are getting more common, so we'll have to do
> something about it.
To my knowledge all platforms that ship this configuration now already
ship a BIOS, or have an updated BIOS available, that allows the
platform to be placed into AHCI mode.
Setting the controller to AHCI mode is the best option for running
Linux on these systems.
^ permalink raw reply
* [Bug 185531] pata_hpt366 irq xx: nobody cared
From: bugzilla-daemon @ 2016-11-19 7:15 UTC (permalink / raw)
To: linux-ide
In-Reply-To: <bug-185531-11633@https.bugzilla.kernel.org/>
https://bugzilla.kernel.org/show_bug.cgi?id=185531
--- Comment #1 from Ilario Gottardello <ilario.gottardello@gmail.com> ---
Upgraded ubuntu tu 16.10, problem remains:
[ 157.920408] irq 19: nobody cared (try booting with the "irqpoll" option)
[ 157.920412] CPU: 2 PID: 0 Comm: swapper/2 Tainted: P OE
4.8.0-27-generic #29-Ubuntu
[ 157.920413] Hardware name: System manufacturer System Product Name/P8H67-V,
BIOS 3707 07/12/2013
[ 157.920414] 0000000000200086 49f34aec7d2664cd ffff929caf283e78
ffffffffb342f5b2
[ 157.920416] ffff929c9f6bb400 ffff929c9f6bb4b4 ffff929caf283ea8
ffffffffb30e2b65
[ 157.920417] ffff929c9f6bb400 0000000000000000 ffffffffb3f5a100
0000000000000072
[ 157.920419] Call Trace:
[ 157.920419] <IRQ> [<ffffffffb342f5b2>] dump_stack+0x63/0x81
[ 157.920429] [<ffffffffb30e2b65>] __report_bad_irq+0x35/0xc0
[ 157.920430] [<ffffffffb30e2ef3>] note_interrupt+0x243/0x290
[ 157.920431] [<ffffffffb30e0014>] handle_irq_event_percpu+0x54/0x80
[ 157.920433] [<ffffffffb30e007e>] handle_irq_event+0x3e/0x60
[ 157.920433] [<ffffffffb30e35ef>] handle_fasteoi_irq+0x9f/0x150
[ 157.920435] [<ffffffffb303021a>] handle_irq+0x1a/0x30
[ 157.920437] [<ffffffffb38a18db>] do_IRQ+0x4b/0xd0
[ 157.920439] [<ffffffffb389f9c2>] common_interrupt+0x82/0x82
[ 157.920439] <EOI> [<ffffffffb371d29f>] ? cpuidle_enter_state+0x11f/0x2c0
[ 157.920443] [<ffffffffb371d477>] cpuidle_enter+0x17/0x20
[ 157.920445] [<ffffffffb30c791a>] call_cpuidle+0x2a/0x50
[ 157.920445] [<ffffffffb30c7d00>] cpu_startup_entry+0x2a0/0x350
[ 157.920447] [<ffffffffb30518a1>] start_secondary+0x151/0x190
[ 157.920448] handlers:
[ 157.920450] [<ffffffffb3638d90>] ata_bmdma_interrupt
[ 157.920451] [<ffffffffb3638d90>] ata_bmdma_interrupt
[ 157.920452] Disabling IRQ #19
--
You are receiving this mail because:
You are watching the assignee of the bug.
^ permalink raw reply
* [Bug 188141] New: PCI0680 can't work reliably in UDMA mode over 33
From: bugzilla-daemon @ 2016-11-19 7:46 UTC (permalink / raw)
To: linux-ide
https://bugzilla.kernel.org/show_bug.cgi?id=188141
Bug ID: 188141
Summary: PCI0680 can't work reliably in UDMA mode over 33
Product: IO/Storage
Version: 2.5
Kernel Version: 4.8.0-27-generic #29-Ubuntu SMP Thu Oct 20 21:03:13
UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
Hardware: All
OS: Linux
Tree: Mainline
Status: NEW
Severity: high
Priority: P1
Component: IDE
Assignee: io_ide@kernel-bugs.osdl.org
Reporter: ilario.gottardello@gmail.com
Regression: No
Subsituting an HPT366 IDE controller with a Silicon Image, Inc. PCI0680 Ultra
ATA-133 Host Controller (rev 02) (so same pci slot / cables / hard drives), it
immediately fails to read data from the disks, slowing down the link to
UDMA/33.
Here the log on dmesg:
[ 526.912245] ata3.00: exception Emask 0x0 SAct 0x0 SErr 0x0 action 0x6 frozen
[ 526.912252] ata3.00: failed command: READ DMA EXT
[ 526.912258] ata3.00: cmd 25/00:00:4f:98:ee/00:04:01:00:00/e0 tag 0 dma
524288 in
res 40/00:00:00:4f:c2/00:00:00:00:00/00 Emask 0x4
(timeout)
[ 526.912261] ata3.00: status: { DRDY }
[ 531.951419] ata3: link is slow to respond, please be patient (ready=0)
[ 536.930691] ata3: device not ready (errno=-16), forcing hardreset
[ 536.930705] ata3: soft resetting link
[ 537.145123] ata3.00: configured for UDMA/133
[ 537.145138] ata3: EH complete
[ 569.918070] ata3.00: exception Emask 0x0 SAct 0x0 SErr 0x0 action 0x6 frozen
[ 569.918076] ata3.00: failed command: READ DMA
[ 569.918083] ata3.00: cmd c8/00:50:ef:ba:2f/00:00:00:00:00/e1 tag 0 dma 40960
in
res 40/00:00:00:4f:c2/00:00:00:00:00/00 Emask 0x4
(timeout)
[ 569.918086] ata3.00: status: { DRDY }
[ 574.957860] ata3: link is slow to respond, please be patient (ready=0)
[ 579.945773] ata3: device not ready (errno=-16), forcing hardreset
[ 579.945788] ata3: soft resetting link
[ 580.159919] ata3.00: configured for UDMA/133
[ 580.159933] ata3: EH complete
[ 612.924604] ata3.00: exception Emask 0x0 SAct 0x0 SErr 0x0 action 0x6 frozen
[ 612.924610] ata3.00: failed command: READ DMA EXT
[ 612.924616] ata3.00: cmd 25/00:00:4f:10:da/00:04:01:00:00/e0 tag 0 dma
524288 in
res 40/00:00:00:4f:c2/00:00:00:00:00/00 Emask 0x4
(timeout)
[ 612.924619] ata3.00: status: { DRDY }
[ 617.968302] ata3: link is slow to respond, please be patient (ready=0)
[ 622.948039] ata3: device not ready (errno=-16), forcing hardreset
[ 622.948053] ata3: soft resetting link
[ 623.162218] ata3.00: configured for UDMA/133
[ 623.162232] ata3: EH complete
[ 655.930086] ata3.00: limiting speed to UDMA/100:PIO4
[ 655.930089] ata3.00: exception Emask 0x0 SAct 0x0 SErr 0x0 action 0x6 frozen
[ 655.930095] ata3.00: failed command: READ DMA EXT
[ 655.930101] ata3.00: cmd 25/00:a8:8f:4e:a8/00:02:01:00:00/e0 tag 0 dma
348160 in
res 40/00:00:00:4f:c2/00:00:00:00:00/00 Emask 0x4
(timeout)
[ 655.930104] ata3.00: status: { DRDY }
[ 660.933621] ata3: link is slow to respond, please be patient (ready=0)
[ 665.985242] ata3: device not ready (errno=-16), forcing hardreset
[ 665.985256] ata3: soft resetting link
[ 666.180539] ata3.00: configured for UDMA/100
[ 666.180553] ata3: EH complete
[ 698.934573] ata3.00: exception Emask 0x0 SAct 0x0 SErr 0x0 action 0x6 frozen
[ 698.934580] ata3.00: failed command: READ DMA EXT
[ 698.934586] ata3.00: cmd 25/00:00:f7:ad:aa/00:08:01:00:00/e0 tag 0 dma
1048576 in
res 40/00:00:00:4f:c2/00:00:00:00:00/00 Emask 0x4
(timeout)
[ 698.934589] ata3.00: status: { DRDY }
[ 703.986089] ata3: link is slow to respond, please be patient (ready=0)
[ 708.969586] ata3: device not ready (errno=-16), forcing hardreset
[ 708.969600] ata3: soft resetting link
[ 709.164047] ata3.00: configured for UDMA/100
[ 709.164063] ata3: EH complete
[ 741.938477] ata3.00: exception Emask 0x0 SAct 0x0 SErr 0x0 action 0x6 frozen
[ 741.938484] ata3.00: failed command: READ DMA EXT
[ 741.938489] ata3.00: cmd 25/00:00:47:9f:a3/00:08:01:00:00/e0 tag 0 dma
1048576 in
res 40/00:00:00:4f:c2/00:00:00:00:00/00 Emask 0x4
(timeout)
[ 741.938492] ata3.00: status: { DRDY }
[ 746.977880] ata3: link is slow to respond, please be patient (ready=0)
[ 751.957395] ata3: device not ready (errno=-16), forcing hardreset
[ 751.957410] ata3: soft resetting link
[ 752.152040] ata3.00: configured for UDMA/100
[ 752.152055] ata3: EH complete
[ 784.941944] ata3.00: exception Emask 0x0 SAct 0x0 SErr 0x0 action 0x6 frozen
[ 784.941951] ata3.00: failed command: READ DMA EXT
[ 784.941958] ata3.00: cmd 25/00:08:47:ac:da/00:04:01:00:00/e0 tag 0 dma
528384 in
res 40/00:00:00:4f:c2/00:00:00:00:00/00 Emask 0x4
(timeout)
[ 784.941961] ata3.00: status: { DRDY }
[ 789.985298] ata3: link is slow to respond, please be patient (ready=0)
[ 794.988755] ata3: device not ready (errno=-16), forcing hardreset
[ 794.988768] ata3: soft resetting link
[ 795.183363] ata3.00: configured for UDMA/100
[ 795.183377] ata3: EH complete
[ 827.945045] ata3.00: limiting speed to UDMA/33:PIO4
[ 827.945047] ata3.00: exception Emask 0x0 SAct 0x0 SErr 0x0 action 0x6 frozen
[ 827.945051] ata3.00: failed command: READ DMA
[ 827.945055] ata3.00: cmd c8/00:58:9f:ed:a4/00:00:00:00:00/e1 tag 0 dma 45056
in
res 40/00:00:00:4f:c2/00:00:00:00:00/00 Emask 0x4
(timeout)
[ 827.945056] ata3.00: status: { DRDY }
[ 832.996422] ata3: link is slow to respond, please be patient (ready=0)
[ 837.983822] ata3: device not ready (errno=-16), forcing hardreset
[ 837.983836] ata3: soft resetting link
[ 838.178364] ata3.00: configured for UDMA/33
[ 838.178377] ata3: EH complete
--
You are receiving this mail because:
You are watching the assignee of the bug.
^ permalink raw reply
* 6869 linux-ide
From: beautyink @ 2016-11-19 13:30 UTC (permalink / raw)
To: linux-ide
[-- Attachment #1: EMAIL_579870443386_linux-ide.zip --]
[-- Type: application/zip, Size: 12520 bytes --]
^ permalink raw reply
* Re: [PATCH] ahci: always fall back to single-MSI mode
From: Tejun Heo @ 2016-11-21 16:08 UTC (permalink / raw)
To: Christoph Hellwig; +Cc: michael, linux-ide
In-Reply-To: <1479474546-4413-1-git-send-email-hch@lst.de>
On Fri, Nov 18, 2016 at 02:09:06PM +0100, Christoph Hellwig wrote:
> Don't try to guess what the errors from pci_irq_alloc_vectors mean, as
> that's too fragile. Instead always try allocating a single vector
> when multi-MSI mode fails. This makes various intel Desktop and
> Laptop CPUs use MSI again.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> Reported-by: Michael Marley <michael@michaelmarley.com>
> Tested-by: Michael Marley <michael@michaelmarley.com>
> Fixes: 0b9e2988ab22 ("ahci: use pci_alloc_irq_vectors")
Applied to libata/for-4.9-fixes.
Thanks.
--
tejun
^ permalink raw reply
* (( UNO/WBO ))
From: U / N @ 2016-11-23 15:13 UTC (permalink / raw)
To: Recipients
Congratulations Beneficiary,
For more information please contact:
Name: Mrs. Sarah Amadi
Email: sarahamadi1970@gmail.com
Yours Faithfully,
Mr. Wu Hongbo
Under-Secretary-General for Economic and Social Affairs
^ permalink raw reply
* 26728 linux-ide
From: obsexitos @ 2016-11-24 6:07 UTC (permalink / raw)
To: linux-ide
[-- Attachment #1: INFO_763192453704_linux-ide.zip --]
[-- Type: application/zip, Size: 2556 bytes --]
^ permalink raw reply
* [PATCH v2 3/3] dt-bindings: ata: ahci_tegra: Add tegra210 AHCI
From: Preetham Chandru Ramchandra @ 2016-11-24 7:43 UTC (permalink / raw)
To: tj, swarren, thierry.reding, preetham260
Cc: ldewangan, linux-ide, vbyravarasu, pkunapuli, Preetham Chandru R
In-Reply-To: <1479973418-21351-1-git-send-email-pchandru@nvidia.com>
From: Preetham Chandru R <pchandru@nvidia.com>
Signed-off-by: Preetham Chandru R <pchandru@nvidia.com>
---
.../bindings/ata/nvidia,tegra124-ahci.txt | 48 ++++++++++++++++------
1 file changed, 36 insertions(+), 12 deletions(-)
diff --git a/Documentation/devicetree/bindings/ata/nvidia,tegra124-ahci.txt b/Documentation/devicetree/bindings/ata/nvidia,tegra124-ahci.txt
index 66c83c3..446214f 100644
--- a/Documentation/devicetree/bindings/ata/nvidia,tegra124-ahci.txt
+++ b/Documentation/devicetree/bindings/ata/nvidia,tegra124-ahci.txt
@@ -1,9 +1,9 @@
-Tegra124 SoC SATA AHCI controller
+Tegra SoC SATA AHCI controller
Required properties :
-- compatible : For Tegra124, must contain "nvidia,tegra124-ahci". Otherwise,
- must contain '"nvidia,<chip>-ahci", "nvidia,tegra124-ahci"', where <chip>
- is tegra132.
+- compatible : Must be one of:
+ - Tegra124 : "nvidia,tegra124-ahci"
+ - Tegra210 : "nvidia,tegra210-ahci"
- reg : Should contain 2 entries:
- AHCI register set (SATA BAR5)
- SATA register set
@@ -13,8 +13,6 @@ Required properties :
- clock-names : Must include the following entries:
- sata
- sata-oob
- - cml1
- - pll_e
- resets : Must contain an entry for each entry in reset-names.
See ../reset/reset.txt for details.
- reset-names : Must include the following entries:
@@ -24,9 +22,35 @@ Required properties :
- phys : Must contain an entry for each entry in phy-names.
See ../phy/phy-bindings.txt for details.
- phy-names : Must include the following entries:
- - sata-phy : XUSB PADCTL SATA PHY
-- hvdd-supply : Defines the SATA HVDD regulator
-- vddio-supply : Defines the SATA VDDIO regulator
-- avdd-supply : Defines the SATA AVDD regulator
-- target-5v-supply : Defines the SATA 5V power regulator
-- target-12v-supply : Defines the SATA 12V power regulator
+ - For T124:
+ - sata-phy : XUSB PADCTL SATA PHY
+ - For T210:
+ - sata-0
+- For T124:
+ - hvdd-supply : Defines the SATA HVDD regulator
+ - vddio-supply : Defines the SATA VDDIO regulator
+ - avdd-supply : Defines the SATA AVDD regulator
+ - target-5v-supply : Defines the SATA 5V power regulator
+- For T210:
+ - l0-hvddio-sata-supply : Defines the SATA HVDDIO regulator
+ - l0-dvddio-sata-supply : Defines the SATA DVDDIO regulator
+ - hvdd-pex-pll-e-supply : Defines the PEX PLL_E regulator
+ - dvdd-sata-pll-supply : Defines the SATA PLL regulator
+ - hvdd-sata-supply : Defines the SATA HVDD regulator
+- nvidia,disable-features : Must include the following entries:
+ - devslp
+ - dipm
+
+Optional properties:
+- clock-names :
+ - cml1 :
+ cml1 clock is required by phy so it is optional to define
+ here as phy driver will be enabling this clock.
+ - pll_e :
+ pll_e is the parent of cml1 clock so it is optional to define
+ here as phy driver will be enabling this clock.
+- nvidia,disable-features :
+ - hipm
+ - ncq
+ - partial
+ - slumber
--
2.1.4
^ permalink raw reply related
* [PATCH v2 0/3] ADD AHCI support for tegra210
From: Preetham Chandru Ramchandra @ 2016-11-24 7:43 UTC (permalink / raw)
To: tj, swarren, thierry.reding, preetham260
Cc: ldewangan, linux-ide, vbyravarasu, pkunapuli, Preetham Chandru R
From: Preetham Chandru R <pchandru@nvidia.com>
1. ADD AHCI support for tegra210
2. Add support to disable DIPM, HIPM, DevSlp,
partial, slumber, NCQ features from DT.
3. Extend the tegra AHCI controller device tree binding with tegra210
---
Preetham Chandru R (3):
ata: ahci_tegra: add support for tegra210
ata: ahci_tegra: Add support to disable features
dt-bindings: ata: ahci_tegra: Add tegra210 AHCI support
.../bindings/ata/nvidia,tegra124-ahci.txt | 48 +-
drivers/ata/ahci_tegra.c | 581 ++++++++++++++++-----
2 files changed, 483 insertions(+), 146 deletions(-)
--
2.1.4
^ permalink raw reply
* [PATCH v2 2/3] ata: ahci_tegra: Add support to disable features
From: Preetham Chandru Ramchandra @ 2016-11-24 7:43 UTC (permalink / raw)
To: tj, swarren, thierry.reding, preetham260
Cc: ldewangan, linux-ide, vbyravarasu, pkunapuli, Preetham Chandru R
In-Reply-To: <1479973418-21351-1-git-send-email-pchandru@nvidia.com>
From: Preetham Chandru R <pchandru@nvidia.com>
Add support to disable DIPM, HIPM, DevSlp, partial, slumber and NCQ
features from DT. By default these features are enabled.
Signed-off-by: Preetham Chandru R <pchandru@nvidia.com>
---
v2:
* This change was created by seperating
"ata: ahci_tegra: add support for tegra210" from v1
drivers/ata/ahci_tegra.c | 107 ++++++++++++++++++++++++++++++++++++-----------
1 file changed, 82 insertions(+), 25 deletions(-)
diff --git a/drivers/ata/ahci_tegra.c b/drivers/ata/ahci_tegra.c
index d12e2a9..443c3e8 100644
--- a/drivers/ata/ahci_tegra.c
+++ b/drivers/ata/ahci_tegra.c
@@ -329,7 +329,7 @@ static int tegra_ahci_power_on(struct ahci_host_priv *hpriv)
return ret;
}
-static void tegra_ahci_power_off(struct ahci_host_priv *hpriv)
+static void tegra_ahci_controller_deinit(struct ahci_host_priv *hpriv)
{
struct tegra_ahci_priv *tegra = hpriv->plat_data;
@@ -345,6 +345,85 @@ static void tegra_ahci_power_off(struct ahci_host_priv *hpriv)
regulator_bulk_disable(tegra->soc_data->num_supplies, tegra->supplies);
}
+static void tegra_ahci_host_stop(struct ata_host *host)
+{
+ struct ahci_host_priv *hpriv = host->private_data;
+
+ tegra_ahci_controller_deinit(hpriv);
+}
+
+static struct ata_port_operations ahci_tegra_port_ops = {
+ .inherits = &ahci_ops,
+ .host_stop = tegra_ahci_host_stop,
+};
+
+static struct ata_port_info ahci_tegra_port_info = {
+ .flags = AHCI_FLAG_COMMON,
+ .pio_mask = ATA_PIO4,
+ .udma_mask = ATA_UDMA6,
+ .port_ops = &ahci_tegra_port_ops,
+};
+
+static void tegra_ahci_disable_devslp(struct tegra_ahci_priv *tegra)
+{
+ tegra_ahci_aux_update(tegra, 0, SDS_SUPPORT, SATA_AUX_MISC_CNTL_1_0);
+}
+
+static void tegra_ahci_disable_hipm(struct tegra_ahci_priv *tegra)
+{
+ tegra_ahci_scfg_update(tegra, 0, T_SATA0_AHCI_HBA_CAP_BKDR_SALP,
+ T_SATA0_AHCI_HBA_CAP_BKDR);
+}
+
+static void tegra_ahci_disable_partial(struct tegra_ahci_priv *tegra)
+{
+ tegra_ahci_scfg_update(tegra, 0,
+ T_SATA0_AHCI_HBA_CAP_BKDR_PARTIAL_ST_CAP,
+ T_SATA0_AHCI_HBA_CAP_BKDR);
+}
+
+static void tegra_ahci_disable_slumber(struct tegra_ahci_priv *tegra)
+{
+ tegra_ahci_scfg_update(tegra, 0,
+ T_SATA0_AHCI_HBA_CAP_BKDR_SLUMBER_ST_CAP,
+ T_SATA0_AHCI_HBA_CAP_BKDR);
+}
+
+static void tegra_ahci_disable_ncq(struct tegra_ahci_priv *tegra)
+{
+ tegra_ahci_scfg_update(tegra, 0, T_SATA0_AHCI_HBA_CAP_BKDR_SNCQ,
+ T_SATA0_AHCI_HBA_CAP_BKDR);
+}
+
+static void tegra_ahci_disable_features(struct ahci_host_priv *hpriv)
+{
+ struct tegra_ahci_priv *tegra = hpriv->plat_data;
+ struct platform_device *pdev = tegra->pdev;
+ struct device *dev = &pdev->dev;
+ struct device_node *np = dev->of_node;
+ struct property *prop;
+ const char *feature;
+
+ if (of_property_count_strings(np, "nvidia,disable-features") <= 0)
+ return;
+
+ of_property_for_each_string(np, "nvidia,disable-features", prop,
+ feature) {
+ if (!strcmp(feature, "devslp"))
+ tegra_ahci_disable_devslp(tegra);
+ else if (!strcmp(feature, "hipm"))
+ tegra_ahci_disable_hipm(tegra);
+ else if (!strcmp(feature, "ncq"))
+ tegra_ahci_disable_ncq(tegra);
+ else if (!strcmp(feature, "dipm"))
+ ahci_tegra_port_info.flags |= ATA_FLAG_NO_DIPM;
+ else if (!strcmp(feature, "partial"))
+ tegra_ahci_disable_partial(tegra);
+ else if (!strcmp(feature, "slumber"))
+ tegra_ahci_disable_slumber(tegra);
+ }
+}
+
static int tegra_ahci_controller_init(struct ahci_host_priv *hpriv)
{
struct tegra_ahci_priv *tegra = hpriv->plat_data;
@@ -458,36 +537,14 @@ static int tegra_ahci_controller_init(struct ahci_host_priv *hpriv)
tegra_ahci_sata_update(tegra, 0, SATA_CONFIGURATION_CLK_OVERRIDE,
SATA_CONFIGURATION_0);
+ tegra_ahci_disable_features(hpriv);
+
tegra_ahci_sata_update(tegra, IP_INT_MASK, IP_INT_MASK,
SATA_INTR_MASK_0);
return 0;
}
-static void tegra_ahci_controller_deinit(struct ahci_host_priv *hpriv)
-{
- tegra_ahci_power_off(hpriv);
-}
-
-static void tegra_ahci_host_stop(struct ata_host *host)
-{
- struct ahci_host_priv *hpriv = host->private_data;
-
- tegra_ahci_controller_deinit(hpriv);
-}
-
-static struct ata_port_operations ahci_tegra_port_ops = {
- .inherits = &ahci_ops,
- .host_stop = tegra_ahci_host_stop,
-};
-
-static const struct ata_port_info ahci_tegra_port_info = {
- .flags = AHCI_FLAG_COMMON,
- .pio_mask = ATA_PIO4,
- .udma_mask = ATA_UDMA6,
- .port_ops = &ahci_tegra_port_ops,
-};
-
static const struct of_device_id tegra_ahci_of_match[] = {
{
.compatible = "nvidia,tegra124-ahci",
--
2.1.4
^ permalink raw reply related
page: next (older) | prev (newer) | latest
- recent:[subjects (threaded)|topics (new)|topics (active)]
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox