From: Andi Kleen <andi@firstfloor.org>
To: Tejun Heo <htejun@gmail.com>
Cc: gregkh@suse.de, Jeff Garzik <jeff@garzik.org>,
linux-kernel@vger.kernel.org, linux-pci@atrey.karlin.mff.cuni.cz,
michal.k.k.piotrowski@gmail.com, linux-ide@vger.kernel.org,
tglx@linutronix.de, shemminger@linux-foundation.org,
mlord@pobox.com, linux-pm@lists.osdl.org
Subject: Re: [PATCH/RFC] PCI prepare/activate instead of enable to avoid IRQ storm and rogue DMA access
Date: 14 Mar 2007 22:46:47 +0100 [thread overview]
Message-ID: <p73fy878pmg.fsf@bingen.suse.de> (raw)
In-Reply-To: <20070314152302.GB15600@htj.dyndns.org>
Tejun Heo <htejun@gmail.com> writes:
>
> Let's assume there's a device which shares its INTX IRQ line with
> another device and the other one is already initialized. During boot,
> due to BIOS's fault, bad hardware design or sheer bad luck, the device
> has got a pending IRQ.
This seems to be also common after kexec during kexec crashdumps
where the device just continues doing what it did before the crash.
> This patch expands the pci_set_master() approach. Instead of enabling
> the device in one go, it's done in two steps - prepare and activate.
> 'prepare' enables access to PCI configuration,
I hope there aren't any new erratas triggered by this. Perhaps it would
make sense to add some paranoia sleeps at least before touching other
state?
-Andi
next prev parent reply other threads:[~2007-03-14 20:47 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-14 15:23 [PATCH/RFC] PCI prepare/activate instead of enable to avoid IRQ storm and rogue DMA access Tejun Heo
2007-03-14 17:04 ` Alan Stern
2007-03-14 17:07 ` Stephen Hemminger
2007-03-15 2:37 ` Tejun Heo
2007-03-15 6:45 ` Grant Grundler
2007-03-16 21:21 ` Stephen Hemminger
2007-03-14 21:46 ` Andi Kleen [this message]
2007-03-15 2:39 ` Tejun Heo
2007-03-15 10:17 ` Andi Kleen
2007-03-15 11:41 ` Vivek Goyal
2007-03-14 21:56 ` Russell King
2007-03-14 22:34 ` Jeff Garzik
2007-03-14 22:58 ` Russell King
2007-03-14 23:16 ` Jeff Garzik
2007-03-15 5:47 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=p73fy878pmg.fsf@bingen.suse.de \
--to=andi@firstfloor.org \
--cc=gregkh@suse.de \
--cc=htejun@gmail.com \
--cc=jeff@garzik.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@atrey.karlin.mff.cuni.cz \
--cc=linux-pm@lists.osdl.org \
--cc=michal.k.k.piotrowski@gmail.com \
--cc=mlord@pobox.com \
--cc=shemminger@linux-foundation.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).