Re: [PATCH v1 2/7] ata: pata_cswarp: bind to the Warp mfd cell instead of the Zorro device

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] ata: pata_cswarp: duplicate ata_platform_remove_one() and
  module_platform_driver()
--

commit 0358845c5d4b9568f67a2b55aedc3acc1ebbdef0
Author: Paolo Pisati <p.pisati@gmail.com>

ata: pata_cswarp: bind to the Warp mfd cell instead of the Zorro device

This commit converts pata_cswarp from a Zorro driver into a platform driver
that binds to the "warp-pata" MFD cell provided by warp-mfd.

> diff --git a/drivers/ata/pata_cswarp.c b/drivers/ata/pata_cswarp.c
> index 58fe6d0012dc5..41b4c93052cfd 100644
> --- a/drivers/ata/pata_cswarp.c
> +++ b/drivers/ata/pata_cswarp.c

[ ... ]

> @@ -145,34 +135,29 @@ static int pata_cswarp_probe(struct zorro_dev *z,
>  			  IRQF_SHARED, &pata_cswarp_sht);
>  }
>  
> -static void pata_cswarp_remove(struct zorro_dev *z)
> +static void pata_cswarp_remove(struct platform_device *pdev)
>  {
> -	struct ata_host *host = dev_get_drvdata(&z->dev);
> +	struct ata_host *host = dev_get_drvdata(&pdev->dev);
>  
>  	ata_host_detach(host);
>  }
>  
> -static const struct zorro_device_id pata_cswarp_zorro_tbl[] = {
> -	{ .id = ZORRO_PROD_CSLAB_WARP_1260 },
> -	{ }
> -};
> -MODULE_DEVICE_TABLE(zorro, pata_cswarp_zorro_tbl);
> -
> -static struct zorro_driver pata_cswarp_driver = {
> -	.name           = "pata_cswarp",
> -	.id_table       = pata_cswarp_zorro_tbl,
> +static struct platform_driver pata_cswarp_driver = {
> +	.driver = {
> +		.name	= "warp-pata",
> +	},
>  	.probe          = pata_cswarp_probe,
>  	.remove         = pata_cswarp_remove,
>  };
>  
>  static int __init pata_cswarp_init(void)
>  {
> -	return zorro_register_driver(&pata_cswarp_driver);
> +	return platform_driver_register(&pata_cswarp_driver);
>  }
>  
>  static void __exit pata_cswarp_unregister(void)
>  {
> -	zorro_unregister_driver(&pata_cswarp_driver);
> +	platform_driver_unregister(&pata_cswarp_driver);
>  }

[Severity: Low]
Now that pata_cswarp is a platform_driver, could pata_cswarp_remove() be
replaced with libata's ata_platform_remove_one(), and pata_cswarp_init() /
pata_cswarp_unregister() with module_platform_driver(pata_cswarp_driver)?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261111163735.227286-1-p.pisati@gmail.com?part=2