From: sashiko-bot@kernel.org
To: "Arun Iyengar" <aiyengar1990@gmail.com>
Cc: devicetree@vger.kernel.org, linux-ide@vger.kernel.org,
robh@kernel.org, conor+dt@kernel.org, dlemoal@kernel.org,
cassel@kernel.org
Subject: Re: [PATCH 9/9] arm64: dts: rockchip: Enable the RK3588 PHP SMMU
Date: Sat, 14 Nov 2026 16:39:44 +0000 [thread overview]
Message-ID: <sashiko-outbox-214777@kernel.org> (raw)
In-Reply-To: <20261113-mmu600-php-v1-9-231196049a3b@gmail.com>
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [High] arm64: dts: rockchip: mmu600_php enabled without arm-smmu-v3
sleep PM support
--
commit 3839dbc025f5f6bf3346a2b85f6dda76ed471a93
Author: Arun Iyengar <aiyengar1990@gmail.com>
arm64: dts: rockchip: Enable the RK3588 PHP SMMU
This commit enables the mmu600_php IOMMU node on RK3588 SoCs by removing
its disabled status.
Link: https://lore.kernel.org/r/20260929034510.2023173-1-praan@google.com [1]
> diff --git a/arch/arm64/boot/dts/rockchip/rk3588-base.dtsi b/arch/arm64/boot/dts/rockchip/rk3588-base.dtsi
> index 2b6e14e7e1a3c..ed54d888caba2 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3588-base.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/rk3588-base.dtsi
> @@ -576,7 +576,6 @@ mmu600_php: iommu@fcb00000 {
> clocks = <&cru ACLK_MMU_PHP>;
> resets = <&cru SRST_A_MMU_PHP>;
> #iommu-cells = <1>;
> - status = "disabled";
> };
[Severity: High]
Does enabling mmu600_php break deep system suspend and resume while
arm_smmu_driver lacks .driver.pm sleep callbacks?
When PD_PHP is powered off during deep suspend, mmu600_php loses its
register state and resumes from reset in bypass mode with its command
queue disabled, while attached PHP masters (such as PCIe, SATA, GMAC, and
USB) remain bound to translated IOMMU DMA domains. On resume, DMA from
those devices uses virtual IOVAs directly as physical addresses on the
bus, corrupting memory, and subsequent command queue operations stall
until CMD_SYNC times out.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261113-mmu600-php-v1-0-231196049a3b@gmail.com?part=9
prev parent reply other threads:[~2026-11-14 16:39 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-13 16:38 [PATCH 0/9] RK3588: Enable the PHP SMMU Arun Iyengar via B4 Relay
2026-11-13 16:38 ` [PATCH 1/9] dt-bindings: net: rockchip-dwmac: Allow iommus Arun Iyengar via B4 Relay
2026-11-13 16:38 ` [PATCH 2/9] dt-bindings: ata: rockchip,dwc-ahci: " Arun Iyengar via B4 Relay
2026-11-13 16:38 ` [PATCH 3/9] dt-bindings: soc: rockchip: grf: Allow a clock for the RK3588 PHP GRF Arun Iyengar via B4 Relay
2026-11-13 16:38 ` [PATCH 4/9] soc: rockchip: grf: Assign the StreamIDs of the RK3588 PHP SMMU masters Arun Iyengar via B4 Relay
2026-11-13 16:38 ` [PATCH 5/9] arm64: dts: rockchip: Add the PHP GRF clock on RK3588 Arun Iyengar via B4 Relay
2026-11-13 16:38 ` [PATCH 6/9] soc: rockchip: grf: Restore the RK3588 PHP StreamIDs after system suspend Arun Iyengar via B4 Relay
2026-11-13 16:38 ` [PATCH 7/9] arm64: dts: rockchip: Add the clock and reset of the RK3588 PHP SMMU Arun Iyengar via B4 Relay
2026-11-13 16:38 ` [PATCH 8/9] arm64: dts: rockchip: Attach the masters " Arun Iyengar via B4 Relay
2026-11-13 16:38 ` [PATCH 9/9] arm64: dts: rockchip: Enable " Arun Iyengar via B4 Relay
2026-11-14 16:39 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-214777@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=aiyengar1990@gmail.com \
--cc=cassel@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlemoal@kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox