From: Stefan Richter <stefanr@s5r6.in-berlin.de>
To: linux-ide@vger.kernel.org
Cc: Jeff Garzik <jeff@garzik.org>, Tejun Heo <tj@kernel.org>,
linux-doc@vger.kernel.org
Subject: [PATCH] libata-sff: clarification and trivial correction to Kconfig text
Date: Sun, 30 May 2010 16:00:18 +0200 (CEST) [thread overview]
Message-ID: <tkrat.acb772e71ffffd6e@s5r6.in-berlin.de> (raw)
In-Reply-To: <4C0225D1.90205@kernel.org>
Change the text of the ATA_BMDMA prompt to indicate that it lets one access a class of
device drivers (rather than only add a certain feature to libata). The divisions of
the "ATA SFF support" menu now read
- SFF controllers with custom DMA interface,
- SFF controllers with bus master DMA (was: "ATA BMDMA support"),
- SATA SFF controllers with BMDMA,
- PATA SFF controllers with BMDMA,
- PIO-only SFF controllers.
This hopefully helps convince users of "make oldconfig" to follow the
recommendation to switch that option on.
Also let the help text of this prompt say more precisely what it is about: It adds a
little bit of support code to libata that is required by many but not all SFF drivers.
This option alone does not add support of respective controllers though; according
drivers are chosen at subsequent dependent Kconfig prompts. --- And fix a typo.
Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
---
Supersedes patch "libata-sff: trivial corrections to Kconfig help text".
drivers/ata/Kconfig | 10 +++++-----
1 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig
index 73f8833..31e288b 100644
--- a/drivers/ata/Kconfig
+++ b/drivers/ata/Kconfig
@@ -164,14 +164,14 @@ config SATA_SX4
If unsure, say N.
config ATA_BMDMA
- bool "ATA BMDMA support"
+ bool "SFF controllers with bus master DMA"
default y
help
- This option adds support for SFF ATA controllers with BMDMA
- capability. BMDMA stands for bus-master DMA and the
- de-facto DMA interface for SFF controllers.
+ This option is required by drivers of SFF ATA controllers with
+ BMDMA capability. BMDMA stands for bus master DMA and is the
+ de facto DMA interface for SFF controllers.
- If unuser, say Y.
+ If unsure, say Y.
if ATA_BMDMA
--
Stefan Richter
-=====-==-=- -=-= ====-
http://arcgraph.de/sr/
next prev parent reply other threads:[~2010-05-30 14:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-29 10:47 [PATCH] libata-sff: trivial corrections to Kconfig help text Stefan Richter
2010-05-29 12:38 ` Tejun Heo
2010-05-29 15:41 ` Stefan Richter
2010-05-30 8:46 ` Tejun Heo
2010-05-30 14:00 ` Stefan Richter [this message]
2010-05-30 15:05 ` [PATCH] libata-sff: clarification and trivial correction to Kconfig text Tejun Heo
2010-06-02 17:50 ` [PATCH] libata-sff: trivial corrections to Kconfig help text Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tkrat.acb772e71ffffd6e@s5r6.in-berlin.de \
--to=stefanr@s5r6.in-berlin.de \
--cc=jeff@garzik.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).