From: Adam Sampson <azz@us-lot.org>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: torvalds@osdl.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-ide@vger.kernel.org,
Bartlomiej Zolnierkiewicz <B.Zolnierkiewicz@elka.pw.edu.pl>
Subject: Re: PATCH: (Discussion) Stop IDE legacy ISA probes on PCI systems
Date: Mon, 27 Dec 2004 21:15:26 +0000 [thread overview]
Message-ID: <y2a7jn34f4h.fsf@cartman.at.fivegeeks.net> (raw)
In-Reply-To: <1104156823.20898.21.camel@localhost.localdomain> (Alan Cox's message of "Mon, 27 Dec 2004 14:13:45 +0000")
Alan Cox <alan@lxorguk.ukuu.org.uk> writes:
> switch (index) {
> case 0: return 0x1f0;
> case 1: return 0x170;
> +
> + if(pci_find_device(PCI_ANY_ID, PCI_ANY_ID, NULL) == NULL) {
> + case 2: return 0x1e8;
> + case 3: return 0x168;
> + case 4: return 0x1e0;
> + case 5: return 0x160;
> + }
> +
> default:
> return 0;
> }
I don't think that code will have the intended effect, unless your
GCC has some funny ideas about switch statements...
--
Adam Sampson <azz@us-lot.org> <http://offog.org/>
next prev parent reply other threads:[~2004-12-27 21:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-12-27 14:13 PATCH: (Discussion) Stop IDE legacy ISA probes on PCI systems Alan Cox
2004-12-27 21:15 ` Adam Sampson [this message]
2004-12-27 22:15 ` Valdis.Kletnieks
2004-12-28 0:29 ` Linus Torvalds
2004-12-28 3:58 ` Coywolf Qi Hunt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=y2a7jn34f4h.fsf@cartman.at.fivegeeks.net \
--to=azz@us-lot.org \
--cc=B.Zolnierkiewicz@elka.pw.edu.pl \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).