From: Robert Hancock <hancockrwd@gmail.com>
To: Richard Mawson <richard@crow.mawsonit.co.uk>
Cc: Tejun Heo <htejun@gmail.com>, linux-ide@vger.kernel.org
Subject: Re: SATA driver sata_sil24
Date: Fri, 23 Apr 2010 18:34:36 -0600	[thread overview]
Message-ID: <y2i51f3faa71004231734hbcda3ad5p61798db712cc87c5@mail.gmail.com> (raw)
In-Reply-To: <20100423203446.GF1883@crow.mawsonit.co.uk>
On Fri, Apr 23, 2010 at 2:34 PM, Richard Mawson
<richard@crow.mawsonit.co.uk> wrote:
> On Thu, Apr 22, 2010 at 09:23:10PM -0600, Robert Hancock wrote:
>> Hmm, that seems like this line in drivers/ata/sata_sil24.c:
>>
>>         /* Set max read request size to 4096.  This slightly increases
>>          * write throughput for pci-e variants.
>>          */
>>         pcie_set_readrq(pdev, 4096);
>>
>> Can you try commenting out or deleting that line and rebuilding, and see
>> if things work better? That's not really a solution, but if it worked,
>> it would indicate there's something about the system configuration with
>> that converter card installed that explodes when trying to set the max
>> read request size. In that case can you post the output of "lspci -vv"
>> and the full dmesg boot log?
>
> Having put printk messages all over the driver, I see it currently locks up
> during this readl call:
>
>                /* Clear port RST */
>                tmp = readl(port + PORT_CTRL_STAT);
>
> .. but as this is clearly later on from the previously mentioned stack, I'm
> starting to suspect that this is failing in random places when talking across
> this pci-pcie bridge. Do you agree that this sounds plausible?
I suspect it's something like that - not sure what else could cause
things to explode at that point..
>
> I did attempt to get a crash dump, but failed to get any joy from using the
> nmi watchdog to trigger the use of the debug kernel in this state.
>
> I will attempt using a different machine, hopefully tomorrow, but I have no
> native pcie machines so can't eliminate the pci-pcie bridge being at fault.
>
> Thanks for your help.
>
> --
> Richard Mawson
> Mawson IT Services
>
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.9 (GNU/Linux)
>
> iEYEARECAAYFAkvSBGYACgkQEqu+mbnN8VKZTgCeMu3flpdyVdp7smp8qaaJPGIp
> 8h8AnReBz04O1NVYqD16zLnYcnN9NNHZ
> =bANg
> -----END PGP SIGNATURE-----
>
>
next prev parent reply	other threads:[~2010-04-24  0:34 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20100422083226.GA6018@crow.mawsonit.co.uk>
     [not found] ` <4BD0203C.7010903@gmail.com>
2010-04-22 12:17   ` SATA driver sata_sil24 Richard Mawson
2010-04-22 13:33     ` Tejun Heo
2010-04-22 22:33       ` Richard Mawson
2010-04-23  3:23         ` Robert Hancock
2010-04-23 14:06           ` Richard Mawson
2010-04-23 20:34           ` Richard Mawson
2010-04-24  0:34             ` Robert Hancock [this message]
2010-04-24  4:16               ` Stan Hoeppner
2010-04-24  5:10               ` Richard Mawson
2010-04-26 11:59                 ` Tim Small
     [not found]                   ` <20100429091436.GO5360@crow.mawsonit.co.uk>
2010-04-29 14:43                     ` Robert Hancock
2010-04-25 16:21               ` Richard Mawson
     [not found]                 ` <4BD50012.1030103@hardwarefreak.com>
2010-04-26  8:17                   ` Richard Mawson
     [not found]                     ` <4BD567CE.9070905@hardwarefreak.com>
2010-04-26 11:25                       ` Richard Mawson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox
  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):
  git send-email \
    --in-reply-to=y2i51f3faa71004231734hbcda3ad5p61798db712cc87c5@mail.gmail.com \
    --to=hancockrwd@gmail.com \
    --cc=htejun@gmail.com \
    --cc=linux-ide@vger.kernel.org \
    --cc=richard@crow.mawsonit.co.uk \
    /path/to/YOUR_REPLY
  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
  Be sure your reply has a Subject: header at the top and a blank line
  before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).