From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Damien Le Moal <dlemoal@kernel.org>
Cc: linux-ide@vger.kernel.org, linux-scsi@vger.kernel.org,
"Martin K . Petersen" <martin.petersen@oracle.com>,
John Garry <john.g.garry@oracle.com>,
Rodrigo Vivi <rodrigo.vivi@intel.com>,
Paul Ausbeck <paula@soe.ucsc.edu>,
Kai-Heng Feng <kai.heng.feng@canonical.com>,
Joe Breuer <linux-kernel@jmbreuer.net>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Chia-Lin Kao <acelan.kao@canonical.com>
Subject: Re: [PATCH v5 00/23] Fix libata suspend/resume handling and code cleanup
Date: Thu, 21 Sep 2023 21:28:15 -0400 [thread overview]
Message-ID: <yq134z7577n.fsf@ca-mkp.ca.oracle.com> (raw)
In-Reply-To: <20230921180758.955317-1-dlemoal@kernel.org> (Damien Le Moal's message of "Fri, 22 Sep 2023 03:07:35 +0900")
Damien,
> The first 9 patches of this series fix several issues with
> suspend/resume power management operations in scsi and libata. The
> most significant changes introduced are in patch 4 and 5, where the
> manage_start_stop flag of scsi devices is split into the
> manage_system_start_stop and manage_runtime_start_stop flags to allow
> keeping scsi runtime power operations for spining up/down ATA devices
> but have libata do its own system suspend/resume device power state
> management using EH.
Cosmetic nits aside, no objections from me. Glad to finally see the
ATA-SCSI binding established!
Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>
--
Martin K. Petersen Oracle Linux Engineering
prev parent reply other threads:[~2023-09-22 1:29 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-21 18:07 [PATCH v5 00/23] Fix libata suspend/resume handling and code cleanup Damien Le Moal
2023-09-21 18:07 ` [PATCH v5 01/23] ata: libata-core: Fix ata_port_request_pm() locking Damien Le Moal
2023-09-21 18:07 ` [PATCH v5 02/23] ata: libata-core: Fix port and device removal Damien Le Moal
2023-09-21 18:07 ` [PATCH v5 03/23] ata: libata-scsi: link ata port and scsi device Damien Le Moal
2023-09-22 6:33 ` John Garry
2023-09-21 18:07 ` [PATCH v5 04/23] scsi: sd: Differentiate system and runtime start/stop management Damien Le Moal
2023-09-22 1:25 ` Martin K. Petersen
2023-09-22 12:44 ` Damien Le Moal
2023-09-21 18:07 ` [PATCH v5 05/23] ata: libata-scsi: Disable scsi device manage_system_start_stop Damien Le Moal
2023-09-21 18:07 ` [PATCH v5 06/23] scsi: Do not attempt to rescan suspended devices Damien Le Moal
2023-09-21 18:07 ` [PATCH v5 07/23] ata: libata-scsi: Fix delayed scsi_rescan_device() execution Damien Le Moal
2023-09-21 18:07 ` [PATCH v5 08/23] ata: libata-core: Do not register PM operations for SAS ports Damien Le Moal
2023-09-21 18:07 ` [PATCH v5 09/23] scsi: sd: Do not issue commands to suspended disks on shutdown Damien Le Moal
2023-09-22 18:14 ` Bart Van Assche
2023-09-22 19:10 ` Damien Le Moal
2023-09-22 20:08 ` Bart Van Assche
2023-09-22 20:36 ` Damien Le Moal
2023-09-22 21:32 ` Bart Van Assche
2023-09-21 18:07 ` [PATCH v5 10/23] ata: libata-core: Fix compilation warning in ata_dev_config_ncq() Damien Le Moal
2023-09-21 18:07 ` [PATCH v5 11/23] ata: libata-eh: Fix compilation warning in ata_eh_link_report() Damien Le Moal
2023-09-21 18:07 ` [PATCH v5 12/23] scsi: Remove scsi device no_start_on_resume flag Damien Le Moal
2023-09-21 18:07 ` [PATCH v5 13/23] ata: libata-scsi: Cleanup ata_scsi_start_stop_xlat() Damien Le Moal
2023-09-21 18:07 ` [PATCH v5 14/23] ata: libata-core: Synchronize ata_port_detach() with hotplug Damien Le Moal
2023-09-21 18:07 ` [PATCH v5 15/23] ata: libata-core: Detach a port devices on shutdown Damien Le Moal
2023-09-21 18:07 ` [PATCH v5 16/23] ata: libata-core: Remove ata_port_suspend_async() Damien Le Moal
2023-09-22 15:44 ` Sergey Shtylyov
2023-09-21 18:07 ` [PATCH v5 17/23] ata: libata-core: Remove ata_port_resume_async() Damien Le Moal
2023-09-21 18:07 ` [PATCH v5 18/23] ata: libata-core: Do not poweroff runtime suspended ports Damien Le Moal
2023-09-21 18:07 ` [PATCH v5 19/23] ata: libata-core: Do not resume " Damien Le Moal
2023-09-21 18:07 ` [PATCH v5 20/23] ata: libata-sata: Improve ata_sas_slave_configure() Damien Le Moal
2023-09-21 18:07 ` [PATCH v5 21/23] ata: libata-eh: Improve reset error messages Damien Le Moal
2023-09-21 18:07 ` [PATCH v5 22/23] ata: libata-eh: Reduce "disable device" message verbosity Damien Le Moal
2023-09-21 18:07 ` [PATCH v5 23/23] ata: libata: Cleanup inline DMA helper functions Damien Le Moal
2023-09-22 1:28 ` Martin K. Petersen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq134z7577n.fsf@ca-mkp.ca.oracle.com \
--to=martin.petersen@oracle.com \
--cc=acelan.kao@canonical.com \
--cc=dlemoal@kernel.org \
--cc=geert@linux-m68k.org \
--cc=john.g.garry@oracle.com \
--cc=kai.heng.feng@canonical.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@jmbreuer.net \
--cc=linux-scsi@vger.kernel.org \
--cc=paula@soe.ucsc.edu \
--cc=rodrigo.vivi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox