From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: David Milburn <dmilburn@redhat.com>
Cc: "Martin K. Petersen" <martin.petersen@oracle.com>,
linux-ide@vger.kernel.org, hare@suse.de, tj@kernel.org
Subject: Re: [PATCH 4/4] libata: Fall back to unqueued READ LOG EXT if the DMA variant fails
Date: Tue, 16 Jun 2015 12:43:24 -0400 [thread overview]
Message-ID: <yq14mm7hadv.fsf@sermon.lab.mkp.net> (raw)
In-Reply-To: <20150615152459.GA14007@dhcp-10-15-1-8.hsv.redhat.com> (David Milburn's message of "Mon, 15 Jun 2015 10:24:59 -0500")
>>>>> "David" == David Milburn <dmilburn@redhat.com> writes:
David> Ahh, ok, would it be ok to slightly change the error message to
David> indicate the drive doesn't support queued TRIM.
I don't have a problem with your more elaborate debug message.
It is a clear bug in the drive firmware, though. The ACS spec mandates
that the log page shall be supported if IDENTIFY DEVICE word 77, bit 6
is set.
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2015-06-16 16:43 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-05 1:54 [PATCH 1/4] libata: Allow NCQ TRIM to be enabled or disabled with a module parameter Martin K. Petersen
2015-05-05 1:54 ` [PATCH 2/4] libata: Expose TRIM capability in sysfs Martin K. Petersen
2015-05-05 5:54 ` Hannes Reinecke
2015-05-05 17:50 ` Christoph Hellwig
2015-05-05 21:54 ` Martin K. Petersen
2015-05-05 1:54 ` [PATCH 3/4] libata: READ LOG DMA EXT support can be in either page 119 or 120 Martin K. Petersen
2015-05-05 6:00 ` Hannes Reinecke
2015-05-05 1:54 ` [PATCH 4/4] libata: Fall back to unqueued READ LOG EXT if the DMA variant fails Martin K. Petersen
2015-05-05 6:00 ` Hannes Reinecke
2015-06-12 19:58 ` David Milburn
2015-06-14 23:45 ` Martin K. Petersen
2015-06-15 15:24 ` David Milburn
2015-06-16 16:43 ` Martin K. Petersen [this message]
2015-05-05 5:51 ` [PATCH 1/4] libata: Allow NCQ TRIM to be enabled or disabled with a module parameter Hannes Reinecke
2015-05-05 13:31 ` Tejun Heo
2015-05-05 14:07 ` Hannes Reinecke
2015-05-05 21:57 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq14mm7hadv.fsf@sermon.lab.mkp.net \
--to=martin.petersen@oracle.com \
--cc=dmilburn@redhat.com \
--cc=hare@suse.de \
--cc=linux-ide@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).