From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: "Martin K. Petersen" <martin.petersen@oracle.com>,
jens.axboe@oracle.com, james.bottomley@hansenpartnership.com,
willy@wil.cx, jgarzik@pobox.com, sandeen@redhat.com,
rwheeler@redhat.com, linux-ide@vger.kernel.org,
linux-scsi@vger.kernel.org
Subject: Re: [PATCH 4/4] libata: Fix garbled Trim payload
Date: Sat, 21 Nov 2009 14:50:35 -0500 [thread overview]
Message-ID: <yq16393slmc.fsf@sermon.lab.mkp.net> (raw)
In-Reply-To: <20091121104701.GA30153@infradead.org> (Christoph Hellwig's message of "Sat, 21 Nov 2009 05:47:01 -0500")
>>>>> "Christoph" == Christoph Hellwig <hch@infradead.org> writes:
Christoph> On Fri, Nov 20, 2009 at 09:45:24PM -0500, Martin K. Petersen wrote:
>> ata_set_lba_range_entries confused indexes into a u64 buffer with
>> byte offsets. Fix this up and document the return value.
>>
>> Update the libata write same translation to reflect this.
Christoph> Once we fix up this beast we should also change the current
Christoph> max argument to encode the buffer size, not the maximum
Christoph> number of entries which is a rather confusing interface.
What threw me off yesterday was that `max' starts out being a cap on the
number of 8-byte entries in the buffer. And then towards the end it
suddenly turns into a number-of-bytes entity as a result of the ALIGN
macro.
I agree that we should fix this up to be consistent. I'll do that.
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2009-11-21 19:50 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-21 2:45 Thin provisioning fixes Martin K. Petersen
2009-11-21 2:45 ` [PATCH 1/4] block: Allow devices to indicate whether discarded blocks are zeroed Martin K. Petersen
2009-11-21 10:13 ` Christoph Hellwig
2009-11-21 19:58 ` Matthew Wilcox
2009-11-22 2:43 ` Mark Lord
2009-11-23 16:37 ` Ric Wheeler
2009-11-23 16:54 ` Greg Freemyer
2009-11-23 17:02 ` Ric Wheeler
2009-11-23 17:03 ` Christoph Hellwig
2009-11-23 17:50 ` Eric Sandeen
2009-11-23 17:05 ` Christoph Hellwig
2009-11-21 12:50 ` Ric Wheeler
2009-11-21 20:17 ` Martin K. Petersen
2009-11-21 2:45 ` [PATCH 2/4] sd: WRITE SAME(16) / UNMAP support Martin K. Petersen
2009-11-21 2:45 ` [PATCH 3/4] libata: Report zeroed read after Trim and max discard size Martin K. Petersen
2009-11-21 10:49 ` Christoph Hellwig
2009-11-21 20:16 ` Martin K. Petersen
2009-11-24 14:35 ` Christoph Hellwig
2009-11-24 15:20 ` Mark Lord
2009-11-24 15:21 ` Christoph Hellwig
2009-11-21 2:45 ` [PATCH 4/4] libata: Fix garbled Trim payload Martin K. Petersen
2009-11-21 10:47 ` Christoph Hellwig
2009-11-21 19:50 ` Martin K. Petersen [this message]
2009-11-21 4:56 ` Thin provisioning fixes Eric Sandeen
2009-11-21 6:08 ` Martin K. Petersen
2009-11-21 6:55 ` Martin K. Petersen
2009-11-26 10:59 ` Christoph Hellwig
2009-11-26 11:01 ` Jens Axboe
2009-11-26 11:05 ` Christoph Hellwig
2009-11-26 15:13 ` Mark Lord
2009-11-26 15:14 ` Mark Lord
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq16393slmc.fsf@sermon.lab.mkp.net \
--to=martin.petersen@oracle.com \
--cc=hch@infradead.org \
--cc=james.bottomley@hansenpartnership.com \
--cc=jens.axboe@oracle.com \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=rwheeler@redhat.com \
--cc=sandeen@redhat.com \
--cc=willy@wil.cx \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).