From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Martin K. Petersen" Subject: Re: [RFC] libata-scsi: make sure Maximum Write Same Length is not too large Date: Tue, 16 Aug 2016 00:15:15 -0400 Message-ID: References: <833713246c1a70d85150289c1537797d6f7dd606.1470903899.git.tom.ty89@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: In-Reply-To: (Tom Yan's message of "Sun, 14 Aug 2016 17:23:45 +0800") Sender: linux-scsi-owner@vger.kernel.org To: Tom Yan Cc: "Martin K. Petersen" , Tejun Heo , Shaun Tancheff , Shaun Tancheff , linux-ide@vger.kernel.org, linux-scsi@vger.kernel.org, linux-block@vger.kernel.org List-Id: linux-ide@vger.kernel.org >>>>> "Tom" == Tom Yan writes: Tom, Tom> The thing is, as of ACS-4, blocks that carry DSM/TRIM LBA Range Tom> Entries are always 512-byte. Lovely. And SAT conveniently ignores this entirely. Tom> Honestly, I have no idea how that would work on a 4Kn SSD, if it is Tom> / will ever be a thing. Highly unlikely. But I guess you would have to report 8 512-byte ranges in the 4Kn case. And then rely on the patch we talked about to clamp the number of sectors based on the block layer limit. -- Martin K. Petersen Oracle Linux Engineering