From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Christoph Hellwig <hch@lst.de>
Cc: jgarzik@pobox.com, linux-ide@vger.kernel.org, stable@kernel.org
Subject: Re: [PATCH v2] libata: fix ata_id_logical_per_physical_sectors
Date: Wed, 03 Feb 2010 13:14:23 -0500 [thread overview]
Message-ID: <yq1bpg6mbk0.fsf@sermon.lab.mkp.net> (raw)
In-Reply-To: <20100203173721.GA21703@lst.de> (Christoph Hellwig's message of "Wed, 3 Feb 2010 18:37:21 +0100")
>>>>> "Christoph" == Christoph Hellwig <hch@lst.de> writes:
Christoph> Without this patch the minimum I/O size for 4k drives will be
Christoph> reported incorrectly, which will make paritions misaligned on
Christoph> modern distros.
I'm in total agreement with the patch (feel free to add my Acked-by:).
However, the minimum I/O size should still be reported correctly. We
don't allow min_io to be smaller than physical_block_size...
[root@10 ~]# grep . /sys/block/sdc/queue/{logical_block,physical_block,minimum_io}_size
/sys/block/sdc/queue/logical_block_size:512
/sys/block/sdc/queue/physical_block_size:4096
/sys/block/sdc/queue/minimum_io_size:4096
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2010-02-03 18:16 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-28 10:42 [PATCH] libata: fix ata_id_logical_per_physical_sectors Christoph Hellwig
2010-01-28 10:56 ` Sergei Shtylyov
2010-01-28 10:59 ` Christoph Hellwig
2010-01-28 12:30 ` [PATCH v2] " Christoph Hellwig
2010-02-03 17:37 ` Christoph Hellwig
2010-02-03 17:42 ` Jeff Garzik
2010-02-03 18:14 ` Martin K. Petersen [this message]
2010-02-03 18:17 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1bpg6mbk0.fsf@sermon.lab.mkp.net \
--to=martin.petersen@oracle.com \
--cc=hch@lst.de \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).