Re: pata_cs5536: ATA driver for Geode companion chip

["Martin K. Petersen" <mkp@mkp.net>]

>>>>> "Jordan" == Jordan Crouse <jordan.crouse@amd.com> writes:

Jordan> Agreed.  It sounds like there is still breakage in the BIOS -
Jordan> since the reference VSA code accounts for accesses of
Jordan> different alignments, but its probably not worth going back
Jordan> and forth about it.  Like I said, if Alan and Jeff are game,
Jordan> we should go with the 5536 driver, and now that we've debated
Jordan> it extensively, I'm fine with the MSR accesses - I'm satisfied
Jordan> that we at least considered the alternative and dismissed it
Jordan> for technically sound reasons.

I'm going to post two patches.  One using MSR accesses and one using
PCI.

Mixing the two access methods was the third option but I think that's
more of an academic exercise.  MSR will always work so why try poking
holes in PCI config space first?  The BIOS I have now exhibits one
problem.  The one from last week had another.  Instead of trying to
work around bug-du-jour I'd rather not depend on the BIOS getting
things right.  And it's less than a handful of register writes we're
talking about here.  Hardly worth it to come up with fallback
heuristics for something that trivial.

But both patches are working with the BIOS from yesterday.  Pick your
poison :)

-- 
Martin K. Petersen      http://mkp.net/