From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Christoph Hellwig <hch@lst.de>
Cc: tj@kernel.org, linux-ide@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH] libata: reject passthrough WRITE SAME requests
Date: Tue, 25 Apr 2017 12:31:08 -0400 [thread overview]
Message-ID: <yq1mvb4fnzn.fsf@oracle.com> (raw)
In-Reply-To: <20170425113954.23121-1-hch@lst.de> (Christoph Hellwig's message of "Tue, 25 Apr 2017 13:39:54 +0200")
Christoph,
> The WRITE SAME to TRIM translation rewrites the DATA OUT buffer. While
> the SCSI code accomodates for this by passing a read-writable buffer
> userspace applications don't cater for this behavior. In fact it can
> be used to rewrite e.g. a readonly file through mmap and should be
> considered as a security fix.
Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2017-04-25 16:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-25 11:39 [PATCH] libata: reject passthrough WRITE SAME requests Christoph Hellwig
2017-04-25 16:31 ` Martin K. Petersen [this message]
2017-04-28 22:09 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1mvb4fnzn.fsf@oracle.com \
--to=martin.petersen@oracle.com \
--cc=hch@lst.de \
--cc=linux-ide@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox